Country Flags Extensions

Litalino

Add country flags attribute to Flarum Users

Install with composer:

composer require litalino/flarum-country-flags:"*"

Updating
composer update litalino/flarum-country-flags:"*"
php flarum migrate
php flarum cache:clear

PLugin Developer: justoverclock/country-flags

PLugin Clone Co-development: Litalino/flarum-country-flags

Updating from justoverclock
This extension replaces Country Flags.

Please backup your data before attempting the update!

You can upgrade from any of the older versions of the Country Flags extension.

Then upgrade from the old extension to the new one:

composer require litalino/flarum-country-flags

When you enable the new extension, the permissions, settings and the data from Justoverclockl Country Flags will be moved to Litalino Country Flags.

Admin

Demo test: https://fla.khatvongsong.vn/ Click Sign Up

Links

Update: V1.5.0

GreXXL

Litalino please add links to GitHub and Packagist. Thanks

Gorm

Flarum 1.8.5. Extension installed with composer require litalino/flarum-country-flags
We are detect a bug!!

Reproduce:

Сountry code required for registration.
Request password change via mail.
Users cant restore their accounts cause its require Contry code too, but restore-form didnt have this fields. Even if user already have selected country in profile.

Settings just like on screen:

Litalino

Gorm

I didn't find any of the 3 errors you gave

Try clearing your cache and see

Gorm

Litalino it is not 3 errors >_<, its just a steps for reproduce an error. You have done 1-2 steps and didnt complete last one.
When you enter new password and fill the confirmation, when you press Save Changes with new password, you will see "The country code field is required".
Cache cleared after install and also cleaned each time when settings changed. So its not cache related. Also, country code already set in my profile.

PS. Ot just press Save Changes.. You will get an errors:

Litalino

Gorm I will check and fix it soon .. Thanks you for letting me know the error

Gorm

Litalino also, we need very important thing. How to add country flag in head for language selection? For me now it's just e.g. Русский (visible), but second option, e.g. English is hidden. And if your foreign users didnt know first (active) language they cant change language cause they didnt understand where is language selector located. We need small country flag in front of language title.

Maybe this is about this extension, maybe not. Maybe its about translations, maybe it need core-improvements or just separate extension.

Litalino

Gorm

Update: V1.5.0
Fixer: Password recovery: The Country field is required

Command:

composer update litalino/flarum-country-flags:"*"
php flarum cache:clear

Gorm

Litalino error is gone with new version. All works just fine, Flarum 1.8.5 + all updates. Many thanks!

This is related to country flag in front of current language in header: https://discuss.flarum.org/d/1545-russian-language-pack/633

Litalino

Gorm Your question about the flag image before the language conversion text belongs to Flarum's default plugin.. it is not related to the plugin country.. you can contact there.

Gorm

The question is How to add country flag in head for language selection? It is very actual for multilingual installs. For me now it's just e.g. Русский (visible), but second option, e.g. English is hidden (not visible). And if your foreign users didnt know first (active) language they cant change language cause they didnt understand where is language selector located. We need small country flag in front of language title.

I am already discuss it with language pack mantainers and Country Flag extension authors.

And how notice KaiKimera, all language packs have an icon - country flag. So, all needed resource already uploaded.
And how notice Litalino it can be done in Flarum's default plugin.

Gorm

Bogus detected 🙁

Seems last version of Country Flags extension brokes registration.

When Country Flags is disabled all works just as expected.
When Country Flags is enabled.. It have 2 ways.
From main page all works fine.
But when you try to register from any discussion - users didnt get errors in form (e.g. short password) and form didnt react any more.

In console I see an errors like

Uncaught TypeError: a.options is undefined
    <anonymous> index.js:424
    e extend.ts:39
    onsubmit SignUpModal.tsx:170
    handleEvent render.js:888

Users get infinite loading..

UPDATE: error appear only when options "Show flags on post" and "Required entering country" enabled. I turn it on before update to 1.5. So, maybe this bug also related to 1.4. So, main page didnt contain posts and flags - registration works. All pages with flags - registration goes to infinite loading in case of error (e.g. short password). Affected: discussions, user profiles (/u/login).

My user stats shows -50% of new users last 7 days. And I just check and got an error. Cause of error decide to disable "Show flags on post" option until fixes.

Tested with last Firefox on Windows 10 (all updates). Maybe its not affected with mobile version (mobile Chrome etc).

Litalino

Gorm I don't take any errors from you... can you give me your website to know your errors?

Gorm

Litalino I will record a gif for you.

Gorm

Litalino

this record shows settings and all works fine: https://ibb.co/Gk7RTFp (form have all needed warnings and react with user)
this record show changed settings and registration is broken: https://ibb.co/TqfCn0w (registration form stop working after any error and users didnt see any errors, just infinite loading and users cant register)

Error affected only on pages with flags (discussions, profiles). If I try to register from main page - all works fine. If you try with all correct data - it may work, I didnt try 🙂

I detect this glitch with statistics analyze: https://ibb.co/CvxqPQ7
25.01 - "Show flags on post" option is enabled.
30.01 - "Show flags on post" option is disabled.

Only one settings changed or you can try to register (with short password etc) from profile page which have flags in both case.

Last version still affected.

PS. Sorry for poor quality of gif. I check it after upload. It will be available for 1 day.

Litalino

Update V1.6.0
Bind Required entering country

composer update litalino/flarum-country-flags:"*"
php flarum cache:clear

Litalino

Gorm I'm busy now. But I still spent a little time checking my plugin and still didn't see the error you mentioned. In two weeks I will check again and if there are any errors, I will update the new version.. thank you for accompanying me.

luceos

Litalino this is why:

Gorm PS. Sorry for poor quality of gif. I check it after upload. It will be available for 1 day.

Gorm

Litalino it's maybe browser dependent (js). Did you seen my gif? I can reupload it.

Litalino

Why can't I see your gif file?

Gorm

Litalino let me know when you need it and I re-upload gif files. It's some anonimity reasons to hide it from google, etc.

Now I want just to try clean Flarum setup for determine: is it conflict between some extensions in my live install nor Country Flag extensions produce an error.

luceos seems we have some language-related barrier with Litalino 🙁