Pallet Theme New

JakeMcCarroll

I've discovered a few bugs on this already, ill list them here

JakeMcCarroll

Oh yeah, there's bugs all right, this is happening when used with Private Forum Facade

adrianm

Ok just been going through these items

Fixed Start New Discussion button in top right of screen not changing to Discuss Privately
Fixed implementation of menu items so that we don't have to add code for each extension that touches the menu

Tested following extensions as they had hard-coded items on the menu

v17development/flarum-blog - working
justoverclock/flarum-ext-keywords - this menu item works but if you enable nightmode the glossary page is broken

I turned nightmode off for the rest

clarkwinkelmann/flarum-ext-group-list - working
fof/user-directory - working
justoverclock/flarum-ext-contactme - working
anything else that adds items to the nav menu should work

I'll do a version bump and update docs in the morning, hopefully that is the biggest issues sorted

Wlork

adrianm Fixed implementation of menu items so that we don't have to add code for each extension that touches the menu

adrianm anything else that adds items to the nav menu should work

I have an extension that isn't in this nav menu.... The next update will be a good test ! And I'm glad to know you've fixed the bug for private messages.

Really, many thanks for your work ! 🙂

adrianm

@JakeMcCarroll sorry for some reason I missed your messages! I'll have a look at that one but my initial thoughts are that could quite easily be listed as a "bug" on either this theme or the private forum facade extension. The issue looks to be that Pallet Theme is showing a static menu on all pages and not being removed on forum facade extension on the page in the screenshot. I'll see if I can work out a good way to make them play nice together though.

tolgaaaltas

@adrianm Thank you for your efforts. It's promising. ❤️

Wlork

@adrianm

I've installed the update.

The button for private messages has been corrected. Thanks a lot!

Unfortunately, I've encountered another annoying bug. When we go to a tag, the tree structure appears in the side nav when it shouldn't.

Wlork

@adrianm Sorry for double post.

Another bug : I can't modify CSS. I have this error message :

variable @show-side-nav is undefined in file ..../vendor/madeyedeer/flarum-pallet-theme/less/common/App.less in App.less on line 1, column 17 1| .set-left-column(@show-side-nav); 2| .set-left-column(true) { 3| @left-column: 280px; 4| } 5| .set-left-column(false) { 6| @left-column: 0;

adrianm

@Wlork
Yeah the error when trying to save CSS one is giving me a huge headache tbh.
As a work around you can add this to your custom css for now and it will at least work.

@show-side-nav: true;

Took me ages to work out how to get CSS variables through from PHP nicely and now just trying to work out how to put in a default and allow override from something coming via PHP.

The tags in the menu is an easy one, I will add this to the next update but you can fix it in css like this if you want to see how it looks

.App-sidebar .App-sidebar-items .App-sidebar-items-container li:has(a.TagLinkButton.child) {
    display: none;
}

Wlork

adrianm @show-side-nav: true;

It works. It'll do until you update it 🙂

adrianm

.App-sidebar .App-sidebar-items .App-sidebar-items-container li:has(a.TagLinkButton.child) {
     display: none;
 }

This solution hides the sub-labels. But the main tag and separation are still there....

adrianm

Wlork

It looks weird hey - I wasn't sure what that was even meant to be, haha

Wlork

adrianm

This bug has appeared since the new version 0.2.2.

You have enabled anything else that adds items to the nav menu.... Maybe that's where the issue lies 🙂

adrianm

Wlork

Yes instead of just overriding the menu it puts the Flarum menu up, so that any extensions that need to add to it can do that. It's just not manageable to put code from other extensions onto the menu every time we want to make it compatible with something else.

Wlork

adrianm

And you're right ! 🙂

Wlork

@adrianm

To test and help you (I hope !) find the issue, I've installed FoF Polls and Post Bookmarks. Links are added to the side nav, but remain on the right with tags. There's a duplicate.

I think the separation isn't done. Hence the problem with the tags on side nav I encountered yesterday.

adrianm

Wlork

ah ok - I can't really tell what's going on there - are these links from other extensions that have been put into the right-side menu by the theme but are also showing on the left now that I made it show the Flarum menu there?

Wlork

adrianm

Exactly 🙂

Originally, extension links are displayed on the right.

And since you've modified them, these links are displayed on side nav (which is fine) but also remain on the right.....

adrianm

Wlork

This one's a bit confusing so might be best to nail down what the expectation is before trying to fix it 🙂

From what I could see, different extensions were manually being added to the left-hand menu like Glossary, Blog, etc, etc in the code. I just made a change to show them automatically. They were already in the right side menu also -- ahh actually I can see where there is some css to hide them individually. So this would break any time another extension would add a menu link unless we specifically add code to the theme to show it on the left menu and hide it on the right....

How about if we hide anything that is not a tag on the right-side as I think that was intended for tags only?

adrianm

Apologies for the double-post - on a side note I need to work out how I can do a release that people can test without stuffing up the main "production" version!

luceos

adrianm we usually tag dev builds for that, eg 2.0-dev, you can even number them 2.0-dev.1 or date them 2.0-dev.20240524. These can't simply be installed though, you would have to explicitly install them using composer require madeyedeer/flarum-pallet-theme:"@dev" I think.

adrianm

luceos

awesome thanks - I'm used to working with other devs where we just check out a branch we need to work on rather than having to push stuff to main/master that might not be working properly!