guest id column not found

Justoverclock

Ive noticed that in my extension, if as a guest i navigate discussions, i get

PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'mymodel.guest_id' in 'where clause' in E:\XAMPP\htdocs\flarum\vendor\doctrine\dbal\lib\Doctrine\DBAL\Driver\PDOConnection.php:82
Stack trace:
#0 E:\XAMPP\htdocs\flarum\vendor\doctrine\dbal\lib\Doctrine\DBAL\Driver\PDOConnection.php(82): PDO->prepare('select count(*)...', Array)
#1 E:\XAMPP\htdocs\flarum\vendor\illuminate\database\Connection.php(368):

Justoverclock

seems that the problem is here...but why?

class AddStoryAttributes
{
    public function __invoke(UserSerializer $serializer, User $user, array $attributes): array
    {
        $actor = $serializer->getActor();

        $attributes['canCreateStory'] = $actor->can('createStory', $user);
        $attributes['storyCount'] = $actor->stories()->count();
        $attributes['canViewGlobalStories'] = $actor->can('viewStory', $user);
        $attributes['canDeleteStory'] = $actor->can('deleteStory', $user);
        $attributes['canEditStory'] = $actor->can('editStory', $user);

        return $attributes;
    }
}

EDIT: i've found a solutions with a condition

 if ($actor->isGuest()) {
            $attributes['storyCount'] = 0; 
        } else {
            $attributes['storyCount'] = $actor->stories()->count();
        }

clarkwinkelmann

Justoverclock I'm surprised I have not encountered this same problem before, but I think it's quite logical.

What we don't see is your code for the stories relationship on MyModel. I assume it's either not providing the column name, or maybe it's some sort of morph? The Laravel Eloquent "magic" would kick in and guess the column name, based on the relationship model name. Because Flarum replaces the User model with Guest model, the magic name for the relation would also get changed from user_id to guest_id and break the syntax.

Normally if you define an Eloquent relation using all parameters and not leaving any to the Eloquent magic, it should "work", in the sense that NULL or 0 will be used as the user_id when fetching the guest relationship, which should result in zero results.

Justoverclock

clarkwinkelmann yes is exactly what I supposed.

$attributes['storyCount'] = $actor->stories()->count();

in fact, here if the user is a guest, we can't access the stories, so it breaks.