Flarum Sitemap Generator

MikeJones

Also, I think there are errors when you change the name of a post? I need to investigate a little more.

clarkwinkelmann

@AllysonSouzaNopSai are you still active ? I've sent a PR addressing most of the issues reported https://github.com/terabin/flarum-ext-sitemap/pull/6

If you're not maintaining the package anymore I might consider forking it so we can get those fixes released. Would love to hear from you first though.

Out of curiosity, does anybody has the tags and pages in their sitemap with the current version of the extension ? It didn't work for me and I fixed it in the PR as well, I have no idea how it could have worked with the previous code...

Quick tip: to anybody having errors but nothing in your flarum.log, check that php can write to the Flarum folder.

Frink

clarkwinkelmann Looks like this is where it pulls the tags... https://github.com/terabin/flarum-ext-sitemap/blob/2d4df9ee69aebe7b0dab83b4e7dfd9ee369691a7/src/Listener/GenerateSitemap.php#L65

Don't know if that code functioned or not ?

clarkwinkelmann

Frink The code I've fixed is class_exists('Tags'). Flarum\Tags\Tag is imported above, but it doesn't appear class_exists with just a class name as string will correctly resolve the namespace (it would check for the class at the root or in the current namespace I guess). In my PR I use Tag::class to pass the full class name including namespace to class_exists, which does seem to be the way to do it (alternatively class_exists could be called with the full class name and namespace as a string, either solution would have the same effect)

Frink

clarkwinkelmann @AllysonSouzaNopSai was last online January 29'th, I'd safely assume that he/she is no longer active

AllysonSouzaNopSai

clarkwinkelmann
Updated with your fixes, sorry for the long time. ?

I noticed that you have made an improved version, so I close support for this extension.

jesusmoreno24

For all people want this, I recommend this:

https://discuss.flarum.org/d/3594-sitemap-file

Works better

MikeJones

jesusmoreno24 Why does it work better please explain.

Zeokat

I also coded a PHP script to generate a proper sitemap, becasue this extension has many bugs.

Will be nice if @clarkwinkelmann can fork and improve this extension. I can contribute with new improvements and ideas that should be added to the extension, but sadly i don't know how to code flarum extensions.

jordanjay29

Zeokat You could share your script in the Dev tag and ask for help getting it into extension form.

MikeJones

I just got an error with mine, any suggestions:

MikeJones

So I just deleted my sitemap to try some more troubleshooting, and now when I create a new post it's not re-creating the sitemap.xml at https://www.seekadventure.net/sitemap.xml

Any other troubleshooting steps I should try? Or another extension I can switch too?

Zeokat

MikeJones Maybe you can try my script to generate the sitemap. It works good, but needs that you setup a cronjob and also that you setup $flarum_path var into the script.

You can check this here: https://discuss.flarum.org/d/13101-help-to-convert-this-script-into-a-flarum-extension

« Previous Page