Issue with getSubjectModel in Notification

SychO

huseyinfiliz displayed in the forum interface

huseyinfiliz not being processed or displayed in the notification panel

i can't really tell which is which of these interfaces.

By default there is the notification dropdown, and there is the notification preference settings. Which are you referring to?

huseyinfiliz

SychO I will try to be more clear.

BEFORE OPENING the notification dropdown, a number appears/increases on the notification icon, indicating that a notification has arrived.

However, when I click on the notification icon and OPEN the notification dropdown, the notifications do not appear.

I'm sorry for using capital letters; I just have poor English.

SychO

Does the recipient user have an old read notification of the same kind ? (type, subject id)

huseyinfiliz

SychO Yes, but no notifications of the same type, namely customNotification, are visible—neither old nor new.

If I set the type to something like posts here, even old notifications become visible.

"subject": {
    "data": {
        "type": "notification_types",
        "id": "2"
    }
}

SychO

Can you check if your notifications are returned by the backend response? (you might already have checked based on your replies, but just to make sure I understand correctly)

Knowing if this is an issue on the backend side or frontend side would help pinpoint the source

huseyinfiliz

SychO Notifications are coming from the API, which means they must be processed on the backend.

I believe this issue is on the frontend, specifically in the js/forum side. After my trial-and-error attempts and reviewing the code structure in extensions like flarum/likes, I’ve come up with two possible explanations.

1. Extending NotificationGrid

Using NotificationGrid, I suspect I need to extend the notification type in a similar way to this:

extend('flarum/forum/components/NotificationGrid', 'notificationTypes', function (items) {
    items.add('postLiked', {
        name: 'postLiked',
        icon: 'far fa-thumbs-up',
        label: app.translator.trans('flarum-likes.forum.settings.notify_post_liked_label'),
    });
});

No matter how many variations I try, I haven’t been able to get this working.

2. Subject ID and Data Mapping

Even though all notification types include subjectId in their models, they always associate it with posts, discussions, or users via a column in their own database.

I can't do that. I am only matching it with the id column in my own database.

I suspect this could be the issue.

Why must I match the notification type's ID?

Because I need to send bulk notifications to all members.

If I associate subjectId with users, then if the notification type ID does not match a user/post/discussion ID, the notifications will be hidden on the frontend. That’s why I can't do this.

I must retrieve subjectId only using the id from my notification_types table. Additionally, I cannot associate this ID with users, posts, or discussions.

I've explored every solution I could think of and examined all modern Flarum/fof extensions using the notification system. In the end, they all rely on association.

flarum/suspend seems the most different, yet it still associates with users.

SychO

huseyinfiliz nvm, i see it here (sorry, multi tasking).

What's the code for the notification type component on the js side? i'm especially looking for the part that registers the notification type component (you might have either used a JS extender or just code in index.js)

huseyinfiliz

SychO Actually, if you have an email where I can send all the extension files, I can share them with you. I haven't published it on GitHub yet. There are many people waiting for this extension, and I'm sure everyone will be happy if you review the code.

huseyinfiliz

SychO

index.ts

import { extend } from 'flarum/common/extend';
import app from 'flarum/forum/app';
import addNotificationLinks from './addNotificationLinks';
import CustomNotification from './components/customNotification';

export {default as extend} from './extend';

app.initializers.add('huseyinfiliz-notificationhub', () => {
    addNotificationLinks();
	app.notificationComponents.customNotification = CustomNotification;
});

customNotification.tsx

import app from 'flarum/forum/app';
import Notification from 'flarum/forum/components/Notification';

export default class CustomNotification extends Notification {
  icon() {
    return this.attrs.notification?.content()?.icon;
  }

  href() {
    return this.attrs.notification?.content()?.url;
  }

  excerpt() {
    return this.attrs.notification?.content()?.excerpt;
  }

  content() {
    const message = this.attrs.notification?.content()?.message;


    return m('div', message);
  }
}

SychO

Make a frontend model for NotificationHub, I suspect the logic might be skipping your notifications because the frontend cannot associate the subject to any frontend model. Even if that's not the reason, let's rule it out.

for reference: https://docs.flarum.org/extend/models#adding-new-models-1

huseyinfiliz

SychO Something like this? For example:

models/Notification.ts

import Model from 'flarum/common/Model';

export default class Notification extends Model {
    notification = Model.attribute<string>('notification');
}

SychO

huseyinfiliz keep the naming consistent. Name it the same as the backend model.

My preference would be NotificationType both on the back and frontend, with a database table notification_types and a API serializer type of notification-types. But that's just a nitpick.

SychO

For example, in your serializer set the type to notification-hubs

Make a frontend model NotificationHub and register it in the store using the type notification-hubs

huseyinfiliz

SychO I struggled for about 4 hours, but I finally gave up—for now. I'm truly grateful for your support. I've just released the v0.1 version. This is a test version, and I'm sure many bugs will surface. I've decided to take a 2-day break before tackling the model matching issue again 😄

huseyinfiliz/notificationhub

SychO

huseyinfiliz just tested really quick, and it is indeed the lack of frontend model that's causing the problem.

here: huseyinfiliz/notificationhub1

huseyinfiliz

SychO Thank you so much, I'm testing it right away. I think I might have missed a simple and small detail...

Side Note: Instead of using a code editor like Visual Studio, I use a plain text editor. This sometimes causes me to overlook certain things. It's not directly related to this issue, but I just wanted to mention it.

« Previous Page