FriendsOfFlarum upload, the intelligent file attachment extension

luceos

ooogooo can you clear your cache? If that doesn't help try this command:

ls vendor/fof/upload/src/Extenders/AddPostDownloadTags

Post output here.

gython

Hi,
I can't seem to get upload adaptors to work properly anymore since I updated to beta 15. I have the following mimetypes registered:

But I'm only getting an error message that the type is not allowed when I'm trying to upload a pdf, specifically Error 422 (Uploading files of this type is not allowed).

Uploading images (I just tried jpg) works, but I seem to only get the image preview handler. When I change the upload handler to the file download or URL template, it has no effect.

Also, when I'm adding a handler which should match everything (.*), I'm also getting the same error message.

Are my mimetypes wrong? Is there anything else I'm not seeing? Is this a known bug?

The logs in storage/logs don't show any hints to what's happening. I ran the migrations after upgrading and cleared the cache several times.

Any help would be appreciated. Thanks.

Some details about my installation (flarum info):

gython

I did some digging through the code and it seems I'm falling back to the default setting in src/Helpers/Util.php:80. My configured settings are present in the db, and are being updated when I change them in the admin panel. What is going wrong here?

luceos

gython what keys do you have in the database that relate to this?

gython

Hi @luceos. Thanks for your reply!
I see the mime types I specify in the admin panel in the settings table, entry: fof-upload.mimeTypes.
I tried deleting all fof-upload related settings, re-enabling the plugin and updating the settings again. The settings are being re-created in the DB, but no luck, I still get the same error.

IanM

0.12.2

Fix mimetype config retrieval FriendsOfFlarum/upload258 Nimren gython
Don't attempt to preview an uploaded image when preview is not available (ie on new discussion) FriendsOfFlarum/upload255
Fix console error when cancelling the upload dialog FriendsOfFlarum/upload256
Remove invisible input hack for the toolbar button FriendsOfFlarum/upload257

Updating

composer require fof/upload:"*"
php flarum cache:clear

gython

When I manually hardcode my wanted mimeType in the code, uploading works. I added the following in line 82:

'^application\/pdf' => ['adapter' => $adapters->flip()->last(), 'template' => 'file']

This solves my problem for now, but is ugly and might just be a bug. I'm no php dev, but if I can do anything to help debugging further, please let me know.

gython

Another update: The maximum filesize setting is respected correctly.

Nimren

I also have a problem with mimeType. Does not recognize any setting. I tried to delete all settings in the database and reinstalled but it still doesn't work. Only images can be loaded by default, but the Imgur adapter does not work.
Fof/Upload 0.12.1

Nimren

Nimren The Imgur adapter works only if I force it in the extend.php file :/
Other mimetype does not recognize.

MikeJones

I think this plug in should be able to recognize when it fails due to the file being to large and notify the user with a correct warning.

Right now it just gives the generic Flarum error that something went wrong.

clarkwinkelmann

MikeJones there are two possible errors for a file too large:

The first is your webserver blocking the request if the file is bigger than PHP configured max upload.

The second is fof/upload checking the size of the file and returning a translated message. But this only happens if the first test by PHP passes, otherwise Flarum never actually loads.

If the webserver returned a special status code for failed file uploads, we could show a special message client-side in the extension. But I think most servers will return a generic 500 page so we have no way of knowing what went wrong and just display the default Flarum error message.

Technically, you should be able to configure PHP in a way that it returns a JSON payload in JSON:API syntax to describe the error. But I've never tried to do that. I'm not whether it's possible to define an error page specifically for files too large.

I suppose we should also be able to do a client-side file size check before actually triggering the file upload. If someone knows how to do that, a PR is welcome 🙂

MikeJones

clarkwinkelmann Is there a way for flare to detect the file size first? Then there could be a setting in the upload extension settings and we could have it be the first check and throw an error first? Or no?

clarkwinkelmann

MikeJones the simplest solution if your host supports it:

Set PHP max upload size to a generous limit, like 100MB or above, which will cover most files a user might select
Set the max upload limit in the fof/upload settings to what you actually want in Flarum, for example 20MB

MikeJones

clarkwinkelmann If I do that, does the upload extension then send a notice saying file to large?

clarkwinkelmann

MikeJones yes, if the file is below PHP limit but above extension setting, there's a dedicated error message.

MikeJones

clarkwinkelmann nice that was all I am looking for :-)

Derriell

I know this is ahead of time but it would be great if sooner or later Flarum and especially this extension would support the new AVIF file format based on AV1. Ideally with the option to convert and compress all new uploaded images to AVIF. Compared to JPEG, AVIF can safe up to 50% file size and it supports tiling images, which enables multiple cores to render one image in parallel. This would enable Flarum to be faster with images.

Google Chrome supports AVIF since version 85 (August 2020) and Firefox will support it by default from version 86 on.

Links:
https://en.wikipedia.org/wiki/AV1#AV1_Image_File_Format_(AVIF)
https://aomedia.org/av1-features/

clarkwinkelmann

Derriell regarding "support", this extension should support any file type. You just need to write the correct mime type if you want to limit which file types are allowed. Any maybe you might need to update some libraries if the mime type can only be detected using particular libraries.

As for conversion/compression, the only option we currently include in the extension is based on width/height, and I think it preserves the original format (not sure though).

If the library we use for resize (Intervention) supports that file format, a PR is welcome to whitelist those files for resizing in the extension.

Derriell

clarkwinkelmann Thank you, it worked to extend the mime type, I just tried it. The resizing of AVIF images doesn't work for now, as expected.

EDIT: The AVIF file is stored as .bin file but Chrome is able to show them correctly. However if I want to open just the image in a new tab Chrome downloads it as a .bin file.

On weird behavior I encountered: When editing the mime type and clicking on the text to edit, the position of the text exchanged with the text one line below. A line swap. I only have two lines. Using beta 15

« Previous Page Next Page »