FriendsOfFlarum upload, the intelligent file attachment extension

D-W

luceos thanks however this will allow other octet-stream files to be uploaded am I right? The same with the second one if I will allow text/xml it will also allow *.xml extension plus other XML(ish) formats which isn't expected imho.

luceos

D-W fact 😉 But integrating a check based on file extension would not be any safeguard against other octet-stream files faking their extension. So.. there's that.

D-W

luceos Yes but will prevent unwanted content to some degree. Of course, if someone will try to fake it you won't stop him, however, normal users may try to upload some files without faking it, and if it won't be allowed they just won't. While currently, you don't have even the option to try to prevent such actions.

Actually, the problem lies in MIME itself as image/jpg is narrow and explicit while application/octet-stream can basically everything.

D-W

luceos made a quick run through code but can't find where I could put extension check.
Would you mind pointing me where I could just drop two lines to fit my custom needs?

Ah. Seems I found it here? I should know if it is desired mime if is then check ext and if do not fit throw mime exception. Am I right?

It's interesting that the original upload object detects mime as expected (ofc in my narrow view):

samtto

Pictures larger than 1m cannot be uploaded
Said：The request payload was too large.
and nothing recorded in logs.
Maximum file size (in kilobytes):80000

anyone could tell why ?tks.

clarkwinkelmann

samtto check your PHP/Apache max upload size.

If the file is too large for the webserver, Flarum will never execute and won't be able to log anything. There might be details in the webserver or system log files but requests too large are usually only logged in webserver access logs if enabled.

samtto

clarkwinkelmann TKS,OK NOW.

nginx after "server name"add:
client_max_body_size 10M;

luceos

D-W that's the spot. Not sure how to get the user extension though. I remember symfony having a guess mimetype vs actual file type based on extension, you'd have to dig in I fear. Or just check based on upload name.

D-W

luceos Did it with $upload->getClientOriginalExtension() works as expected now. I still vote for one more string input in plugin settings to include expected extensions optionally as this may really be useful.

As we said due to the broad definition of application/octet-stream potential problems can be avoided this way like people uploading harmful exe (another user of the forum may run it just out of curiosity and boom) or other files when you want just a couple of extensions. I hope you get my point of view.

samtto

When I select multiple files on my mobile phone, only one file is uploaded successfully
am i miss anything ?

clarkwinkelmann

samtto does an error appear for the other files, or are they just ignored?

Did you try multiple devices? Can you report which browser/OS you were using?

samtto

clarkwinkelmann clarkwinkelmann There are no errors reported on the mobile phone, nor on the computer.
nothing records in /storage/logs.

samtto

clarkwinkelmann You can upload in batches on edge computers, but not on mobile phones.try it ou sir.

luceos

samtto maybe the api changed. What browser on mobile does this error occur with?

samtto

luceos edge

rafaelzgz

How to setup the imgur API? Only need to create an APP and put the public client ID on extension configuration?

clarkwinkelmann

rafaelzgz correct, and then next to the MIME types there is a dropdown to choose where the files with that MIME type go. The dropdown shows "Local" by default but "Imgur" will appear in the dropdown after configuring the client ID.

adam42

I just realised "My Media" only hides the files I upload. Is there an extension that allows me to delete files entirely? Thanks 😃

adam42

adam42 Is there an extension that allows me to delete files entirely?

I think my question got hidden behind the new discussion.

hrvoje459

Hi,
is it possible to setup flarum and this extension so it works both in regular mode and over tor network,
when I access flarum over tor, images are still embeded(I'm not sure about terminology?) like this:

clarkwinkelmann

hrvoje459 which template are you using?

When using "just URL" or bbcode IMG, the full URL will be inserted in the post body and won't be able to change if the URL in config.php is modified.

The default image or download templates might be able to adapt if the public URL is modified in config.php or through custom logic, which is probably what you have to support more than 1 public URL.

hrvoje459

clarkwinkelmann

there is some terminology that i am not familiar with in the context of flarum

i don't know what a template is, if you are reffering to how I installed flarum, i just followed official instructions and added few extensions using composer

there is no need for migrating old images to new urls

url in config.php is configure as: 'url' => '//' . $SERVER['HTTP_HOST']

additional note: not being able to see images works both ways, in normal browser i can't see images post over the tor one

« Previous Page Next Page »