FriendsOfFlarum upload, the intelligent file attachment extension

CyberGene

luceos this is absolutely awesome! I will probably not install it right now but since it's very promising, I think I may create a copy of our forum and test it there. If you open a donation link or something, you will have a few beers from me for that 🍻

luceos

CyberGene I think I may create a copy of our forum and test it there

I recommend that for now.

CyberGene If you open a donation link or something, you will have a few beers from me for that 🍻

😍 I have a GitHub sponsors page https://github.com/sponsors/luceos, but you can also donate to Flarum instead: https://flarum.org/donate.

CyberGene

luceos You just got a one-off sponsoring amount, cheers! 🍻

luceos

CyberGene I am humbled by your generosity 🤗

CyberGene

Can I run a command that will just list the unused files without deleting them? Or run in simulation mode without actually deleting the files? Because I can create a forum copy with a DB copy but it would still point to the S3 bucket we use with our production forum and I don’t want for the procedure to delete the actual files in case it doesn’t work as expected.

luceos

CyberGene can you copy the bucket? If not I can probably add a flag to list instead of delete.

CyberGene

luceos It may be possible to create a duplicate bucket but I'm not sure if the stored file URL-s will stay the same. Actually, is that new functionality you implemented working with AWS S3, I mean can it delete files there? And if so, how does it delete them? If it doesn't use the absolute URL of the file but rather bucket name and then file name (or something like that) then it might be possible.

luceos

CyberGene see the post luceos ; I have added a flag --force, without that flag you will be shown a confirmation of the url, adapter and path of the file. It won't delete files unless confirmed.

CyberGene

luceos I’ll test that soon, thank you!

CyberGene

How do I install the dev version? I am trying with
composer require fof/upload:1.3.0-dev.2 but it doesn't work.

luceos

CyberGene but it doesn't work.

Either:

make sure your composer.json contains "minimum-stability": "dev" and "prefer-stable": true then you should be able to add it, or
add the entry manually in your composer.json under require "fof/upload": "1.3.0@dev" I think

If you encounter an error, please share the error.

CyberGene

luceos Thanks, I tried the first one, however I couldn't install by version/tag but had success with the branch name:
composer require fof/upload:dev-dk/map-files-posts

I'll test now.

CyberGene

A simple sanity check tells me it's probably working, it lists files, I checked some of them, seems they are indeed unused. Good job so far! 👍🏻

But it fails for the AWS S3 ones, I guess you have to implement that support, so I'll be looking forward to it since we switched from local storage to AWS S3 sometime ago and I will need to clean-up there too 😀

Thanks for your effort and cheers! 🍻

luceos

CyberGene what exactly didn't work? Do you have an error?

Seems a test with s3 is required 😉

CyberGene

It stopped with this error:
In Manager.php line 85: No adapter configured for aws_s3

Darkle

CyberGene I had this error in my first local test, to fix it I had to purge the extension, it must be something in the database and I couldn't find any other way, I think the problem arises if you already had an S3 adapter configured. Don't purge if you are in production.

I hope to be able to continue with the tests of this PR, that for now I have them stopped, with all this I tried to take the opportunity to check some things of the bucket and the CDN, and well, big mistake... 😅

CyberGene

Darkle I’m working on a copy of my forum, not risking 😉 I’ll purge and reinstall the extension then.

luceos

CyberGene in your local database try replacing upload_method in the fof_upload_files table from aws_s3 to aws-s3. And see if it continues with that. So:

update fof_upload_files set upload_method = "aws-s3" where upload_method = "aws_s3";

Purging won't be a solution as we want to retain the files data in the database. Without it all references to uploaded files in posts will be lost.

Subarist

A small ui exception.
Imgur
The upload button of the folder window cannot display the tooltip completely.
Not a big deal, but I just keep noticing it.
Very simple button, maybe consider canceling this tooltip.

ichpen

MohdKhan and @luceos

Hey guys, very very very new and green to flarum.

Wanted to point out that this is still an issue making any non Amazon S3 compatible service i.e. R2, wasabi, B2 unusable for image storage as images cannot be rendered due to the URL hardcoding.

Is there a solution to this? I guess if not should be a warning that the extension doesn't really support S3 compatible storage for reads?

Maybe I missed an update. 🙂

« Previous Page Next Page »