FriendsOfFlarum upload, the intelligent file attachment extension

Wulfheart

It would be really cool if this package would be capable to add an image via copy paste just like GitHub allows.

IanM

Wulfheart last time I checked, it does 🤔 I'll look again next time I have the chance.

Edit: Just checked, and yes, an image on the clipboard will paste into the composer and upload/embed

CyberGene

I think the cleanup logic is faulty. I just executed it for the first time with --force and I didn't care to check if the files are indeed used (I don't know how to do that anyway, it just lists a URL but I can't possibly know/remember if such a file might be used anywhere on the forum or not...). I opened one of the important old discussion of the forum with many uploads inside and those uploads that were local and use the Download template are not working anymore and I don't keep the files anymore 😕 This is really bad... I can try restoring them from a backup of the forum though but I'm wondering on what other places it may have deleted files, e.g. Amazon where I don't have backups... Really having bad cold chills now, hopefully I haven't screwed my forum uploads for the last three years.

P.S. Warning!

I can confirm the cleanup logic is faulty. When a file was uploaded using the "Default File Download Template" in FoF Upload, the cleanup logic cannot map those files and would assume they are not used, while they are in fact used in posts, and would subsequently delete them from the corresponding storage, in my case local and AWS S3. "Fortunately" I deleted only files between January and December 2022 on my forum, but that's still a lot of files and I broke some of the most important discussions with audio files on my forum and it's a music related forum where people upload their own recordings, etc. To say it's disaster would be an understatement, since I don't have backups and we lost important content forever. I'll try to not be dramatic and just accept that sh1t happens from time to time and it was my turn today, not the end of world after all 😕 I probably lost some trust in my users since I have never screwed up that much and they trusted me that the forum is reliable for uploading files. But I would strongly advise people to be EXTREMELY careful before using the cleanup logic. Always make a backup not only of your forum, but also of all the files on external services such as AWS S3 because the cleanup can delete them too.

P.P.S. Is there any log of the cleanup command that I can find somewhere to at least list all the deleted files, so that I can warn people about the deletions?

IanM

CyberGene

I'm very sorry that you have been impacted by this, especially in the way that it has affected your community.

CyberGene Is there any log of the cleanup command that I can find somewhere to at least list all the deleted files, so that I can warn people about the deletions?

Sadly, no logging is done by the command, other than the output provided on the CLI.

CyberGene I can confirm the cleanup logic is faulty.

Yes, having just tested this, I can also confirm that a major issue exists within this code.

Moving forward from here

I am currently working on a feature update for this extension, which is nearing completion at the moment. As part of this, I will disable the CLI commands temporarily, so that no-one else is impacted by it.

Once this is done, I/we will carefully review the code, add automated testing and correct the logic so that it performs as expected. Only then, I will re-release the feature when I am happy that there is no risk of data loss.

As a side note, recently all FoF extensions have had PHPStan (a static code analysis tool) enabled, and many extensions have started to have automated tests added, in a drive to continuously improve our codebase and provide well maintained extensions for the Flarum ecosystem.

Please keep an eye out on this discussion and FriendsOfFlarum/upload374 for further news on the progress of this most important fix.

meihuak

I hope that when visitors click on this image, they will be able to pop up a large preview. Now people need to open the image in a new browser to see it in high definition.

Litalino

I choose: "Imgur image storage settings" and add key

But the file upload is on localhost, not uploaded to "imgur.com"..

Did I not install it correctly? Please give me the answer.. sincerely thank you

PIC:

luceos

Litalino you need to select imgur in the dropdown behind the mimetype configurations.

Litalino

luceos

I saw it.. thank you very much

CyberGene

IanM luckily it affected only 20-30 files on my forum because it turned out the File Download Template was used on a limited set of files and through SQL filtering we could identify them and we already re-uploaded some, so it's a huge relief for me that the impact has been mostly minimal 😮‍💨 Also, luckily I used the time limitation function, so the affected files were only those before December 2022.

But lesson learned. I have somehow totally ignored that I have no back-up activated on the AWS S3.

Hopefully this functionality will be further improved in future 👍🏻

GreXXL

Petersoj please see the post IanM
This feature does not work properly and should not be used for the moment.

clarkwinkelmann

hrvoje_hr I believe there's a command that can be run to create the mapping, but it wad disabled in the recent updates IanM

When this is eventually fixed, since there's a command to update the mapping, I don't think you need to worry about it during your import. You will be able to simply run the command after the data has already been imported into Flarum.

Boss81

Hello!

I have successfully installed Fof Upload. I would like the files to be uploaded to my own server. There is no problem with this, but when I select the file, the full path can be seen in the preview.
Is there anything that can be done to prevent it from being seen?

Petersoj

Bug report: when using S3 and running php flarum fof:upload --map --cleanup --cleanup-before="now" --force I get the following error:

When I check the fof_upload_files table, the upload_method column for all uploaded files appears to be awss3 and not what it should be: aws-s3. This causes an error in Manager.php because of this line. Running update fof_upload_files set upload_method = "aws-s3" where upload_method = "awss3"; seems to fix this issue, but I'm not sure why the S3 adapter is using awss3 instead of aws-s3. Would open a PR, but it's probably a super quick fix for maintainer.

Edit: I should also note that my extend.php looks like this:

use Flarum\Extend;

return [
    (new FoF\Upload\Extend\Adapters())->force('aws-s3')
];

CyberGene

Petersoj I’ve reported this a few times in the past, however it seems the exact cause might still not be clear. Maybe the devs can fix it when they have more time since it seems the cleanup functionality is rather in beta at the moment.

Petersoj

GreXXL ah I see. Makes sense. I won't use the cleanup function for now. Luckily, my forum has no existing posts as I'm starting a fresh one so I wasn't at risk for any data loss. IMO, maintainer should remove command from original post docs because not everybody will see his follow-up post regarding potential data loss with the cleanup command!

IanM

1.5.0

Fixes

fix: fallback mime detection by @pierres in FriendsOfFlarum/upload362
fix: missing translations by @IanM in FriendsOfFlarum/upload368
chore: disable cli cleanup command by @IanM in FriendsOfFlarum/upload375
fix: upload watermark image does not display in settings FriendsOfFlarum/upload376 by @IanM in FriendsOfFlarum/upload384

A new settings key is used for the watermark image, so if you are already using a watermark, please upload the image again

Screenshots

Features

feat: admin shared uploads by @IanM in FriendsOfFlarum/upload372

Screenshots:

admin interface

upload modal (with settings, access options, etc)

user media library

Updating

composer require fof/upload:"*"
php flarum migrate
php flarum cache:clear

💝

Thank you to @GreXXL for testing this new feature!

Litalino

IanM Update 1.5.0 :: An error occurred while trying to load this page.

Downloading fof/byobu (1.3.5)

Downloading fof/upload (1.5.0)

Downloading ziiven/flarum-post-number (v0.1.4)

Upgrading fof/byobu (1.3.4 => 1.3.5): Extracting archive

Upgrading fof/upload (1.4.7 => 1.5.0): Extracting archive

Upgrading ziiven/flarum-post-number (v0.1.3 => v0.1.4): Extracting archive

Check page home

flarum.ERROR: InvalidArgumentException: Failed importing jeromegillard-map due to View [jeromegillard-map] not found. in /public_html/vendor/fof/upload/src/Extenders/AddPostDownloadTags.php:52

Disable composer require jeromegillard/map:"*" v0.1.7<< OK: >> NOT ERROR PAGE: An error occurred while trying to load this page.

rafaucau

IanM After update, when I paste image from clipboard it is uploaded but not inserted into the post content.

Edit: fixed it in FriendsOfFlarum/upload387

GreXXL

Litalino you will need to report the error here: https://discuss.flarum.org/d/31732-map-extension-display-a-map-a-gpx-or-a-geojson-file-in-a-post. You can also try running php flarum migrate and php flarum cache:clear after installation.

Litalino

GreXXL I ran those 2 lines after updating but still got the error

I have checked files:

JeromeGillard/flarum-mapblob/main/src/Templates/MapTemplate.php

FIX public_html/vendor/jeromegillard/map/src/Templates/MapTemplate.php

https://discuss.flarum.org/d/31732-map-extension-display-a-map-a-gpx-or-a-geojson-file-in-a-post/15

mrnaterpg

After installing Upload on a fresh install of Flarum (beta), the entire flarum instance fails. Here is logs:
[2023-12-17 20:36:37] flarum.ERROR: Error: Class "FoF\Upload\Extend\SvgSanitizer" not found in /var/www/html/REDACTED/vendor/fof/upload/extend.php:112 Stack trace: #0 /var/www/html/REDACTED/vendor/flarum/core/src/Extension/Extension.php(373): require() #1 /var/www/html/REDACTED/vendor/flarum/core/src/Extension/Extension.php(139): Flarum\Extension\Extension->getExtenders() #2 /var/www/html/REDACTED/vendor/flarum/core/src/Extension/ExtensionManager.php(390): Flarum\Extension\Extension->extend() #3 /var/www/html/REDACTED/vendor/flarum/core/src/Extension/ExtensionServiceProvider.php(31): Flarum\Extension\ExtensionManager->extend() #4 [internal function]: Flarum\Extension\ExtensionServiceProvider->Flarum\Extension\{closure}() #5 /var/www/html/REDACTED/vendor/flarum/core/src/Foundation/Application.php(329): call_user_func() #6 /var/www/html/REDACTED/vendor/flarum/core/src/Foundation/Application.php(270): Flarum\Foundation\Application->fireAppCallbacks() #7 /var/www/html/REDACTED/vendor/flarum/core/src/Foundation/InstalledSite.php(151): Flarum\Foundation\Application->boot() #8 /var/www/html/REDACTED/vendor/flarum/core/src/Foundation/InstalledSite.php(82): Flarum\Foundation\InstalledSite->bootLaravel() #9 /var/www/html/REDACTED/vendor/flarum/core/src/Http/Server.php(59): Flarum\Foundation\InstalledSite->bootApp() #10 /var/www/html/REDACTED/vendor/flarum/core/src/Http/Server.php(36): Flarum\Http\Server->safelyBootAndGetHandler() #11 /var/www/html/REDACTED/public/index.php(26): Flarum\Http\Server->listen() #12 {main}

katos

mrnaterpg

I can't seem to replicate that issue - Please can you provide an output of php flarum info ?

« Previous Page Next Page »