FriendsOfFlarum upload, the intelligent file attachment extension

IanM

1.5.6 What's Changed

fix: readme implies wrong composer require command by @luceos in FriendsOfFlarum/upload403
fix: filename is unreadable text when downloading a file with a non-ascii name by @MessyGhost in FriendsOfFlarum/upload410
chore: prep for flarum/gdpr by @IanM in FriendsOfFlarum/upload411

New Contributors

@MessyGhost made their first contribution in FriendsOfFlarum/upload410

Full Changelog: FriendsOfFlarum/upload1.5.5 → 1.5.6

davetodave178

1.5.7 What's Changed

Fix Condition when Text Preview should be shown by @edgeinfinity1 in FriendsOfFlarum/upload396

New Contributors

@edgeinfinity1 made their first contribution in FriendsOfFlarum/upload396

Full Changelog: FriendsOfFlarum/upload1.5.6 → 1.5.7

pkumar5330

Hello Team,

I have set in admin section for image and video upload. Upload is working fine. I want to show video play like image rendering or preview.

after upload it shows like this:
http://localhost:8081/flarumforum/public/assets/files/2024-11-04/1730731611-145654-big-buck-bunny-720p-1mb.mp4

why not it shows video to play.

I have also checked with this code, but still not playing video in forum. It shows only the link

<video width="600" controls>
<source src="http://localhost:8081/flarumforum/public/assets/files/2024-11-04/1730731983-605160-big-buck-bunny-720p-1mb.mp4" type="video/mp4">
Your browser does not support the video tag.
</video>

Capybara

Since bugs are fixed from the github, remind that this error still exists 👀

davetodave178

Capybara I had a look at it this morning, and I am working on a fix. Can't tell you right now when the fix will be released

SkakashiS

SkakashiS
Up!

It throws this error:

{"errors":[{"status":"422","code":"validation_error","detail":"Could not delete file.","source":{"pointer":"\/data\/attributes\/file"}}]}

davetodave178

1.5.8

What's Changed

fix: redraw after deleting file by @davetodave178 in FriendsOfFlarum/upload412
fix: change UI in tooltips of uploaded files by @davetodave178 in FriendsOfFlarum/upload413
chore: LESS cleanup by @davetodave178 in FriendsOfFlarum/upload414
fix: append new results when loading more to existing files by @davetodave178 in FriendsOfFlarum/upload415

Full Changelog: FriendsOfFlarum/upload1.5.7 → 1.5.8

nevermind

Thank you for fixing the gallery bug <3
Unfortunately I may have found another one: when you switch between "My Media" and "Shared Media", the images inside Shared Media are duplicated. Here is a gif to illustrate:

When you close and re-open the Media manager it correctly starts with the right amount of images.

davetodave178

nevermind Thanks for sharing. Will have a look this week

jasonwch2

May I know by any chance the upload can also show percentage progress as my forum may have some larger file need to be uploaded.
Thanks

ccrice

When I try to upload a image,It get a error.

<br />
<b>Deprecated</b>:  Optional parameter $upload declared before required parameter $contents is implicitly treated as a required parameter in <b>/www/flarum/vendor/fof/upload/src/Adapters/Flysystem.php</b> on line <b>55</b><br />
<br />
<b>Fatal error</b>:  Uncaught Laminas\HttpHandlerRunner\Exception\EmitterException: Output has been emitted previously; cannot emit response in /www/flarum/vendor/laminas/laminas-httphandlerrunner/src/Exception/EmitterException.php:20
Stack trace:
#0 /www/flarum/vendor/laminas/laminas-httphandlerrunner/src/Emitter/SapiEmitterTrait.php(42): Laminas\HttpHandlerRunner\Exception\EmitterException::forOutputSent()
#1 /www/flarum/vendor/laminas/laminas-httphandlerrunner/src/Emitter/SapiEmitter.php(21): Laminas\HttpHandlerRunner\Emitter\SapiEmitter-&gt;assertNoPreviousOutput()
#2 /www/flarum/vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(75): Laminas\HttpHandlerRunner\Emitter\SapiEmitter-&gt;emit()
#3 /www/flarum/vendor/flarum/core/src/Http/Server.php(45): Laminas\HttpHandlerRunner\RequestHandlerRunner-&gt;run()
#4 /www/flarum/public/index.php(26): Flarum\Http\Server-&gt;listen()
#5 {main}
  thrown in <b>/www/flarum/vendor/laminas/laminas-httphandlerrunner/src/Exception/EmitterException.php</b> on line <b>20</b><br />

The image will not add into the post,but when you flash the page you can find the image has already upload successful.
the php version is 8.3 I also get this error in 8.1

ccrice

ccrice
I have fix it form edit the /vendor/fof/upload/src/Adapters/Flysystem.php
Change public function upload(File $file, ?UploadedFile $upload = null, $contents) to public function upload(File $file, ?UploadedFile $upload, $contents)
It seem like a very common error in php8

clarkwinkelmann

ccrice set display_errors to Off in your php.ini configuration. Changes to Flarum source code will be lost when you install or update extensions

ccrice

clarkwinkelmann I try to set the error display to off,but it's doesn't work for me.

clarkwinkelmann

ccrice make sure you are editing the correct php.ini. If you have multiple PHP version installed there will be multiple files. You might also need to edit both the "CLI" file and the "apache"/"php-fpm" file.

If you are editing this PHP ini values via a managed hosting interface, please let us know what software is used. Someone might know where the correct setting is.

Capybara

Please move the file send button to the top or pin it. If there are a lot of images in the manager and you select a new one, you have to scroll to the bottom to click the send button. If there are a lot of images, then it takes a long time to scroll from the phone

Capybara

I also need help... Previously, when dragging an image from a computer to a forum, the forum uploaded the image as

[upl-image-preview url=https://forumspace.ru/assets/files/2024-10-31/1730393811-505236-photo-2024-10-25-03-38-04.jpg]

And now, when upload through the manager, the link has changed to the next one. How do I get the old version back? I changed the plugin settings, maybe I changed something and did not return it back. But it seems that I returned everything as it was.

[[upl-image-preview uid=16578fd4-7ddf-493 ab635-738e606888a6 url=https://forumspace.ru/assets/files/2024-10-31/1730393811-505236-photo-2024-10-25-03-38-04.jpg alt={TEXT?}]

ccrice

Capybara same question. because of this I had to disable the file manager

clarkwinkelmann

Capybara I suspect this is part of the new Upload 1.6 features that have just been released, though it had not been officially announced yet. @IanM any announcement planned?

If the image is not rendering, try clearing the Flarum cache.

davetodave178

Capybara ccrice Try clearing the cache and publishing the assets

« Previous Page