FriendsOfFlarum upload, the intelligent file attachment extension

GreXXL

Amar Quote from the first post. (You need to set it up)

FriendsOfFlarum FAQ

AWS S3: read the AWS S3 configuration page.

Amar

GreXXL Hi thanks for the reply I am ready with my bucket 🙂 The issue is My screenshot looks different. I do not see 2 tabs after enabling the extension. My falrum version is 1.8.9 I only see general preferences

m4v3rick

Just tried to update some extensions after some time with:

composer update --prefer-dist --no-plugins --no-dev -a --with-all-dependencies
php flarum migrate
flarum cache:clear

After updating all the posts are gone.
More info here: https://discuss.flarum.org/d/36918-no-more-discussions-after-composer-update

If I disable the upload extension it works again.

In the logs I found this:
: Return value must be of type FoF\Upload\Contracts\UploadAdapter, null returned in /fof/up>
#14 [internal function]: Tobscure\JsonApi\Document->Tobscure\JsonApi{closure}()

I upgraded from fof/upload 1.5.8 to 1.7.1.

Any idea what the problem could be?

clarkwinkelmann

m4v3rick can you share a screenshot or description of your Upload settings? Make sure all configured MIME types have a selected adapter. If you are using S3 adapter, make sure you still have the additional required dependencies installed.

Can you share the full error message and trace for the error? It starts on a line with the timestamp, then line #0, #1, #2 etc. It can have up to 50 lines sometimes before the next error that will again start with a timestamp. The presence of #14 makes it look like there might be more interesting information in the lines above.

m4v3rick

clarkwinkelmann

It hasn't been an issue before upgrading. But yes, here is a screenshot:

(audio\/(aiff|midi|mpeg|mp4))|(image\/(gif|jpeg|png))|(application\/(x-(7z|rar|zip)-compressed|zip|arj|x-(bzip2|gzip|lha|stuffit|tar)|pdf))

m4v3rick

clarkwinkelmann Can you share the full error message and trace for the error? It starts on a line with the timestamp, then line #0, #1, #2 etc. It can have up to 50 lines sometimes before the next error that will again start with a timestamp. The presence of #14 makes it look like there might be more interesting information in the lines above.

Sorry, I had to update again to get the error message (I did a snapshot revert after the erros occurred.):

[2025-02-02 22:49:15] flarum.ERROR: TypeError: FoF\Upload\Adapters\Manager::instantiate(): Return value must be of type FoF\Upload\Contracts\UploadAdapter, null returned in /*/vendor/fof/upload/src/Adapters/M> Stack trace: #0 /*/vendor/fof/upload/src/Repositories/FileRepository.php(420): FoF\Upload\Adapters\Manager->instantiate() #1 /*/vendor/fof/upload/src/Formatter/ImagePreview/FormatImagePreview.php(49): FoF\Upload\Repositories\FileRepository->getUrlForFile() #2 /*/vendor/s9e/text-formatter/src/Utils.php(123): FoF\Upload\Formatter\ImagePreview\FormatImagePreview->FoF\Upload\Formatter\ImagePreview\{closure}() #3 [internal function]: s9e\TextFormatter\Utils::s9e\TextFormatter\{closure}() #4 /*/vendor/s9e/text-formatter/src/Utils.php(119): preg_replace_callback() #5 /*/vendor/fof/upload/src/Formatter/ImagePreview/FormatImagePreview.php(38): s9e\TextFormatter\Utils::replaceAttributes() #6 /*/vendor/flarum/core/src/Foundation/ContainerUtil.php(30): FoF\Upload\Formatter\ImagePreview\FormatImagePreview->__invoke() #7 /*/vendor/flarum/core/src/Formatter/Formatter.php(121): Flarum\Foundation\ContainerUtil::Flarum\Foundation\{closure}() #8 /*/vendor/flarum/core/src/Post/CommentPost.php(176): Flarum\Formatter\Formatter->render() #9 /*/vendor/flarum/core/src/Api/Serializer/BasicPostSerializer.php(63): Flarum\Post\CommentPost->formatContent() #10 /*/vendor/flarum/core/src/Api/Serializer/PostSerializer.php(21): Flarum\Api\Serializer\BasicPostSerializer->getDefaultAttributes() #11 /*/vendor/flarum/core/src/Api/Serializer/AbstractSerializer.php(88): Flarum\Api\Serializer\PostSerializer->getDefaultAttributes() #12 /*/vendor/sycho/json-api/src/Resource.php(183): Flarum\Api\Serializer\AbstractSerializer->getAttributes() #13 /*/vendor/sycho/json-api/src/Resource.php(81): Tobscure\JsonApi\Resource->getAttributes() #14 /*/vendor/sycho/json-api/src/Document.php(194): Tobscure\JsonApi\Resource->toArray() #15 [internal function]: Tobscure\JsonApi\Document->Tobscure\JsonApi\{closure}() #16 /*/vendor/sycho/json-api/src/Document.php(193): array_map() #17 /*/vendor/sycho/json-api/src/Document.php(232): Tobscure\JsonApi\Document->toArray() #18 /*/vendor/flarum/core/src/Api/JsonApiResponse.php(27): Tobscure\JsonApi\Document->jsonSerialize() #19 /*/vendor/flarum/core/src/Api/Controller/AbstractSerializeController.php(139): Flarum\Api\JsonApiResponse->__construct() #20 /*/vendor/flarum/core/src/Http/RouteHandlerFactory.php(41): Flarum\Api\Controller\AbstractSerializeController->handle() #21 /*/vendor/flarum/core/src/Http/Middleware/ExecuteRoute.php(27): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}() #22 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\ExecuteRoute->process() #23 /*/vendor/flarum/core/src/Api/Middleware/ThrottleApi.php(33): Laminas\Stratigility\Next->handle() #24 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Api\Middleware\ThrottleApi->process() #25 /*/vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php(36): Laminas\Stratigility\Next->handle() #26 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\CheckCsrfToken->process() #27 /*/vendor/flarum/core/src/Http/Middleware/ResolveRoute.php(69): Laminas\Stratigility\Next->handle() #28 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\ResolveRoute->process() #29 /*/vendor/datitisev/flarum-maintenance/src/Middleware/APIMaintenance.php(19): Laminas\Stratigility\Next->handle() #30 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Datitisev\Maintenance\Middleware\APIMaintenance->process() #31 /*/vendor/flarum/core/src/Http/Middleware/SetLocale.php(51): Laminas\Stratigility\Next->handle() #32 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\SetLocale->process() #33 /*/vendor/flarum/core/src/Http/Middleware/AuthenticateWithHeader.php(58): Laminas\Stratigility\Next->handle() #34 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\AuthenticateWithHeader->process() #35 /*/vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php(31): Laminas\Stratigility\Next->handle() #36 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\AuthenticateWithSession->process() #37 /*/vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php(52): Laminas\Stratigility\Next->handle() #38 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\RememberFromCookie->process() #39 /*/vendor/flarum/core/src/Http/Middleware/StartSession.php(61): Laminas\Stratigility\Next->handle() #40 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\StartSession->process() #41 /*/vendor/flarum/core/src/Api/Middleware/FakeHttpMethods.php(29): Laminas\Stratigility\Next->handle() #42 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Api\Middleware\FakeHttpMethods->process() #43 /*/vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php(28): Laminas\Stratigility\Next->handle() #44 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\ParseJsonBody->process() #45 /*/vendor/flarum/core/src/Http/Middleware/HandleErrors.php(57): Laminas\Stratigility\Next->handle() #46 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\HandleErrors->process() #47 /*/vendor/flarum/core/src/Http/Middleware/InjectActorReference.php(25): Laminas\Stratigility\Next->handle() #48 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\InjectActorReference->process() #49 /*/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(81): Laminas\Stratigility\Next->handle() #50 /*/vendor/middlewares/request-handler/src/RequestHandler.php(84): Laminas\Stratigility\MiddlewarePipe->process() #51 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Middlewares\RequestHandler->process() #52 /*/vendor/middlewares/base-path-router/src/BasePathRouter.php(99): Laminas\Stratigility\Next->handle() #53 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Middlewares\BasePathRouter->process() #54 /*/vendor/laminas/laminas-stratigility/src/Middleware/OriginalMessages.php(36): Laminas\Stratigility\Next->handle() #55 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Laminas\Stratigility\Middleware\OriginalMessages->process() #56 /*/vendor/middlewares/base-path/src/BasePath.php(73): Laminas\Stratigility\Next->handle() #57 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Middlewares\BasePath->process() #58 /*/vendor/flarum/core/src/Http/Middleware/ProcessIp.php(24): Laminas\Stratigility\Next->handle() #59 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\ProcessIp->process() #60 /*/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(81): Laminas\Stratigility\Next->handle() #61 /*/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(70): Laminas\Stratigility\MiddlewarePipe->process() #62 /*/vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(73): Laminas\Stratigility\MiddlewarePipe->handle() #63 /*/vendor/datitisev/flarum-maintenance/src/Overrides/Http/Server.php(54): Laminas\HttpHandlerRunner\RequestHandlerRunner->run() #64 /*/public/index.php(26): Flarum\Http\Server->listen() #65 {main}

Additional info: sometimes the refresh works and sometimes I don't see any posts or discussions in the discussion list.
If I don't see posts or discussion, the error message above is in the logs.

m4v3rick

luceos What Upload Adapter are you using or is the Image Preview trying to resolve?

Here is the screenshot of my settings:

m4v3rick

CyberGene

Is it possible to forcibly install an earlier version of this extension if I already have the latest? Apparently the broken zip upload won’t get fixed (soon? ever?), and all was working good in the version before it got broken, so I prefer to downgrade to the last known stable version.

clarkwinkelmann

CyberGene it should be safe to go as far back as 1.5.0 as it was the last time the database structure changed. Since that version, the migrations only added new column indexes, which won't hurt if kept in older versions.

There could be issues related to setting names or permissions, I didn't check for that.

Make a backup, and use composer require fof/upload:1.5.0 (or any more recent version) to downgrade. To go back to the latest version, use * as the version.

CyberGene

clarkwinkelmann thanks. I am trying to install 1.6.1, however I get the following error:

  Problem 1
    - Root composer.json requires fof/upload 1.6.1 -> satisfiable by fof/upload[1.6.1].
    - fof/upload 1.6.1 requires softcreatr/php-mime-detector ^3.0 -> found softcreatr/php-mime-detector[3.0.0, 3.1.0, 3.2.0, 3.2.1] but the package is fixed to 4.0.0 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

Do you think it will be safe to use the --with-all-dependencies? How can I check what package has requested the 4.0.0 version of php-mime-detector?

clarkwinkelmann

CyberGene yes, you might need -W flag. You can use the why command to find out why a specific package is installed.

What you could try to do first is to use -W --dry-run flags on the require command, that way you will see which packages will be downgraded but no change will be applied. As long as only dependencies get downgraded, all is fine. But if you see other Flarum extensions listed in the output, then it means you have other extensions that don't support the older version of the dependency without themselves being downgraded. Whether those other extensions can or cannot be safely downgraded would be a question to examine case by case.

CyberGene

clarkwinkelmann just tried it, it was only required by the upload extension 1.7.0, so I successfully downgraded to fof/upload 1.6.1 and the zip upload is again working, which is important to our forum 🙂 Thank you for your help!

m4v3rick

Anyone?

Could i meanwhile just exclude the upload extension from updating and freeze it to the actual version extension with:
composer require fof/upload:1.5.8 ?

luceos

m4v3rick that works

I think you ran into a similar issue as mine (FriendsOfFlarum/uploadissues/431). What Upload Adapter are you using or is the Image Preview trying to resolve?

There was a change somewhere after 1.5 that changed how adapters were resolved from key to class name and that destroys some configurations.

m4v3rick

luceos There was a change somewhere after 1.5 that changed how adapters were resolved from key to class name and that destroys some configurations.

Any idea how I could fix this?

And who is actually maintaining this extension?

Since @davetodave178 posted the

davetodave178 Warning

I am really looking forward to update the extension from 1.5.8 to 1.8.1.

davetodave178

1.8.0 & 1.8.1

What's Changed

chore: add tests for malicious uploads, fix issues exposed by @IanM in FriendsOfFlarum/upload429
fix: change mimetype default in admin UI by @davetodave178 in FriendsOfFlarum/upload430

Full Changelog: FriendsOfFlarum/upload1.7.1 → 1.8.1

⚠️ Warning

This release fixes security vulnerabilities related to malicious file uploads. It also changes the default MIME type configuration for images. Please see the linked PR's for details if your community requires uploading unusual image formats.

It's recommended to upgrade to version 1.8.1 at the earliest convenience:

Updating

composer update fof/upload:"*"
php flarum migrate
php flarum cache:clear

davetodave178

This update also addresses issues with ZIP uploads, which have been reported numerous times here @CyberGene

CyberGene

davetodave178 thank you, testing it right away 👍🏻

P.S. Yes, just tested it and can confirm ZIP file upload works now. Thank you so much 😊

AkarinLiu

I can`t upload jpg or jpeg photo, Is it a Bug？

davetodave178

AkarinLiu Interesting. Can you please share some more details here? https://docs.flarum.org/troubleshoot. Uploding JPG's is working fine for me on version 1.8.1

m4v3rick

Just updated to the latest version and I still have the same error.
Whenever I switch the extension off, everything else works just fine. 🙁

« Previous Page