[DONE] RSS/Atom extension for $40

deseven

AmauryPi Currently, the RSS feeds are served using the current logged in user permissions.

Yeah, but if user isn't logged in they should be served with a guest permissions. That's totally ok and makes sense.
Private feeds can be a nice addition, but that's kinda out of scope for the initial task. It's up to you whether to do it or not ?

AmauryPi Maybe we should ensure that an item is instead added, keeping one entry per post?

Not sure about that. What's the point to have two or more entries for the same discussion? I thought that discussion feeds are about discussions, not about posts. I believe that when someone adds a new post to a discussion, you have to change the item's pubDate, leaving its guid intact (because it's the same discussion, not a new one). It's up to the feed reader how to interpret the fact that pubDate has changed.

AmauryPi Another thing, regarding to the per-discussion and per-user feeds, I currently can't implement them due to the Flarum routes being too unspecific.

Well, it's not a big deal. You can change it to something like that:
/rss - for global feed
/rss/t/{tag} - for tag feed
/rss/d/{id} - for discussion feed
/rss/u/{user} - for user feed
Just keep everything in one style and that's it ?

By the way, i've sent you $40. Please confirm ?

deseven

deseven It's up to the feed reader how to interpret the fact that pubDate has changed.

I actually made some research, looks like many feed readers have an option to show updated items (something like "Mark updated articles as new"). Some of them do that by default.

AmauryPi

deseven I believe that when someone adds a new post to a discussion, you have to change the item's pubDate, leaving its guid intact (because it's the same discussion, not a new one).

Well, it's the current behavior so I'll keep it as is ?

deseven Well, it's not a big deal. You can change it to something like that:
/rss - for global feed
/rss/t/{tag} - for tag feed
/rss/d/{id} - for discussion feed
/rss/u/{user} - for user feed
Just keep everything in one style and that's it ?

That's clever, don't know why I didn't think about this. I'll use that!

deseven By the way, i've sent you $40. Please confirm ?

I confirm. Thanks again! ?

deseven Private feeds can be a nice addition, but that's kinda out of scope for the initial task. It's up to you whether to do it or not ?

I probably will.

deseven

AmauryPi P.-S. I implemented both RSS and Atom feeds, but you really should use Atom feeds as they are better, include authorship attributes, etc.

Yeah, i know, that's for compatibility only. It's nice to have different options.

Davis

AmauryPi deseven Private feeds can be a nice addition, but that's kinda out of scope for the initial task. It's up to you whether to do it or not ?

I probably will.

If you end up doing this ensure you don't add the user's Auth token but create your own tokens.

Also, I read over your code and you did a good job!

deseven

AmauryPi Well, it's the current behavior so I'll keep it as is ?

If you don't agree with me, please feel free to argue. I'm trying to use common sense, but of course there may be flaws in my logic.

Thanks for your work ?

AmauryPi

Davis I was going to generate a dedicated token anyway (I agree using the auth token is not a good idea).

AmauryPi

jordanjay29 @AmauryPi If you want you can put up a new topic in Extensions (assuming you're making this public).

I will as soon as I will consider the extension to be completely ready (there still a few things to do in my opinion). That was planned ? .

Davis Also, I read over your code and you did a good job!

That was not (by far) my first PHP project, but my first Flarum one, so I'm glad I made something correct. Thanks c: .

jordanjay29

@AmauryPi If you want you can put up a new topic in Extensions (assuming you're making this public).

Davis

AmauryPi That was not (by far) my first PHP project, but my first Flarum one, so I'm glad I made something correct. Thanks c:

I'm sure youll find more difficulty in the Javascript side of things. I wish you good luck!

Dominion

I've taken the liberty of removing the email address from a couple of the preceding posts.

In the future, I recommend exchanging such information via Gitter private chat, etc.

deseven

Dominion I've taken the liberty of removing the email address from a couple of the preceding posts.

There is no need for that, i do understand the consequences. I have my own private mail server which uses many anti spam techniques (DNSBL, greylisting, etc) and i don't really suffer from spam problems. My email address is available in many places for many years.
But still, thanks for your care.

Digital

deseven Keep in mind that what we are trying to do here is not just for you, but for all community members here at Flarum. Not everyone has system capability to safeguard their emails just like yours.

We always encourage members to exchange emails privately.

AmauryPi

So.
I tried to live-update the RSS links as the page change, but sadely it's not possible due to this 2007 Firefox bug. If this bug is one day fixed, I'll re-add the code (stored in Git) for autodiscovery live update. For now, the links are in the static HTML code, to avoid this. At least it work for the first page and RSS readers.

This said, it's complete now I think. And translated in French, too.

And I noticed I forgot to give this pretty useful information (but that can be guessed):

composer require amaurycarrade/flarum-ext-syndication

Feel free to report any problem ? .

Update: extension official thread published.

f0r3v3r

AmauryPi @deseven Thank you to both sides of this, I have been really interested in seeing an RSS feature in Flarum.

I just gave this a shake and wanted to report back with some debug info:

Notice: Undefined index: PATH_INFO in /home/user/public_html/forum/vendor/amaurycarrade/flarum-ext-syndication/src/Listener/AddClientAssetsAndLinks.php on line 83

Thank you again!

deseven

AmauryPi I tried to live-update the RSS links as the page change, but sadely it's not possible due to this 2007 Firefox bug.

I guess you can disable it for FF, but enable for other browsers.
var isFF = /firefox|aurora|iceweasel/i.test(navigator.userAgent)

AmauryPi

f0r3v3r Try an update, I probably fixed that in the last release (0.1.2). Thanks for reporting this (wasn't happening on my two test servers, both PHP integrated one and Apache).

f0r3v3r

AmauryPi Indeed that issue is fixed! Thank you!

However, if I visit forum/atom or forum/rss, or any of the other addresses, I get a message like this:

Parse error: syntax error, unexpected 'version' (T_STRING) in /home/user/public_html/forum/storage/views/0229f825c63bbe4e261a0249000212f9 on line 1

This installation is using Apache on the backend with Varnish and nginx proxying.

AmauryPi

f0r3v3r Well this one is pretty weird, it would mean PHP try to interpret the XML header:

<?xml version="1.0" encoding="UTF-8" ?>

Maybe you enabled short tags in your PHP configuration, or some weird option telling the PHP interpreter that <?xml is an opening tag for PHP code. It's not very standard.

Anyway, i'll fix that for people in your strange case.

f0r3v3r

AmauryPi Hey! Don't make me feel bad for being unique! No, actually I went back after reading your reply, and it was enabled by default in the version I compiled ( 5.6.14).

Not really something I have ever had an issue with to know about. The previous version does work with short_open_tag = Off

Thanks again.

AmauryPi

Fixed in the last release.
But you should really disable short tags (except if you depend on them), it's a deprecated feature.

« Previous Page Next Page »