[DONE] RSS/Atom extension for $40

deseven

AmauryPi yeah, i have the latest version with {!! stuff. Didn't work for me.
What do you mean by saying "compiled"?

AmauryPi

deseven The blade templates (like this one) are compiled (transformed) into plain PHP (like this for the previous one) before execution. So your replacement is exactly the same as the compiled version.

Maybe it's a caching problem somewhere.

deseven

AmauryPi ok, i see ?
That can't be a caching problem because two hours ago i installed your extension for the first time and got an error shown above.

Also, this works for me too:
{!! '<'.'?xml version="1.0" encoding="utf-8"?'.'>' !!}

I don't know how laravel and blade templates work, but it seems that php interprets blade code, finds <? and tries to execute it. After that laravel should kick in and execute sentences between {!! !!} with eval(), but it's too late, obviously.

AmauryPi

deseven Ok so PHP is sometimes stupid and thinks ?> closes a script even in a string. Okay. (Fix release incoming.)

Edit: released.

deseven

AmauryPi same error with 0.1.4 version ?
But it's about comment section now. Removing first line in atom.blade.php and rss.blade.php helps.

As i said before, it seems that php tries to interpret everything in blade template and it doesn't know about blade comments. It just sees <? and that's it...

UPD: short_open_tag is a default configuration for php, it's up to users or package maintainers to disable it if they want to. Sad truth...

AmauryPi

It's just like your templates are not compiled but used directly somehow... Or the problem is in the compiler, well I don't know honestly. Updated anyway, I removed the comments.

As i said before, it seems that php tries to interpret everything in blade template and it doesn't know about blade comments.

Yes but the blade compiler removes them completely.

deseven

I dunno.
I tested that with clean install of php 5.6.26 and php 7.0.13. In both cases short_open_tag is enabled and overall behaviour is exactly the same.

However, that thing with concatenation should help in all cases.
Thanks for your time ?

deseven

By the way, that's really strange.
I tried to put this in a blade template:

{{-- <?php echo "test" ?> --}}
{{-- comment --}}

and i got

{{-- test --}}

as an output (note that there is no second comment here). Which means that it's actually being interpreted before anything else. Is this intended at all?

AmauryPi

The Blade template uses the Zend Lexer to parse the tokens and keep as-is the PHP tokens, so it seems to be intended. Totally undocumented (or I'm blind), but intended.

Edit: OK, technically, it's in the doc, but not the fact that PHP in comments is still interpreted (plus the Blade tokens ignored if there are plain old PHP inside).

Unlike other popular PHP templating engines, Blade does not restrict you from using plain PHP code in your views.
— Laravel documentation

deseven

Mystery solved then. But this is really bad and unpredictable behaviour. Comment's purpose is to comment something, not to be executed.

I imagine some people actually may want to use it for debugging and someone, somewhere have something like that:

{{-- <?php var_dump($very_important_variable_with_your_bank_account_data) ?> --}}

That's insane.

FBI

AmauryPi

4 Euro has been sent..

Well, As I promised before, for each donation, I will add 10% of total amount from @deseven donation's ?
Since I dont have exact conversion, US$ 4 ~~ Euro 4
PayPal's exchange rate as of Dec 11, 2016: 1 Indonesian Rupiah = 0,000068017 Euros Conversion Options This transaction will appear on your bill as "PayPal *AMAURYCARRA". Transaction: 70K42682XH020552B

Thanks for great work.
I will try it..

FBI

Well, here my finding after installed ?
- tested, tag is working..
- We can switch between atom or RSS. Brilliant idea from @deseven and implement by @AmauryPi for just adding/typing "atom/rss" between, on normal flarum link
- I think, flarum should protect this "atom/rss" name directory for this feed features. @Davis @Toby
- Damn, the individual posts discussion-slug perfectly working. And I think only Flarum has this potential ability comparing other forum engine, I ever used since 2000!!
- For recent replied, it just pointing in to slug-discussion RSS. This is good for user/visitor with slow connection. Or, implementing other 3rd party features such fetching data, since resulting in XML format.

Hopefully, there is admin panel which control the size/limit of fetched RSS characters, attachment, image detection view etc...

Davis

FBI - I think, flarum should protect this "atom/rss" name directory for this feed features

I doubt it would be used unless it's in a different rss extension, in which case you probably should only have one of them installed.

FBI This is good for user/visitor with slow connection

Flarum is already great for slow connections. The markup of the site is downloaded only once ? and the rest of the data is formatted in JSON.

owner

First, Thank you For Such A Great Plugin @deseven @Pilvinen

If Someone Can Start similar Project Like This For Private Conversation ?
I like To Donate too

Davis

[unknown] I believe @[deleted] has been working on something like this

BlackSheep

Davis It's delayed until the new API is out if i read that right.

« Previous Page