[DONE] RSS/Atom extension for $40

f0r3v3r

AmauryPi @deseven Thank you to both sides of this, I have been really interested in seeing an RSS feature in Flarum.

I just gave this a shake and wanted to report back with some debug info:

Notice: Undefined index: PATH_INFO in /home/user/public_html/forum/vendor/amaurycarrade/flarum-ext-syndication/src/Listener/AddClientAssetsAndLinks.php on line 83

Thank you again!

AmauryPi

f0r3v3r Try an update, I probably fixed that in the last release (0.1.2). Thanks for reporting this (wasn't happening on my two test servers, both PHP integrated one and Apache).

f0r3v3r

AmauryPi Indeed that issue is fixed! Thank you!

However, if I visit forum/atom or forum/rss, or any of the other addresses, I get a message like this:

Parse error: syntax error, unexpected 'version' (T_STRING) in /home/user/public_html/forum/storage/views/0229f825c63bbe4e261a0249000212f9 on line 1

This installation is using Apache on the backend with Varnish and nginx proxying.

AmauryPi

f0r3v3r Well this one is pretty weird, it would mean PHP try to interpret the XML header:

<?xml version="1.0" encoding="UTF-8" ?>

Maybe you enabled short tags in your PHP configuration, or some weird option telling the PHP interpreter that <?xml is an opening tag for PHP code. It's not very standard.

Anyway, i'll fix that for people in your strange case.

f0r3v3r

AmauryPi Hey! Don't make me feel bad for being unique! No, actually I went back after reading your reply, and it was enabled by default in the version I compiled ( 5.6.14).

Not really something I have ever had an issue with to know about. The previous version does work with short_open_tag = Off

Thanks again.

AmauryPi

Fixed in the last release.
But you should really disable short tags (except if you depend on them), it's a deprecated feature.

AmauryPi

At least now it works in all configurations ? .

deseven

AmauryPi At least now it works in all configurations

Not for me. I have php 7.0 (the default config for it also have short tags enabled, i don't know why), but your workaround didn't work for me:
PHP Fatal error: Method Illuminate\View\View::__toString() must not throw an exception, caught ErrorException: Parse error: syntax error, unexpected '?>'

So, i replaced xml declaration with this:
<?php echo '<?xml version="1.0" encoding="utf-8" ?>' ?>

deseven

AmauryPi I tried to live-update the RSS links as the page change, but sadely it's not possible due to this 2007 Firefox bug.

I guess you can disable it for FF, but enable for other browsers.
var isFF = /firefox|aurora|iceweasel/i.test(navigator.userAgent)

AmauryPi

deseven even with

{!! '<?xml version="1.0" encoding="utf-8"?>' !!}

compiled as

<?php echo '<?xml version="1.0" encoding="utf-8"?>'; ?>

(from the latest version)? Or you're not using the latest one.

deseven Yes, why not. I need to test on other browsers before.

deseven

AmauryPi yeah, i have the latest version with {!! stuff. Didn't work for me.
What do you mean by saying "compiled"?

AmauryPi

deseven The blade templates (like this one) are compiled (transformed) into plain PHP (like this for the previous one) before execution. So your replacement is exactly the same as the compiled version.

Maybe it's a caching problem somewhere.

deseven

AmauryPi ok, i see ?
That can't be a caching problem because two hours ago i installed your extension for the first time and got an error shown above.

Also, this works for me too:
{!! '<'.'?xml version="1.0" encoding="utf-8"?'.'>' !!}

I don't know how laravel and blade templates work, but it seems that php interprets blade code, finds <? and tries to execute it. After that laravel should kick in and execute sentences between {!! !!} with eval(), but it's too late, obviously.

AmauryPi

deseven Ok so PHP is sometimes stupid and thinks ?> closes a script even in a string. Okay. (Fix release incoming.)

Edit: released.

deseven

AmauryPi same error with 0.1.4 version ?
But it's about comment section now. Removing first line in atom.blade.php and rss.blade.php helps.

As i said before, it seems that php tries to interpret everything in blade template and it doesn't know about blade comments. It just sees <? and that's it...

UPD: short_open_tag is a default configuration for php, it's up to users or package maintainers to disable it if they want to. Sad truth...

AmauryPi

It's just like your templates are not compiled but used directly somehow... Or the problem is in the compiler, well I don't know honestly. Updated anyway, I removed the comments.

As i said before, it seems that php tries to interpret everything in blade template and it doesn't know about blade comments.

Yes but the blade compiler removes them completely.

deseven

I dunno.
I tested that with clean install of php 5.6.26 and php 7.0.13. In both cases short_open_tag is enabled and overall behaviour is exactly the same.

However, that thing with concatenation should help in all cases.
Thanks for your time ?

deseven

By the way, that's really strange.
I tried to put this in a blade template:

{{-- <?php echo "test" ?> --}}
{{-- comment --}}

and i got

{{-- test --}}

as an output (note that there is no second comment here). Which means that it's actually being interpreted before anything else. Is this intended at all?

AmauryPi

The Blade template uses the Zend Lexer to parse the tokens and keep as-is the PHP tokens, so it seems to be intended. Totally undocumented (or I'm blind), but intended.

Edit: OK, technically, it's in the doc, but not the fact that PHP in comments is still interpreted (plus the Blade tokens ignored if there are plain old PHP inside).

Unlike other popular PHP templating engines, Blade does not restrict you from using plain PHP code in your views.
— Laravel documentation

deseven

Mystery solved then. But this is really bad and unpredictable behaviour. Comment's purpose is to comment something, not to be executed.

I imagine some people actually may want to use it for debugging and someone, somewhere have something like that:

{{-- <?php var_dump($very_important_variable_with_your_bank_account_data) ?> --}}

That's insane.

« Previous Page