FriendsOfFlarum Byōbu, well integrated, advanced private discussions

ornanovitch

[to reproduce]

I noticed that on the discussion list, for a private discussion, the recipient zone (item-recipients) is clickable as expected (as the entire DiscussionListItem), but doesn't point to the discussion id. It just reloads the discussion list 😶

IanM

1.0.0-beta.7

Fix recipients modal styling issue
Adds frontend typings for better development
Hide admin page translation relating to Tags if tags is not installed
Extract Prettier config to .prettierrc
Bump Webpack CLI
Conversions to Typescript and more modern code
Use core [deleted] text instead of custom translation
Use oninput instead of onkeyup to support copy-pasting
Clean up Less
Merge recipient label borders when next to one another (no more 2px borders!)

Huge thanks to @davwheat for putting this together whilst I concentrate on other things these last couple of weeks 🏆️

Installation

composer require fof/byobu:^1.0.0-beta.7
php flarum cache:clear

Please continue to provide feedback on your experiences with this beta, so that we can move towards 1.0 of this extension as quickly as possible 👍️

IanM

Justman10000 No, it's not. Please read the thread. Simply posting > Justman10000 Outdated
on any extension you think is not updated is not useful.

IanM

rafaucau

The search for recipients is case-sensitive. This makes it very difficult to search.

K4nj

Hello, good day I'm facing an issue where my forum displays a blank editor and I can't click anywhere !(https://prnt.sc/16kv8wl) this happens when I click send a message, a bit of assistance would be greatly appreciated thank you.

IanM

K4nj Can you tell me which version of the extension you are using please?

K4nj

IanM latest beta version of this plugin, I'm also using the latest florum core.

GreXXL

ornanovitch Hey, IDK if it's already a known issue but it seems that it's still possible to edit recipients for non Byobu discussions.
Keep up the good work 😀

Don't know if intended? But I think not - was reported above just for completeness 🙂

ornanovitch

GreXXL as @IanM stated in a split discussion:

This is to allow the conversion of a regular discussion into a private discussion

So this is as intended. Nevertheless there is an opened MR which discusses it. Quoting myself about this intended behavior:

I fully agree, but IMO in that case such a possibility should depend on an other permission than editUserRecipients and editGroupRecipients as it's a very specific action that one could want to restrict a lot more

Maybe it would be more consistent if edit{User|Group}Recipients were general permissions, when something like togglePrivateDiscussion would be a "restrict by tag" permission?

IanM

K4nj could you please try downgrading to the previous extension version and see if the problem still exists?

composer require fof/byobu:1.0.0-beta.6

If so, this is a regression in the latest, which I'll get looked at ASAP

K4nj

IanM same issue, might be issue on my side? not too sure but any suggestions on how I could possibly go about sorting it out, (https://prnt.sc/16kxig8), but this is my settings for it, not too sure if I'm doing something wrong.

IanM

K4nj Interesting.. Those settings are fine. Do you see any errors in your browser console (dev tools)?

Also, please can you share the output from php flarum info

K4nj

IanM

Flarum core 1.0.3
PHP version: 7.3.28
Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, pcntl, readline, Reflection, SPL, session, standard, bcmath, bz2, calendar, ctype, curl, dom, mbstring, fileinfo, ftp, gd, gettext, gmp, iconv, imap, intl, json, exif, mysqlnd, odbc, PDO, pgsql, Phar, posix, pspell, SimpleXML, soap, sockets, sqlite3, tidy, tokenizer, xml, xmlwriter, xsl, zip, mysqli, pdo_mysql, PDO_ODBC, pdo_pgsql, pdo_sqlite, wddx, xmlreader, xmlrpc, imagick, SourceGuardian, ionCube Loader
+---------------------------------+---------------+--------+
| Flarum Extensions | | |
+---------------------------------+---------------+--------+
| ID | Version | Commit |
+---------------------------------+---------------+--------+
| flarum-subscriptions | v1.0.0 | |
| flarum-tags | v1.0.3 | |
| flarum-flags | v1.0.0 | |
| flarum-markdown | v1.0.1 | |
| fof-follow-tags | 1.0.0 | |
| askvortsov-auto-moderator | v0.1.1 | |
| fof-oauth | 1.0.1 | |
| flarum-approval | v1.0.0 | |
| flarum-suspend | v1.0.0 | |
| phenomlab-fancybox-wrapper | 0.8 | |
| glowingblue-rich-text | v2.0.4-beta.1 | |
| fof-drafts | 1.0.0 | |
| clarkwinkelmann-circle-groups | 1.0.0 | |
| flarum-mentions | v1.0.0 | |
| clarkwinkelmann-group-list | 1.0.0 | |
| ianm-follow-users | 1.0.0 | |
| dem13n-topic-starter-label | 0.1.5 | |
| justoverclock-hashtag | 0.1.9 | |
| justoverclock-purify | 0.1.5 | |
| glowingblue-password-strength | 3.0.0 | |
| nyu8-email-filter | 1.0.5 | |
| v17development-user-badges | v0.1.3 | |
| askvortsov-categories | v3.0.0 | |
| flarum-sticky | v1.0.0 | |
| flarum-statistics | v1.0.0 | |
| flarum-lock | v1.0.0 | |
| flarum-likes | v1.0.0 | |
| flarum-lang-english | v1.0.0 | |
| flarum-emoji | v1.0.0 | |
| fof-recaptcha | 1.0.0 | |
| michaelbelgium-discussion-views | v7.0.0 | |
| nearata-twofactor | v2.0.0 | |
| the-turk-pallet-theme | 0.1.0-beta.4 | |
| ianm-synopsis | 1.0.0 | |
| ianm-level-ranks | 1.0.0 | |
| fof-byobu | 1.0.0-beta.6 | |
| noriods-auto-more | v1.0.0 | |
+---------------------------------+---------------+--------+

Console Displays these errors after clicking it (https://prnt.sc/16kz7hk)

davwheat

The issue reported by K4nj seems to stem from this line, but I can't see any reason that it should happen.

Can the username passed to the function be invalid, resulting in the app.store.getBy() call returning undefined instead of a user? It can't be app.session.user as that would then throw an error back on L103.

rafaucau

This icon looks bad:

JohnP

The replied icon touches the right edge of the list of recipients, which looks slightly messy.

Can be resolved by adding 5px of margin to the right of li.item-recipients

bsonet

Hi there. Latest Flarum version (1.0.3). Trying to install this ext and got this errors.....hmmmm

` Problem 1
    - fof/byobu[0.1.0, ..., 0.1.2] require flarum/core ^0.1.0-beta.7 -> found fl                                                                    arum/core[v0.1.0-beta.7, ..., v0.1.0-beta.16] but it does not match your minimum                                                                    -stability.
    - fof/byobu[0.2.0, ..., 0.3.4] require flarum/core ^0.1.0-beta.8 -> found fl                                                                    arum/core[v0.1.0-beta.8, ..., v0.1.0-beta.16] but it does not match your minimum                                                                    -stability.
    - fof/byobu[0.4.0, ..., 0.5.0] require flarum/core ^0.1.0-beta.10 -> found f                                                                    larum/core[v0.1.0-beta.10, ..., v0.1.0-beta.16] but it does not match your minim                                                                    um-stability.
    - fof/byobu[0.5.1, ..., 0.5.8] require flarum/core ^0.1.0-beta.13 -> found f                                                                    larum/core[v0.1.0-beta.13, ..., v0.1.0-beta.16] but it does not match your minim                                                                    um-stability.
    - fof/byobu[0.6.0, ..., 0.6.1] require flarum/core ^0.1.0-beta.15 -> found f                                                                    larum/core[v0.1.0-beta.15, v0.1.0-beta.16] but it does not match your minimum-st                                                                    ability.
    - Root composer.json requires fof/byobu * -> satisfiable by fof/byobu[0.1.0,                                                                     ..., 0.6.1].

luceos

bsonet try

composer require fof/byobu:"*@beta"

clarkwinkelmann

stryguardian see above, there's a different command to install the beta version we have for Flarum 1.0 luceos

The command in the first post of the discussion will not work. I don't really think we want to change it though because hopefully the non-beta version will be available soon.

rafaucau

Another problem. When I display a private discussion with a deleted user, when I click something, the frontend crashes and renders twice.

TypeError: Cannot read property 'id' of undefined

shebaoting

I cannot open this extension, it prompts the following error.

POST https://wyz.xyz/api/extensions/fof-byobu

PDOException: SQLSTATE[42S21]: Column already exists: 1060 Duplicate column name 'blocks_byobu_pd' in /www/wwwroot/wyz.xyz/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:112
Stack trace:
#0 /www/wwwroot/wyz.xyz/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php(112): PDOStatement->execute()
#1 /www/wwwroot/wyz.xyz/vendor/illuminate/database/Connection.php(485): Doctrine\DBAL\Driver\PDOStatement->execute()
#2 /www/wwwroot/wyz.xyz/vendor/illuminate/database/Connection.php(685): Illuminate\Database\Connection->Illuminate\Database\{closure}()
#3 /www/wwwroot/wyz.xyz/vendor/illuminate/database/Connection.php(652): Illuminate\Database\Connection->runQueryCallback()
#4 /www/wwwroot/wyz.xyz/vendor/illuminate/database/Connection.php(486): Illuminate\Database\Connection->run()
#5 /www/wwwroot/wyz.xyz/vendor/illuminate/database/Schema/Blueprint.php(109): Illuminate\Database\Connection->statement()
#6 /www/wwwroot/wyz.xyz/vendor/illuminate/database/Schema/Builder.php(365): Illuminate\Database\Schema\Blueprint->build()
#7 /www/wwwroot/wyz.xyz/vendor/illuminate/database/Schema/Builder.php(212): Illuminate\Database\Schema\Builder->build()
#8 /www/wwwroot/wyz.xyz/vendor/fof/byobu/migrations/2019_07_08_000000_add_blocks_pd_to_users.php(20): Illuminate\Database\Schema\Builder->table()
#9 [internal function]: Illuminate\Filesystem\Filesystem::{closure}()
#10 /www/wwwroot/wyz.xyz/vendor/flarum/core/src/Database/Migrator.php(202): call_user_func()
#11 /www/wwwroot/wyz.xyz/vendor/flarum/core/src/Database/Migrator.php(133): Flarum\Database\Migrator->runClosureMigration()
#12 /www/wwwroot/wyz.xyz/vendor/flarum/core/src/Database/Migrator.php(116): Flarum\Database\Migrator->runUp()
#13 /www/wwwroot/wyz.xyz/vendor/flarum/core/src/Database/Migrator.php(90): Flarum\Database\Migrator->runMigrationList()
#14 /www/wwwroot/wyz.xyz/vendor/flarum/core/src/Extension/Extension.php(482): Flarum\Database\Migrator->run()

shebaoting

shebaoting How do I solve this problem?

« Previous Page Next Page »