FriendsOfFlarum Byōbu, well integrated, advanced private discussions

xasharma

Which version should I install for Flarum 1.0.4 ?

luceos

composer require fof/byobu:"*@beta"

xasharma

luceos

Thank you

xasharma

luceos

I am having a problem ... Its working but

Provokator86

xasharma maybe change http > https?

luceos

Can you check your storage/logs latest log file or enable debug to see a trace/error?

xasharma

storage/logs - https://hastebin.com/cahibewuco.less

luceos

xasharma

luceos

Debug logs - https://hastebin.com/adapehaxob.less

Walys

Some questions.

1- When any user open a Private Discuss with other. After the first message view this text:
"OP user" added recipients "user1" "OPuser"

If I click on "user1" go to user profile correct but if I link in "OPuser" this is mine (I open the Discussion) have an error and Flarum said me: "The requested resource was not found."

2- When the user reply the Private Discussion you view this in "all discussion" tag. Ok, but I view that this "private discussion" go down if have any other more new and recently discuss in the forum. I think this is a problem if any user have many Notifications, it´s possible that not view the Private discussion at first to reply fast.
Maybe possible "sticky" the private discussion when any reply in "all discussion" tags?
Or maybe tick in bold the tag text: Private Discussions?

Sorry, not explain well, my english is not soo good. 😆

xasharma

Provokator86 it is in localhost .... I have tried on HTTPS also

m4v3rick

Not sure if already mentioned:

If one user opens a private discussion with another one and both later leave this discussion, the discussion still exists but seems to lose the "private"-tag. It is then a discussion without any tag but suddenly visible to Admin and Supermod/Mod.

Any problem with my permission settings or intended?

Edit: it is a deleted private discussion without any tag.

luceos

m4v3rick is it visible to guests or other regular members?

m4v3rick

hrvoje_hr

m4v3rick If one user opens a private discussion with another one and both later leave this discussion, the discussion still exists but seems to lose the "private"-tag. It is then a discussion without any tag but suddenly visible to Admin and Supermod/Mod.

m4v3rick

luceos Nope, only to people with the right to delete a discussion - as far as I found out yet.
To remove the right "delete discussion forever" won't help.

SnakePromise

Don't know if I should report it here or in flarum core or search…

Anyway — if I have a private discussion with a title ABC, but afterwards disable Byobu, then doing a search for ABC results in error: "Oops! Something went wrong. Please reload the page and try again. DEBUG". If I enable Byobu and do the same search again, there's no error.

clarkwinkelmann

SnakePromise are you able to share the error message from the Flarum log file at <flarum>/storage/logs ? This will help us find from which part of Byobu or Flarum the error really comes.

luceos

m4v3rick I think @IanM and I talked about this in the past and we considered soft deleting those discussions or deleting them entirely. I think soft deletion makes sense. But this solution and the current implementation aren't much different as elevated users are still able to see both, only hard deletion actually makes those posts inaccessible to elevated users.

Understand where we are coming from here, the one having access to the database has access to those posts no matter how. I'd love to hear about arguments for any implementation.

SnakePromise

clarkwinkelmann It's the same message I get when clicking on DEBUG? (I have debug enabled.)

Here it is:

GET https://MYSERVER/api/discussions

InvalidArgumentException: Cannot load XML: Extra content at the end of the document
 in /MYDIR/flarum/vendor/s9e/text-formatter/src/Renderer.php:46
Stack trace:
#0 /MYDIR/flarum/vendor/s9e/text-formatter/src/Renderers/PHP.php(303): s9e\TextFormatter\Renderer->loadXML('<r><p><p>dom\xC4\x81j...')
#1 /MYDIR/flarum/vendor/s9e/text-formatter/src/Renderer.php(66): s9e\TextFormatter\Renderers\PHP->renderRichText('<r><p><p>dom\xC4\x81j...')
#2 /MYDIR/flarum/vendor/flarum/core/src/Formatter/Formatter.php(113): s9e\TextFormatter\Renderer->render('<r><p><p>dom\xC4\x81j...')
#3 /MYDIR/flarum/vendor/flarum/core/src/Post/CommentPost.php(172): Flarum\Formatter\Formatter->render('<r><p><p>dom\xC4\x81j...', Object(Flarum\Post\CommentPost), Object(Laminas\Diactoros\ServerRequest))
#4 /MYDIR/flarum/vendor/flarum/core/src/Api/Serializer/BasicPostSerializer.php(44): Flarum\Post\CommentPost->formatContent(Object(Laminas\Diactoros\ServerRequest))
#5 /MYDIR/flarum/vendor/flarum/core/src/Api/Serializer/PostSerializer.php(21): Flarum\Api\Serializer\BasicPostSerializer->getDefaultAttributes(Object(Flarum\Post\CommentPost))
#6 /MYDIR/flarum/vendor/flarum/core/src/Api/Serializer/AbstractSerializer.php(88): Flarum\Api\Serializer\PostSerializer->getDefaultAttributes(Object(Flarum\Post\CommentPost))
#7 /MYDIR/flarum/vendor/tobscure/json-api/src/Resource.php(169): Flarum\Api\Serializer\AbstractSerializer->getAttributes(Object(Flarum\Post\CommentPost), NULL)
#8 /MYDIR/flarum/vendor/tobscure/json-api/src/Resource.php(75): Tobscure\JsonApi\Resource->getAttributes()
#9 /MYDIR/flarum/vendor/tobscure/json-api/src/Document.php(187): Tobscure\JsonApi\Resource->toArray()
#10 [internal function]: Tobscure\JsonApi\Document->Tobscure\JsonApi\{closure}(Object(Tobscure\JsonApi\Resource))
#11 /MYDIR/flarum/vendor/tobscure/json-api/src/Document.php(186): array_map(Object(Closure), Array)
#12 /MYDIR/flarum/vendor/tobscure/json-api/src/Document.php(224): Tobscure\JsonApi\Document->toArray()
#13 /MYDIR/flarum/vendor/flarum/core/src/Api/JsonApiResponse.php(27): Tobscure\JsonApi\Document->jsonSerialize()
#14 /MYDIR/flarum/vendor/flarum/core/src/Api/Controller/AbstractSerializeController.php(129): Flarum\Api\JsonApiResponse->__construct(Object(Tobscure\JsonApi\Document))
#15 /MYDIR/flarum/vendor/flarum/core/src/Http/RouteHandlerFactory.php(41): Flarum\Api\Controller\AbstractSerializeController->handle(Object(Laminas\Diactoros\ServerRequest))
#16 /MYDIR/flarum/vendor/flarum/core/src/Http/Middleware/ExecuteRoute.php(27): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}(Object(Laminas\Diactoros\ServerRequest), Array)
#17 /MYDIR/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\ExecuteRoute->process(Object(Laminas\Diactoros\ServerRequest), Object(Closure))
#18 /MYDIR/flarum/vendor/flarum/core/src/Api/Middleware/ThrottleApi.php(33): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#19 /MYDIR/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Api\Middleware\ThrottleApi->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#20 /MYDIR/flarum/vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php(36): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#21 /MYDIR/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\CheckCsrfToken->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#22 /MYDIR/flarum/vendor/flarum/core/src/Http/Middleware/ResolveRoute.php(67): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#23 /MYDIR/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\ResolveRoute->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#24 /MYDIR/flarum/vendor/flarum/core/src/Http/Middleware/SetLocale.php(51): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#25 /MYDIR/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\SetLocale->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#26 /MYDIR/flarum/vendor/flarum/core/src/Http/Middleware/AuthenticateWithHeader.php(56): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#27 /MYDIR/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\AuthenticateWithHeader->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#28 /MYDIR/flarum/vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php(31): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#29 /MYDIR/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\AuthenticateWithSession->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#30 /MYDIR/flarum/vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php(52): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#31 /MYDIR/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\RememberFromCookie->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#32 /MYDIR/flarum/vendor/flarum/core/src/Http/Middleware/StartSession.php(61): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#33 /MYDIR/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\StartSession->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#34 /MYDIR/flarum/vendor/flarum/core/src/Api/Middleware/FakeHttpMethods.php(29): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#35 /MYDIR/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Api\Middleware\FakeHttpMethods->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#36 /MYDIR/flarum/vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php(28): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#37 /MYDIR/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\ParseJsonBody->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#38 /MYDIR/flarum/vendor/flarum/core/src/Http/Middleware/HandleErrors.php(57): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#39 /MYDIR/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\HandleErrors->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#40 /MYDIR/flarum/vendor/flarum/core/src/Http/Middleware/InjectActorReference.php(25): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#41 /MYDIR/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\InjectActorReference->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#42 /MYDIR/flarum/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(76): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#43 /MYDIR/flarum/vendor/middlewares/request-handler/src/RequestHandler.php(84): Laminas\Stratigility\MiddlewarePipe->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#44 /MYDIR/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Middlewares\RequestHandler->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#45 /MYDIR/flarum/vendor/middlewares/base-path-router/src/BasePathRouter.php(101): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#46 /MYDIR/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Middlewares\BasePathRouter->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#47 /MYDIR/flarum/vendor/laminas/laminas-stratigility/src/Middleware/OriginalMessages.php(36): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#48 /MYDIR/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Laminas\Stratigility\Middleware\OriginalMessages->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#49 /MYDIR/flarum/vendor/middlewares/base-path/src/BasePath.php(73): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#50 /MYDIR/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Middlewares\BasePath->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#51 /MYDIR/flarum/vendor/flarum/core/src/Http/Middleware/ProcessIp.php(24): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#52 /MYDIR/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\ProcessIp->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#53 /MYDIR/flarum/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(76): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#54 /MYDIR/flarum/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(65): Laminas\Stratigility\MiddlewarePipe->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\EmptyPipelineHandler))
#55 /MYDIR/flarum/vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(96): Laminas\Stratigility\MiddlewarePipe->handle(Object(Laminas\Diactoros\ServerRequest))
#56 /MYDIR/flarum/vendor/flarum/core/src/Http/Server.php(44): Laminas\HttpHandlerRunner\RequestHandlerRunner->run()
#57 /MYDIR/flarum/public/index.php(26): Flarum\Http\Server->listen()
#58 {main}

SnakePromise

clarkwinkelmann

Investigated more and this has nothing to do with Byobu. Several thousands of old posts had </r> and </t> closing tag in the middle of the post and that's why flarum complained. Corrected that using grep and everything works now.

m4v3rick

luceos Understand where we are coming from here, the one having access to the database has access to those posts no matter how. I'd love to hear about arguments for any implementation.

I understand your argument which makes sense in some ways but we do have a team of moderators and "super"moderators without any access to the database (not even to the backend - only admins have this and I am the only one with database access).
If private discussions which are not visible to mods and supermods until people leave them I am not sure about GDPR concerns, because these discussions would be visible to people not meant to see.
If the discussion wouldn't lose the "private" tag that could be a solution but I am unaware if people who left the discussion could rejoin them.
Also these discussions would remain as ghost discussions and could only be deleted at database level I guess (normal user are not allowed to delete any discussion according to our permission settings).

luceos

m4v3rick I just checked the logic and it currently soft deletes the discussion when all recipients leave. Through an extender in extend.php of your forum (or further development on this extension) one could enforce actual deletion of that discussion.

extend.php possible solution:

return [
    (new Flarum\Extend\Event)->listen(\FoF\Byobu\Events\Deleting::class, function ($event) {
        $event->discussion->afterSave(function ($discussion) {
            $discussion->delete();
        });
    });
];

No guarantees this works, so test this locally first. I will consider something better for the long run.

m4v3rick

luceos I will consider something better for the long run.

Any update on this?
The problem still exists and I didn't want to play with the code. At the moment I took the "soft delete discussion" rights away from the mods. Still this is not a reasonable way imho, but more a workaround.

fakruzaruret

I cant update byobu

I gethis error
fof/byobu 0.6.1 requires flarum/core ^0.1.0-beta.15 -> found flarum/core[v0.1.0-beta.15, v0.1.0-beta.16] but it conflicts with your root composer.json require (v1.0.4).

davwheat

fakruzaruret

You're requiring 0.6.1 instead of *.

Run the update command exactly as shown:

composer update fof/byobu:"*"

« Previous Page Next Page »