FriendsOfFlarum Byōbu, well integrated, advanced private discussions

MathieuM

Hello,

When I try to activate the extension, it's impossible and the error console gives me :

Uncaught (in promise) Object { status: 500, options: {…}, xhr: XMLHttpRequest, responseText: '{"errors":[{"status":"500","code":"unknown"}]}', response: {…}, alert: {…} } alert: Object { type: "error", content: (1) […], controls: false } options: Object { background: true, url: "support/api/extensions/fof-byobu", method: "POST", … } response: Object { errors: (1) […] } responseText: '{"errors":[{"status":"500","code":"unknown"}]}' status: 500 xhr: XMLHttpRequest { readyState: 4, timeout: 0, withCredentials: false, … } <prototype>: Object { … }

What does it mean please? 🙂

luceos

MathieuM check your Flarum logs.

MathieuM

Here it is 🙂

MathieuM

If I take only errors today when I try to activate this extension, I get this : logs

It seems to not have all entries in db?

clarkwinkelmann

The relevant error is probably

[2023-03-25 14:50:36] flarum.ERROR: PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'npxl_flarum.flarum_recipients' doesn't exist in /home/clients/440651efa077926db06b61d64304e0c4/web/support/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:117

Can you give us more details about your setup? Is this a new Flarum installation. Is this the first time you install this extension? Are you able to share your php flarum info output?

Your database seems broken, which generally doesn't happen if this is the first time you install the extension. Or maybe there's an issue with the database table prefix.

MathieuM

I'd already gave a try to this extension several month ago yes, probably with early beta of Flarum.

This is php flarum info :

Flarum core: 1.7.2
PHP version: 7.3.33
MySQL version: 5.7.26-log
Loaded extensions: Core, date, libxml, openssl, pcre, sqlite3, zlib, bcmath, bz2, calendar, ctype, curl, dom, hash, fileinfo, filter, ftp, gd, gettext, gmp, SPL, iconv, session, intl, json, ldap, mbstring, standard, pcntl, PDO, mysqlnd, pdo_sqlite, pgsql, Phar, posix, Reflection, imap, SimpleXML, soap, sockets, sodium, pdo_mysql, exif, tidy, tokenizer, wddx, xml, xmlreader, xmlwriter, xsl, mysqli, geos, imagick, mailparse, mcrypt, memcache, memcached, mongodb, OAuth, PDFlib, propro, raphf, ssh2, timezonedb, uploadprogress, xmlrpc, yaz, zip, http, ionCube Loader
+----------------------+---------+--------+
| Flarum Extensions    |         |        |
+----------------------+---------+--------+
| ID                   | Version | Commit |
+----------------------+---------+--------+
| flarum-flags         | v1.7.0  |        |
| flarum-tags          | v1.7.1  |        |
| flarum-suspend       | v1.7.0  |        |
| fof-oauth            | 1.3.0   |        |
| flarum-approval      | v1.7.0  |        |
| v17development-seo   | v1.8.0  |        |
| ianm-synopsis        | 1.2.2   |        |
| fof-user-directory   | 1.2.3   |        |
| fof-share-social     | 1.1.2   |        |
| fof-recaptcha        | 1.1.1   |        |
| fof-polls            | 1.3.0   |        |
| fof-links            | 1.1.3   |        |
| fof-best-answer      | 1.2.5   |        |
| flarum-subscriptions | v1.7.0  |        |
| flarum-sticky        | v1.7.0  |        |
| flarum-statistics    | v1.7.0  |        |
| flarum-pusher        | v1.7.0  |        |
| flarum-nicknames     | v1.7.0  |        |
| flarum-mentions      | v1.7.0  |        |
| flarum-markdown      | v1.7.0  |        |
| flarum-lock          | v1.7.0  |        |
| flarum-likes         | v1.7.0  |        |
| flarum-lang-french   | v4.8.1  |        |
| flarum-emoji         | v1.7.0  |        |
| flarum-bbcode        | v1.7.0  |        |
+----------------------+---------+--------+
Base URL: https://www.flarum.fr/support
Installation path: /home/clients/440651efa077926db06b61d64304e0c4/web/support
Queue driver: sync
Session driver: file
Scheduler status: Ne jamais exécuter
Mail driver: smtp
Debug mode: off

MathieuM

Hello,
If someone has an idea? 🙂

luceos

MathieuM looks like your tables are broken, I'm not sure how to resolve it if it's just this extension doing that. You probably might need someone to look at your database tables and migrations table to clean it up so you can upgrade.

Alternatively you can try to do a clean flarum install and then import your database to see if it allows upgrading. Then install this extension and see if you can enable it, if not see above.

MathieuM

I don't easily remember when it was, but I'd installed this extension a long time ago. Later, you'd published a version where we had to do some SQL modifications. Could it be the problem?

Trc4

hi @FriendsOfFlarum we have some Problems
the plugin works great with a few problematic exceptions

Images from private chat can be seen globally
if someone makes a quote from a post, it will be displayed for everyone.

clarkwinkelmann

Trc4 where are the image seen "globally"?

It is by design that anyone who knows the URL to an image can see it, otherwise it would be very difficult to support some of the storage drivers or would incur a lot of bandwidth cost if everything was always proxied through PHP.

If someone who can see an image decides to share the URL with somebody else, the link will work, and that's how it's supposed to work.

But if someone can't read a discussion, they shouldn't be able to guess the URL to the files posted inside of that discussion. If you found a way to sniff/guess files posted somewhere private please share more details so we can patch it.

I believe that the "file download" template uses some sort of proxy endpoint so it might be able to protect access when a link is shared. But on the other hand it think it cannot display a preview since that would reveal the link. An option to proxy everything would definitely be possible but I don't think it exists in the current version. I'm not sure what the best implementation would be seeing files can be hosted in multiple drivers at the same time and you might not want to proxy all types or size of files.

Trc4

clarkwinkelmann where are the image seen "globally"?

At the Profile of the User. /u/Username/uploads

DCar

Good evening, I am working on setting up a private forum (currently hosted on FreeFlarum) for a very specific use case. It is desired that the registered users are able to conduct 'private discussions'. However, the registered users receive "you do not have permission to do that" after selection of recipient(s), entering discussion title, message and 'post discussion'.

It should be noted that the majority of registered users are assigned to two (2) groups. In this particular scenario, both users belong to the same two (2) groups. Tested from user profile with Private Discussions 'tag', also clicking on profile of intended recipient Controls. Send XXXXXXX a message;.

Permissions do not allow me to select all the possible groups to which registered users may be members, however I am able to select the one (1) group to which all registered users are members. For that group, I have set permissions (Global) to allow "Create Private Discussions with users", "Add more than 2 recipients to a private discussion".

Is there another permission setting the Group must possess to 'have permission to do that'? Administrators & moderators are able to create private discussions with users.

I am confident this is 'self inflicted' but am hopeful somehow may be able to help with resolving the issue.

jmillerv

DCar How many users are they trying to add to discussions? I've noticed that you have to enable a specific setting for adding more than 2 users to a private discussion.

DCar

jmillerv

Permissions (Global) for the groups, in which the users are members, are set to allow "Create Private Discussions with users" & "Add more than 2 recipients to a private discussion".

They cannot create any private discussions .... "you do not have permission to do that". Administrators are able to create private discussions. This is the reason I suspect there may be another permission required but have not been able to identify which one.

jmillerv

I'm reading through the code now because I have a need for being able to add tags to private discussions. I'm noticing that tags are explicitly removed from the PrivateDiscussionComposer.js inside the headerItems() function.

https://github.com/FriendsOfFlarum/byobu/blob/ddc795d2a25467ae63455804368b9bafc2b9acdb/js/src/forum/pages/discussions/PrivateDiscussionComposer.js#L85

What is the motivation behind this? I'm not terribly deep into this code, but is there a reason this was designed without being able to add tags? Do private discussions use elements of the tag feature that would be incompatible. Going to keep reading, through the code, but thought that was interesting.

Any help would be appreciated!

clarkwinkelmann

jmillerv tag permissions would likely interfere with private messaging permissions.

Tags were available on private discussions at some point in the past but the feature had to be removed because it was too difficult to maintain. It's unlikely to be added back in at this time.

jmillerv

clarkwinkelmann If tags aren't possible. Do you think it would be possible to integrate FoF Webhooks with private discussion. Right now, the webhooks are based on tags which is why I started with trying to add tags. I have a use case to send private discussions to webhooks.

clarkwinkelmann

DCar can you share your php flarum info output so we can see which other extensions are active on the forum?

DCar

clarkwinkelmann I will request that information (I am a mere Administrator on the FreeFlarum site).

DCar

clarkwinkelmann I've asked the individual who set up the FreeFlarum forum to run the command. However, he is unable to SSH to execute the command. Is there another method to run php flarum info on a FreeFlarum hosted forum?

Deanna

IanM

1.3.1

fix: PD blockers cannot start a new PD with non-blockers
fix: Unable to edit recipients when one or more existing recipients are blockers for new PDs
fix: resolving dependencies in migrations is bad practice by @SychO in #185

Updating

composer require fof/byobu:"*"
php flarum cache:clear

« Previous Page Next Page »