FriendsOfFlarum Byōbu, well integrated, advanced private discussions
hey @luceos
Upgraded to 0.1.0-beta.8
and 0.2.2
Byōbu
For some reason, the extension enabled allows everyone to see all private discussions (when I'm logged out as well). All 3rd party extensions (except Byōbu) are disabled.
Disabling Byōbu still shows the private discussions, but with the recipients and Private Discussion badge removed.
New ones however function as expected.
Is it possible to migrate old ones over? running php flarum migrate
leaves it saying
Migrating extension: flagrow-byobu
Nothing to migrate.
- Edited
luceos
When I go into a private discussion I'm not a a recipient of, I get the error
The requested resource was not found.
and at that point, it is hidden from me and anonymous users (as it should be)
Only my logged in user triggers this behavior. Attempting this from a anonymous user does not trigger this behavior or error
Should not see
Should see
- Edited
After accessing the supposed-to-be-hidden page, the is_hidden value is changed to 1
Here's a example
(Should not see)
id,title,comment_count,participant_count,post_number_index,created_at,user_id,first_post_id,last_posted_at,last_posted_user_id,last_post_id,last_post_number,is_locked,is_sticky,hidden_at,hidden_user_id,is_approved,slug,is_private,votes,hotness
422,foousertitle,0,1,2,2018-10-15,21:09:28,168,6575,2018-10-15,22:13:43,168,6576,2,0,0,2018-10-15,22:15:43,168,1,foousertitle,0,0,0
422,foousertitle,0,1,2,2018-10-15,21:09:28,168,6575,2018-10-15,22:13:43,168,6576,2,0,0,2018-10-15,22:15:43,168,1,foousertitle,1,0,0
Should be able to see
537,test,2,1,3,2019-01-16,21:45:30,1,8711,2019-01-16,22:19:38,1,8713,3,0,0,NULL,NULL,1,test,1,0,0.0000
Edit:
note: If I am a recipient of the discussion, my visiting doesn't trigger is_hidden and is still visible to anyone
Edit2:
I manually flagged my own private discussions and there's no more "buggy" ones.
New ones are created correctly.
Not sure why that happened
- Edited
luceos sure
In the database I manually switched is_hidden
from 0
to 1
for private discussions I was a recipient of.
For discussions I wasn't a recipient of, once I accessed the private discussion it (byobu extension?) would then change is_hidden
from 0
to 1
on its own (and also show this error The requested resource was not found.
)
- Edited
I think you need to add a separate button as favorites to see all private messages.
- Edited
Hello.
Why the message counter takes into account messages in private discussions. It is necessary that the counter take messages only on the forum. How can this be fixed?
And I would like that the topic with private discussion was rendered separately, and not with all the discussions together.
Lolu Why the message counter takes into account messages in private discussions. It is necessary that the counter take messages only on the forum. How can this be fixed?
This is fixed for the upcoming beta 9 of Flarum.
Lolu And I would like that the topic with private discussion was rendered separately, and not with all the discussions together.
Perhaps in the future as a setting.
luceos The notifications will work in beta 9?
janosvirag_me not sure what your question is about.
Just released 0.3.0-beta which adds the ability for users to block private discussions in their user settings. In addition there's now a new permission where admins can configure which user groups are still able to start private discussions with users that block it. This adds a must needed layer of privacy to the extension. I'd love to hear your feedback.
This feature was commissioned by giffgaff.
Hey !
I've just made a PR for french locale.
https://github.com/flagrow/byobu/pull/67
Hiob thanks ! But no need to report it here, we already get GitHub notifications
[deleted]
According to Bazaar, I have Byōbu version 0.2.2 installed, and it tells me there is an update to 0.3.0-beta. However, the upgrade process doesn't seem to work - using Bazaar, or from the console.
Any ideas as to why ?