FriendsOfFlarum Byōbu, well integrated, advanced private discussions

Update. Previous error was spotted on my localhost server. When I updated flarum and byobu on my hosting, I found out that private messages work totally ok.

I don't know if it's connected with my localhost working in Windows environment or you guys already fixed something in the code, but I'm glad it works

Very minor detail: The display name driver is not used for the send <username> a message button on user dropdown, it is hardcoded to username.

sylv38 DiscussionCreatedNotification comes from fof/subscribed. This was corrected in 0.4.1, which version do you have installed?

[deleted] Console error is as below

Uncaught (in promise) TypeError: Cannot read property 'onunload' of undefined
    at r (extend.js:22)
    at addPollToDiscussion.js:57
extend.js:22 Uncaught (in promise) TypeError: Cannot read property 'onunload' of undefined
    at r (extend.js:22)
    at addPollToDiscussion.js:57
extend.js:22 Uncaught (in promise) TypeError: Cannot read property 'onunload' of undefined
    at r (extend.js:22)
    at addPollToDiscussion.js:57
extend.js:22 Uncaught (in promise) TypeError: Cannot read property 'onunload' of undefined
    at r (extend.js:22)
    at addPollToDiscussion.js:57
PrivateDiscussionComposer.js:29 Uncaught (in promise) TypeError: Cannot read property 'toArray' of undefined
    at e.n.data (PrivateDiscussionComposer.js:29)
    at t.app.initializers.add.et.a.changed (index.js:44)
    at t.<anonymous> (index.js:192)
    at t.<computed> [as preventExit] (extend.js:61)
    at t.e.load (ComposerState.js:48)
    at t.<computed> [as load] (extend.js:25)
    at IndexPage.js:298
    at new Promise (<anonymous>)
    at e.n.newDiscussionAction (IndexPage.js:296)
    at e.t.<computed> [as newDiscussionAction] (extend.js:25)

[deleted] this seems to relate to polls more than it seems to relate to byobu or am I missing something @IanM ?

IanM @luceos I just disabled FoF/Polls, and the error in the console is gone - but, if I then repeat the process, and click "Start a Discussion", this time, no error message, but the composer (new message) object fails to load unless I press F5 to reload the page.

IanM I don't have pusher installed, but do have kyrne/websockets

[deleted] I don't have pusher installed, but do have kyrne/websockets

Essentally the same, from a fof/polls perspective anyway..

IanM Ok, thanks - still the same issue as https://discuss.flarum.org/d/4762-friendsofflarum-by-bu-well-integrated-advanced-private-discussions/805

Also seeing this

extend.js:22 Uncaught (in promise) TypeError: Cannot read property 'onremove' of undefined
    at r (extend.js:22)
    at addPollToDiscussion.js:57
r @ extend.js:22
(anonymous) @ addPollToDiscussion.js:57
Promise.then (async)
(anonymous) @ addPollToDiscussion.js:23
t.<computed> @ extend.js:27
t.<computed> @ extend.js:25
a @ render.js:30
(anonymous) @ render.js:971
a @ mount-redraw.js:14
(anonymous) @ mount-redraw.js:25
requestAnimationFrame (async)
c @ mount-redraw.js:23
(anonymous) @ PostStreamState.js:118
Promise.then (async)
e.goToNumber @ PostStreamState.js:118
n.show @ DiscussionPage.js:169
Promise.then (async)
n.load @ DiscussionPage.js:112
n.oninit @ DiscussionPage.js:37
a @ render.js:30
M @ render.js:917
(anonymous) @ render.js:153
(anonymous) @ render.js:160
l @ render.js:66
u @ render.js:50
h @ render.js:374
(anonymous) @ render.js:444
f @ render.js:415
(anonymous) @ render.js:488
f @ render.js:419
h @ render.js:302
(anonymous) @ render.js:964
a @ mount-redraw.js:14
(anonymous) @ mount-redraw.js:25
requestAnimationFrame (async)
c @ mount-redraw.js:23
v @ router.js:111
Promise.then (async)
t @ router.js:126
S @ router.js:95
(anonymous) @ setImmediate.js:40
f @ setImmediate.js:69
a @ setImmediate.js:109
postMessage (async)
i @ setImmediate.js:120
p.setImmediate @ setImmediate.js:27
d @ router.js:143
p @ router.js:20
y.set @ router.js:182
s.attrs.onclick @ router.js:250
_.handleEvent @ render.js:888
extend.js:22 Uncaught (in promise) TypeError: Cannot read property 'onremove' of undefined
    at r (extend.js:22)
    at addPollToDiscussion.js:57

[deleted] this is definately coming from the pusher/websockets specific code in the extension. Unfortunately I'm running blind on attempting a fix as I don't have either setup locally. I think probably the most straightforward way to get this resolved is to see if @Kyrne can take a look at fof/polls?

I will continue to work on fof/byobu in the meantime, and hopefully get some resolution to the errors caused by it..

IanM Looks like you're right ! I updated and it solved the bug

IanM Thanks. The error persists even if I disable FoF/Polls though... :-(

[deleted] but the composer (new message) object fails to load unless I press F5 to reload the page

This is exactly the same error I have on my localhost but don't have on the actual server.

IanM just circling back on this, as the issue in still evident on my forum. Any thoughts ?

Thanks

@IanM

I'm trying to extend PrivateDiscussionComposer. I wonder, if this is exported or not.

My webpack.config.js contains:

module.exports = require('flarum-webpack-config')({
    useExtensions: ['fof-byobu'],
});

and in my extension I try:

import { byobu } from '@fof-byobu';
console.log(byobu)

... which says:

Uncaught TypeError: _fof_byobu__WEBPACK_IMPORTED_MODULE_9__ is undefined

Is there a new way to extend certain parts of Byobu?