FriendsOfFlarum Byōbu, well integrated, advanced private discussions

Ouraios

@luceos @IanM Any news on the fix of the performance issue ? I'm still unable to enable back on this amazing plugin because of the performance issue it causes you'd be amazing if you could find a way to fix it ❤

peopleinside

Beta 16, unable to send private message.
An error show: tag count primary must be from 1 - 5 really cannot understand what this mean. I cannot use tags in private messaging.

Also how to deny the creation of a new private message not sent to anyone?
Seems there is no specific permission to deny the creation for the user about a private message in the private discussion that can be seeing to every members.

This extension allow:

sending a private message to a specific user
create a private discussion visible from every member just clicking on private discussion tag and discuss privately button, no permission to deny that.

Gatsu

peopleinside If you read the posts above, you would understand that the extension is not compatible with beta 16.

peopleinside

Gatsu if so this discussion miss the incompatible tag

luceos

The dk/beta-16 branch is compatible, but we haven't tagged it yet because we want to further overhaul the extension.

Adding incompatible until we get it patched.

My apologies for the delay.

peopleinside

luceos I installed on this days and the extension is not working for me.
https://discuss.flarum.org/d/4762-friendsofflarum-by-bu-well-integrated-advanced-private-discussions/883

JohnP

luceos Thank you for the clear explanation of the state of the extension, sounds like a bit of a nightmare to update/maintain and thanks to you and @IanM for your efforts on it.

luceos The dk/beta-16 branch is compatible

Can we install this branch via composer to get it working as an interim measure (if we really needed to get access back to some old private discussions) and then be able to upgrade from there when a new version comes out, or would that cause issues?

luceos

peopleinside yeah sorry I meant dk/beta-16 which @IanM I have been working on.

See our progress on the pull request: FriendsOfFlarum/byobu147

peopleinside

luceos ok thanks so I need to wait. Thank you.

Umh can be added a permission that can deny user to create a private discussion that is not directed to another user?
Currently if users are able to send private message they see in the left menù the private discussion tag and can start a topic here that is not direct to anyone just will be visible to all members. I want avoid this, user should be able only to send a private direct message to another user.

luceos

I am going to be honest about the state that byobu is in.

Originally the idea of Byobu was to neatly integrate in Flarum, show discussions inline with other discussions - no distinguish made except for having recipients and being private. Throughout the course of several Flarum beta's people started using it as if it is a DM extension, while it was always was meant as a Private Discussion extension. The fact that code deviated from this goal created a complex and hard to maintain extension. An extension that was "donated" to the @FriendsOfFlarum ; but I doubt that donation can be seen as something benevolent.

Byobu has become extremely hard to understand. The unified index was a way to go back to the roots without shedding any of the gathered features it gained along the way, but .. it just doesn't work. I believe firmly in creating simple extensions that can be easily maintained or creating extensions that works as a framework in itself allowing other extensions to add features.

@IanM - being yet other maintainer who invested too much time into this extension - and I agree that we need to simplify Byobu and that is what we are attempting to do. Such a clean up would benefit the extension when Flarum reaches stable too.

This is the reason that Byobu takes more time, it's not an extension someone wants to work on because it is overly complex and decisions need to be made that not everyone agrees to. And that doesn't even include the time needed to test the new code in many different scenarios.

The following will change:

We will drop the unified index
Allow websocket extensions to push/update the sidebar byobu discussion count
Heavily clean up the code

peopleinside

luceos the main issue is maybe Flarum miss private message. This extension allow to report private message, other extension not so this is an issue for the other PM solutions this is why currently this seems to be the best extension. Now I understand why look little bit strange like have a tag on left that allow posting private discussion 🙂

luceos

sibidharan you can read all about it in my post luceos

edit:

sibidharan seeing that you now have spammed several issues and pull requests on the repository I am going to state this here as well:

This extension is provided as open source. Nothing forbids you from forking the extension and reintroducing the features you miss. Understand that the maintenance and support of such a fork will fall onto you as well. We - the maintainers of this extension - decided against maintaining some features in order for it to survive in at least some form.

Harassing maintainers here and on GitHub I cannot appreciate. We invest so much time just to keep extensions available to the wider public. Blaming us will get you nowhere.

luceos

peopleinside I personally hope the core team will never agree to building and maintaining a private messaging extension. The more we have worked towards stable, the more I believe the core team needs to be responsible over as little code as possible. Once the ecosystem grows bundled extensions might even be adopted by third parties to become more feature rich. This allows a much better focus on the framework, it's extensibility, quality and performance. It would also allow the core team more time to empower others to follow those conventions and build exciting, appealing and performant extensions.

luceos

JohnP you can try it out, but I've seen some quirks with it. Constraint dev-dk/beta-16 (use at your own risk).

Ouraios

Thank you luceos for your explanation about the current state of the extension, from what i understand your goal is to be able to publish a new release of byobu with the next release of flarum core ?

askvortsov

@JohnP One particular quirk is that this extension MUST be enabled before approval. This is fixed with the next release of approval, but for now this is one of the major reasons why I wouldn't recommend tagging this as broadly compatible.

Bishwas-py

FriendsOfFlarum Issue

I am getting the issue of The requested resource was not found.

POST https://site.com/api/discussions

Illuminate\Database\Eloquent\ModelNotFoundException: No query results for model [Flarum\Discussion\Discussion]. in /path_to_site/vendor/illuminate/database/Eloquent/Builder.php:503
Stack trace:
#0 /path_to_site/vendor/flarum/core/src/Discussion/DiscussionRepository.php(39): Illuminate\Database\Eloquent\Builder->firstOrFail()
#1 /path_to_site/vendor/flarum/core/src/Discussion/Command/ReadDiscussionHandler.php(47): Flarum\Discussion\DiscussionRepository->findOrFail(425, Object(Flarum\User\User))
#2 /path_to_site/vendor/illuminate/bus/Dispatcher.php(122): Flarum\Discussion\Command\ReadDiscussionHandler->handle(Object(Flarum\Discussion\Command\ReadDiscussion))
#3 /path_to_site/vendor/illuminate/pipeline/Pipeline.php(128): Illuminate\Bus\Dispatcher->Illuminate\Bus\{closure}(Object(Flarum\Discussion\Command\ReadDiscussion))
#4 /path_to_site/vendor/illuminate/pipeline/Pipeline.php(103): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Flarum\Discussion\Command\ReadDiscussion))
#5 /path_to_site/vendor/illuminate/bus/Dispatcher.php(132): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#6 /path_to_site/vendor/illuminate/bus/Dispatcher.php(78): Illuminate\Bus\Dispatcher->dispatchNow(Object(Flarum\Discussion\Command\ReadDiscussion))
#7 /path_to_site/vendor/flarum/core/src/Api/Controller/CreateDiscussionController.php(68): Illuminate\Bus\Dispatcher->dispatch(Object(Flarum\Discussion\Command\ReadDiscussion))
#8 /path_to_site/vendor/flarum/core/src/Api/Controller/AbstractSerializeController.php(102): Flarum\Api\Controller\CreateDiscussionController->data(Object(Laminas\Diactoros\ServerRequest), Object(Tobscure\JsonApi\Document))
#9 /path_to_site/vendor/flarum/core/src/Api/Controller/AbstractCreateController.php(22): Flarum\Api\Controller\AbstractSerializeController->handle(Object(Laminas\Diactoros\ServerRequest))
#10 /path_to_site/vendor/flarum/core/src/Http/RouteHandlerFactory.php(38): Flarum\Api\Controller\AbstractCreateController->handle(Object(Laminas\Diactoros\ServerRequest))
#11 /path_to_site/vendor/flarum/core/src/Http/Middleware/ExecuteRoute.php(27): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}(Object(Laminas\Diactoros\ServerRequest), Array)
#12 /path_to_site/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\ExecuteRoute->process(Object(Laminas\Diactoros\ServerRequest), Object(Closure))
#13 /path_to_site/vendor/flarum/core/src/Api/Middleware/ThrottleApi.php(33): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#14 /path_to_site/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Api\Middleware\ThrottleApi->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#15 /path_to_site/vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php(44): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#16 /path_to_site/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\CheckCsrfToken->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#17 /path_to_site/vendor/flarum/core/src/Http/Middleware/ResolveRoute.php(67): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#18 /path_to_site/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\ResolveRoute->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#19 /path_to_site/vendor/flarum/core/src/Http/Middleware/SetLocale.php(50): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#20 /path_to_site/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\SetLocale->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#21 /path_to_site/vendor/flarum/core/src/Http/Middleware/AuthenticateWithHeader.php(55): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#22 /path_to_site/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\AuthenticateWithHeader->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#23 /path_to_site/vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php(32): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#24 /path_to_site/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\AuthenticateWithSession->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#25 /path_to_site/vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php(52): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#26 /path_to_site/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\RememberFromCookie->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#27 /path_to_site/vendor/flarum/core/src/Http/Middleware/StartSession.php(61): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#28 /path_to_site/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\StartSession->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#29 /path_to_site/vendor/flarum/core/src/Api/Middleware/FakeHttpMethods.php(29): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#30 /path_to_site/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Api\Middleware\FakeHttpMethods->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#31 /path_to_site/vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php(28): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#32 /path_to_site/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\ParseJsonBody->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#33 /path_to_site/vendor/flarum/core/src/Http/Middleware/HandleErrors.php(57): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#34 /path_to_site/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\HandleErrors->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#35 /path_to_site/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(84): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#36 /path_to_site/vendor/middlewares/request-handler/src/RequestHandler.php(84): Laminas\Stratigility\MiddlewarePipe->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#37 /path_to_site/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\RequestHandler->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#38 /path_to_site/vendor/middlewares/base-path-router/src/BasePathRouter.php(101): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#39 /path_to_site/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\BasePathRouter->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#40 /path_to_site/vendor/laminas/laminas-stratigility/src/Middleware/OriginalMessages.php(42): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#41 /path_to_site/vendor/laminas/laminas-stratigility/src/Next.php(61): Laminas\Stratigility\Middleware\OriginalMessages->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#42 /path_to_site/vendor/middlewares/base-path/src/BasePath.php(73): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#43 /path_to_site/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\BasePath->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#44 /path_to_site/vendor/flarum/core/src/Http/Middleware/ProcessIp.php(24): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#45 /path_to_site/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\ProcessIp->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#46 /path_to_site/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(84): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#47 /path_to_site/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(73): Laminas\Stratigility\MiddlewarePipe->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\EmptyPipelineHandler))
#48 /path_to_site/vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(96): Laminas\Stratigility\MiddlewarePipe->handle(Object(Laminas\Diactoros\ServerRequest))
#49 /path_to_site/vendor/flarum/core/src/Http/Server.php(44): Laminas\HttpHandlerRunner\RequestHandlerRunner->run()
#50 /path_to_site/index.php(26): Flarum\Http\Server->listen()
#51 {main}

askvortsov

Bishwas-py On beta 16?

cos003

Bishwas-py the same issue

Bishwas-py

askvortsov Yupp!

askvortsov

Bishwas-py there's issues with approval sometimes. Try disabling approval. This is fixed for 1.0

Arnold

askvortsov Try disabling approval

Dumb question 😅 How to do that? I tried to find this option but I couldn't.

cos003

askvortsov yes, can fix the "The requested resource was not found." problem now by disable "approval"

« Previous Page Next Page »