FriendsOfFlarum Byōbu, well integrated, advanced private discussions

IanM

peopleinside FriendsOfFlarum/byobu08cb15e

Since private discussions no longer have tags, the edit tag modal was removed from them

JRay

@IanM I'm seeing a bug when trying to create a new discussion and add additional members:

DEBUG:

`GET https://golfbuzz.com/api/users

ParseError: syntax error, unexpected 'SearchState' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) in /var/www/golfbuzz.com/html/vendor/fof/byobu/src/Events/SearchingRecipient.php:18`

IanM

JRay can you post the results of php flarum info please?

IanM

peopleinside do you have v17/support installed by any chance? I found today that extension messes with the policies and stops anyone other than admins seeing private discussions…

peopleinside

IanM No

Flarum core 1.0.2
PHP version: 7.4
Loaded extensions: Core, date, libxml, pcre, dom, fileinfo, filter, hash, json, SPL, bz2, posix, Reflection, session, SimpleXML, standard, xml, xmlreader, xmlwriter, bcmath, openssl, calendar, ctype, curl, dba, mbstring, ftp, gd, gettext, gmp, iconv, imap, intl, ldap, mailparse, exif, memcached, zlib, pcntl, PDO, pdo_sqlite, shmop, soap, sockets, sodium, sqlite3, sysvsem, sysvshm, tidy, tokenizer, xmlrpc, xsl, zip, Phar, mysqlnd, mysqli, pdo_mysql, ionCube Loader, Zend OPcache
+-------------------------------------+--------------+--------+
| Flarum Extensions                   |              |        |
+-------------------------------------+--------------+--------+
| ID                                  | Version      | Commit |
+-------------------------------------+--------------+--------+
| flarum-flags                        | v1.0.0       |        |
| flarum-approval                     | v1.0.0       |        |
| flarum-tags                         | v1.0.1       |        |
| flarum-suspend                      | v1.0.0       |        |
| flarum-markdown                     | v1.0.1       |        |
| fof-oauth                           | 1.0.0        |        |
| fof-spamblock                       | 1.0.0        |        |
| flarum-subscriptions                | v1.0.0       |        |
| clarkwinkelmann-first-post-approval | 1.0.0        |        |
| fof-byobu                           | 1.0.0-beta.4 |        |
| dem13n-topic-starter-label          | 0.1.5        |        |
| fof-share-social                    | 1.0.0        |        |
| fof-formatting                      | 1.0.0        |        |
| v17development-seo                  | v1.8.0       |        |
| askvortsov-rich-text                | v2.0.3       |        |
| ianm-synopsis                       | 1.0.0        |        |
| fof-recaptcha                       | 1.0.0        |        |
| fof-terms                           | 1.0.0        |        |
| fof-split                           | 1.0.0        |        |
| fof-nightmode                       | 1.0.0        |        |
| fof-disposable-emails               | 1.0.0        |        |
| fof-cookie-consent                  | 1.0.0        |        |
| clarkwinkelmann-emojionearea        | 1.0.0        |        |
| nearata-lang-italian                | v1.1.0       |        |
| flarum-akismet                      | v1.0.0       |        |
| flarum-pusher                       | v1.0.0       |        |
| flarum-sticky                       | v1.0.0       |        |
| flarum-statistics                   | v1.0.0       |        |
| flarum-mentions                     | v1.0.0       |        |
| flarum-lock                         | v1.0.0       |        |
| flarum-likes                        | v1.0.0       |        |
| flarum-lang-english                 | v1.0.0       |        |
| flarum-emoji                        | v1.0.0       |        |
| flarum-bbcode                       | v1.0.0       |        |
| fof-default-user-preferences        | 1.0.0        |        |
| fof-links                           | 1.0.0        |        |
| fof-moderator-notes                 | 1.0.0        |        |
| fof-stopforumspam                   | 1.0.0        |        |
| fof-user-bio                        | 1.0.0        |        |
| fof-username-request                | 1.0.0        |        |
| fof-drafts                          | 1.0.0        |        |
| noriods-auto-more                   | v1.0.0       |        |
| fof-linguist                        | 1.0.0        |        |
| fof-follow-tags                     | 1.0.0        |        |
+-------------------------------------+--------------+--------+
Base URL: https://community.marcoborla.it

The issue is with users group.
If I create a manual group than send message to this all user of this group are emailed and can see the private message.

As you can see I'm doing tests

Ok that tags cannot be edited but private message should be not appear in all discussions!

The private message sent to users group is not sent by email and not showed to users.

JRay

IanM can you post the results of php flarum info please?

IanM

JRay I have a feeling it's your forum's cache not cleared properly

Please try:

composer require fof/byobu:^1.0.0-beta.4
php flarum cache:clear
php flarum assets:publish

djemyjenab

JRay hi Sir may I know what is your hosting specs? And concurrent user?

JRay

IanM I have a feeling it's your forum's cache not cleared properly

Please try:

Tried that and still getting the error.

I'm able to create new private discussion via the user 3-dot menu no problem. But unable to add users via the Add recipients modal.

IanM

JRay this is very odd.

Are you doing this as a regular user, or admin, mod, etc?

JRay

IanM Are you doing this as a regular user, or admin, mod, etc?

I am an admin. But my users are reporting the same issue.

You are welcome to create an account on the site (https://golfbuzz.com/) and PM me there (screename: jrock)

IanM

JRay I'm just going to try a couple of things, but yes, I'll give that a shot as well.. I'll report back when I know some more.

[deleted] Thanks for that. Fixed locally, I'll include in the next release (probably in an hour or two)

IanM

JRay Ok, on your site I can see the issue. It resulted in a 500 error, which means further information is likely in your logfiles. Can you please take a look and share any relevant information?

[deleted]

@IanM one small issue I have noticed is that if you open a new Private Discussion, close it, then try to open another, the below appears in the console

Uncaught (in promise) TypeError: Cannot read property 'toArray' of undefined
    at e.n.data (PrivateDiscussionComposer.js:36)
    at t.app.initializers.add.st.a.changed (index.js:44)
    at t.<anonymous> (index.js:197)
    at t.forEach.t.<computed> [as preventExit] (extend.js:78)
    at t.e.load (ComposerState.js:49)
    at t.forEach.t.<computed> [as load] (extend.js:33)
    at PrivateComposing.js:24
    at new Promise (<anonymous>)
    at t.s.action (PrivateComposing.js:14)
    at $.handleEvent (render.js:888)

IanM

1.0.0-beta.5

Fix PHP 7.3 incompatability (JRay )
Fix console errors after open/close/open the PrivateDiscussionComposer ([deleted] )

Keep up the great work of letting me know of any issues @JRay @[deleted] 👌
I'm still looking into your issue of sending to the Members group peopleinside

Installation

composer require fof/byobu:^1.0.0-beta.5
php flarum cache:clear

[deleted]

IanM Cool. Thanks

IanM

peopleinside Ok that tags cannot be edited but private message should be not appear in all discussions!

It is by design that private messages that the logged in user has access to are included in all discussions. The nature of byobu is that it's simply a normal discussion that is private.

peopleinside The private message sent to users group is not sent by email and not showed to users.

I'm investigating this at the moment. Stand by..

JRay

IanM Ok, on your site I can see the issue. It resulted in a 500 error, which means further information is likely in your logfiles. Can you please take a look and share any relevant information?

I see a few instances of the same error message:
[2021-06-08 17:28:28] flarum.ERROR: ParseError: syntax error, unexpected 'SearchState' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) in /var/www/golfbuzz.com/html/vendor/fof/byobu/src/Events/SearchingRecipient.php:18

Here's today's log file: https://golfbuzz.com/flarum-2021-06-08.log

peopleinside

IanM temporally where i can comment, edit code to be able to post a private message without 1 recipient required?

IanM

peopleinside I would love to see private discussions not listed in all discussion but currently there is no option that allow this.

This is not a feature of byobu, as I said here IanM - if a discussion is visible to the user, then it will always be included in 'All discussions'.

peopleinside Currently I cannot have a sticky private message visible to all members

Think about this for a moment. A private message to all members is then by nature not a private message. This is why I asked you to help me understand what your end goal is IanM so I might be able to offer a better way to achieve what you're asking.

luceos

Walys But some questions

have any date to go with stable version? Maybe some days, weeks, months....

No. @IanM and I want to make sure everything works as intended before tagging a stable version. We haven't entirely resolved all performance issues.

have any future idea to implement this extension to flarum core @luceos ? Or go with other system in the future for private message? I am little scared about install this in my community and then flarum core go with other private system.

It is extremely unlikely the flarum core team will build another private messaging extension. I think that outlook/promise needs to be changed.

have the possibility in the admin panel a option to avoid the private message are listed in "all discussion" and only view when you go to private discussion tag?

There is no private discussion tag. And whether we will split private discussions, read

IanM It is by design that private messages that the logged in user has access to are included in all discussions. The nature of byobu is that it's simply a normal discussion that is private.

luceos

IanM Fix PHP 7.3 incompatability (JRay )

I cannot get this out of my system. I need php 7.4 typehinting please 🙏

JRay

IanM 1.0.0-beta.5

That fixed my issue. Thanks @IanM you rock!

IanM

luceos PHP 8 for all 😉

rafaucau

The search icon is in the wrong place

« Previous Page Next Page »