Flagrow Ads, bombarding your users with ads everywhere, if you want..

matteocontrini

YusufYldrm if you use AdSense, make sure you removed this line from your ad slots code:

<script>(adsbygoogle = window.adsbygoogle || []).push({});</script>

AdSense doesn't behave nicely if you execute that more than you should.

MikeJones

matteocontrini assuming that this is why the upgrade didn't fix my issues before?

qurse

luceos This extension is very important for those who use adsense in production. So I believe this plugin needs to be updated quickly. It should be updated and moved to FOF as soon as possible.

luceos

qurse I understand. And it is updated. If you're that concerned about this (and other 3rd party) extension being updated I suggest support our cause by backing Friends of Flarum on Open Collective 😉

matteocontrini

Honestly I'm not sure the last update improved the situation. I'm seeing a lot of blank slots after updating, something I never noticed before. It seems that the push() thing for AdSense isn't actually called when it should.

Looking at the source it seems that the HTML code for the slot is left untouched, so the ad slot isn't actually loaded.

I think I'm going to downgrade to the previous version if this keeps happening...

MikeJones

matteocontrini @Kyrne would the troubleshooting you did last night with me fix this?

Kyrne

matteocontrini Looking at your site, you have

<script>(adsbygoogle=window.adsbygoogle||[]).pauseAdRequests=1</script> in your head tag.

Which would prevent ads from showing. I'm guessing is an attempt to comply with GDPR, but I don't think you have fully implemented it properly.

Try removing that from your head tag, if ads start working again, I can help you with a full script to comply with GDPR and still have ads working.

matteocontrini

Kyrne I also have (adsbygoogle=window.adsbygoogle||[]).pauseAdRequests=0; for enabling ads after the consent, that's not a problem. Also, some ad slots load and some not, in the same page

Kyrne

matteocontrini I believe that line isn't being calling, I executed that script via console on your site and the ads loaded immediately.

Edit: here's a video:

matteocontrini

Kyrne yes but that's normal, that line is not called until you dismiss the banner about cookies, and in the video the banner has not been dismissed. I added some console logging so it's easier to see when things happen.

Not sure about why that exception happens though, it's weird that AdSense doesn't handle well its own feature for pausing ads...

EDIT: maybe it's unrelated to the "pause ads" feature and it's actually another issue.

Thanks for your time anyway 🙂

Littlegolden

luceos So this line needs to be removed in the ad slot code? Yes.

After removing this code, the sidebar ads on the homepage are not displayed, but the in-stream ads in discussions are displayed.

Kyrne and I did this, not works.

YusufYldrm

clarkwinkelmann 0.2.2 (latest version) After adding adsense ad code, the "New discussion" button stopped working. The admin panel tab did not open on the homepage. He suggested that I remove matteocontrini <script> (adsbygoogle = window.adsbygoogle || []).push({});</script> from adsense code to resolve this issue. But when I did, the ads didn't run. So I wanted to go back to version 0.2.0.

Should I run composer require vendor/ads0.2.0 to return 0.2.0?

YusufYldrm

Flagrow ads plugin currently used version 0.2.2. How do I revert to version 0.2.0?

clarkwinkelmann

YusufYldrm you can require a specific version with composer require vendor/package:x.y.z where vendor/package is the package name and x.y.z is the version you want. A require command without any version (or a different rule) will be required to update in the future.

Though rolling back shouldn't be necessary unless there's a critical unexpected issue in the latest patch release. Why do you need to go back to 0.2.0 ?

clarkwinkelmann

YusufYldrm composer require flagrow/ads:0.2.0 should do it.

YusufYldrm

clarkwinkelmann Thank you very much Clark. I will make a financial contribution to FOF to update the ADS plugin in a short time.

Edit: unfortunately, returning to this version could not solve my problems.

YusufYldrm

Kyrne I read all the messages to solve the problem. I see that https://www.huddleberry.com has the same problem. Go to this site, click on any discussion. then back to the homepage. The address bar will still have the URL of the discussion you clicked !. Similarly, the new discussion button does not work on this site.

So I went back to version 0.2.0-beta.1 with clarkwinkelmann However, because version 0.2.2 reloads ads during page changes, I would like to upgrade to this version if the issue is resolved.

luceos

YusufYldrm do you see any errors in your browser console?

YusufYldrm

luceos Yeah. screenshot in the link below.

http://prntscr.com/oe4agb

http://prntscr.com/oe4bg8

Kyrne

YusufYldrm Can you provide a link to your forum? Several people I've talked to 0.2.2 works fine for them so I'd like to see what the individual issue is on your forum

matteocontrini

FWIW, personally I'm downgrading to 0.2.0-beta.1. I never had issues with that version in the past 2 years (not much has changed since mid-2017), and AdSense was working perfectly. With the new update I'm seeing some ad slots not being loaded and other issues like this one. So for now I'm happy with the old version 🙂

YusufYldrm

Hi Kyrne . flagrow / ads 0.2.2 is currently installed. I pasted the adsense code exactly under the header. I also pasted adsense code into under tags. The problem arises when you paste the code into six ad slots, but it works fine when you remove <script> (adsbygoogle = window.adsbygoogle || []). Push ({}); </script>. Go site

Edit: With this configuration, the "New Discussion" button and the drop-down menu next to it do not work in the mobile version.

Labels six ads aren't showing on page changes. Need to refresh the home page to appear

« Previous Page Next Page »