Emoji Picker

clarkwinkelmann

Thanks for the support ? !

Both popups work fine together for me on Firefox.

tankerkiller125 What browser are you using ? Is there an error in the console ?

tankerkiller125

clarkwinkelmann Google Chrome. Doesn't seem to be any error. And seems to work on the mobile version of chrome. It may have just been Cloudflare messing with things. I'll double check in the morning.

tankerkiller125

clarkwinkelmann It looks like Cloudflare and my browser did some weird caching. The plugin works exactly as it should! Thank you so much, the people on my forum LOVE emojis and this will help them tremendously. ?

wignu

Excellent extension thanks very much @clarkwinkelmann, can confirm able to type colon and name of emoji as well ... using Firefox too.

itsjtaM

this looks good! wonderful work clarkwinkelmann

jordanjay29

tankerkiller125 Cloudflare messes with everything, that's a pretty sound bet for your culprit.

clarkwinkelmann

I'm also running a Flarum instance behind Cloudflare, no issue with my extension so far. But I need to wait for tomorrow users to come by and break everything ?

BlackSheep

Thank you !

Edit : Does not work for me, got an error when activating the extension :

POST https://xxx.xxx/api/extensions/clarkwinkelmann-emojionearea

Internal Server Error

And it crashes the whole forum.

clarkwinkelmann

BlackSheep do you have some debug information to give me ? I have no way to reproduce that ?

What is the internal server error message in Flarum log ? Do you have other third-party extensions ? Did you try in debug mode ?

Install went well for me, on DevFlarum and apparently for a few other people as well, so I think it has something to do with your particular configuration/environment ?

meetdilip

It works as in Discord, right ? Nice addition :thumbup_tone1:

BlackSheep

clarkwinkelmann I had debug mode launched, and it's all their was in the flarum debug message.

I launched a composer update, reinstalled the extension, got the same error message but this time it seems to work. That's a first.

Nginx got a bit mad :

PHP message: PHP Deprecated:  Usage of error middleware is deprecated as of 1.3.0, and will be removed in
2.0.0; please see https://docs.zendframework.com/zend-stratigility/migration/to-v2/ for details on how to update
your application to remove this message. in /var/www/xxx.xxx.xxx/vendor/zendframework/zend-stratigility/src/Next.php on line 435" while reading response header from upstream, client: xx.xx.xx.xx, server:
xxx.xxx.xxx, request: "POST /api/extensions/clarkwinkelmann-emojionearea HTTP/1.1", upstream:
"fastcgi://unix:/run/php/php7.0-fpm.sock:", host: "xxx.xxx.xxx", referrer: "https://xxx.xxx.xxx/admin"

clarkwinkelmann

BlackSheep That error message does not seem related to my extension ?

Did you call that api enpoint directly ? Or does it come from the admin GUI ? I can't get to see the API calls in admin with Firefox Debug Tools as it refreshes the page immediately...

Glad if it works now. Let met know if you encounter other problems !

BlackSheep

clarkwinkelmann That error message does not seem related to my extension

Read a bit closer the error message request: "POST /api/extensions/clarkwinkelmann-emojionearea HTTP/1.1", it's linked.

clarkwinkelmann Did you call that api enpoint directly ?

clarkwinkelmann Or does it come from the admin GUI ?

Yes.

clarkwinkelmann

BlackSheep Okay I managed to see the request in Chrome. It always works and returns a 200 HTTP status code.

Given I don't use any Zend method or middleware directly (the PHP is dead-simple for my plugin !) I suppose this is caused by the core code that enable extensions.

I just noticed it's not the first time I see that error message. It has something to do with Flarum in general. It's being discussed here https://discuss.flarum.org/d/4218-zend-stratigility-debug-message-after-composer-update and I see a few issues on GitHub https://github.com/flarum/core/search?q=zendframework%2Fzend-stratigility&type=Issues&utf8=%E2%9C%93

In the above topic it is said this can be left as-it. The fix in the composer file is also somewhat simple.

You probably also face this issue when enabling other extension ? We can continue the discussion on that linked topic I believe.

BlackSheep

clarkwinkelmann I see what's all about, i did this installation a while ago and the fix for this problem was not done for this installation, my bad ! It works well ?

tankerkiller125

clarkwinkelmann I can confirm that the middleware thing is a flarum/core issue and not one related to any extensions.

weazy

Problems with mobile...

image screenshot-from-2017-01-31-23-32-19png.png

jordanjay29

weazy Yep, tried it on my phone and got the same:

emoji picker on mobile is cut off

clarkwinkelmann

weazy jordanjay29 yeah I didn't really test on mobile, and the Emojione Area does not check if the popup goes out of the screen ?

I think I'll just change the popup settings to display it on the right instead of left.

The problem could always happen on the other side in small screens or if there are many buttons... I'll see what I can do.

Added as #3, I'll have a look as soon as possible.

hcarpach

clarkwinkelmann awesome! Much needed extension. Do you take bitcoin donations?

clarkwinkelmann

0E800 yes that's what I will do (soon !)

hcarpach I'm sure other extensions deserve a lot more support, mine is just a wrapper around another OSS library ?

I do have a Paypal account. I really should look into bitcoins ?