Use migrations to update database

TitusPiJean

I have added a new column to the users table for identification purposes with an extension. The extension checks only this column to authenticate its users.
Is it possible to set an other migration so that the first admin (id=1) can log in through the extension ?

I have tried something with the following code, but nothing happens. (And I don't even see errors in logs)

File : migrations/2017_02_16_000000_enable_ssowat_admin_login.php

<?php

use Flarum\Core\User;

return [
   'up' => function () {
      $query = User::where('id', 1);
      $query->update(['ssowat_id' => $query->username ]);;
   },
   'down' => function () {
      $query = User::where('id', 1);
      $query->update(['ssowat_id' => NULL ]);
   }
];

clarkwinkelmann

Do you mean you completely override the login logic and the admin is locked out of his own forum when enabling the extension ?

The admin is probably still logged in after the extension was enabled ? You should be able to listen for an Event at this moment and whitlelist/enable the current user or all admins.

By the way I'm not very confident with the hard-coded 1. On my forum I imported a bunch of users manually and the first has an id of 3. There's a good chance the first user is an admin, but that's still very dangerous...

TitusPiJean

clarkwinkelmann, luceos

Thank you for your answers. I indeed added the option to only use the extension, overriding the Flarum login. And obviously it will lead to a lockedout admin.

The hard coded id=1 should not be an issue, as the extension is intended to be automatically installed during a packaged installation of Flarum in Yunohost (which has its own SSO system, SSOwat). I concur that there may be more elegant ways to do so.

Actually there is a hook system on Yunohost that I can use. I should create an API route to populate the users table with the host's user.

luceos

First off:

      $query = User::where('id', 1);

This starts a Query Builder instance. To get the object you're looking for use:

      $query = User::where('id', 1)->firstOrFail();

Now you need the username to update to the id:

User::where('id', 1)->update(['ssowat_id', => $query->username]);

Second, never use Models within migrations. Rather use raw queries, eg:

\DB::table('users')->findOrFail(1);

Not sure whether DB is accessible here though ?

Now that we covered that, I'm not understanding what you're trying to achieve. I guess there will be a simpler solution than what you try to do here.

TitusPiJean

luceos It seems I cannot really alter the users table : I get a MassAssignmentException when I call the update() because the ssowat_id column is not set as fillable.

clarkwinkelmann

TitusPiJean What about using two extension: one for your custom SSO login, one to disable the default login.

So You can disable default login only when you're ready with configuring the SSO for your existing users.

EDIT: Or make the "default login block" a flag option inside your first extension. Upon extension install, you can listen for an event, set admin SSO link, and change the flag. Only then is the default login disabled.

TitusPiJean

clarkwinkelmann

I like what you suggest in your Edit. I have added the following code inside addAssets($event), but I cannot find a way to determine the current admin's username ! I want to put something like $event->request->getAttribute('session')['user_id']instead of the ..., but I get an error stating that $event->request is null.

$user = User::where('id', ...)->firstOrFail();
   if ($user->username  != $user->ssowat_id) {
   $user->update(['ssowat_id', $user->username]);
}

clarkwinkelmann

TitusPiJean I think you have to use $event->request->getAttribute('actor') to get the current user. But not sure what type of object is returned exactly ?

TitusPiJean

Ah ! ? Beta 6's ConfigureWebApp event is not as talkative as I expected. It only has $controller and $view properties, and their subsequent properties are protected. According to the last branch next version will provide the $request, but meanwhile I think I'm stuck.