Sweet Alert

BlackSheep

It's intrusive.

clarkwinkelmann

Xintium it should actually be quite simple.

You just need to monkey patch the preventExit() method on the Composer component (source here) with the Sweet Alert code.

BlackSheep both are very intrusive I think. A good idea would be a cancel "go back" button like when you just deleted a draft in GMail.

Xintium

clarkwinkelmann Thanks for your reply.

0E800 If you start writing a reply and then press the little x in the right hand corner the pop up will appear.

wignu

Looks a stack load nicer than the standard Java alerts, seems quite easy to customise as well.

@BlackSheep Eeeermmmm, isn't the point of an alert to be intrusive so it's seen??? ?

0E800

Sweet alert looks nice. I see it in alot of android apps and ecommerce sites. I'm still trying to find the java popup your talking about on flarum. I am unable to reproduce.

Davis

The standard alert()s are actually in the process of being removed in favor for models.

datitisev

If we do decide to use SweetAlert, which I doubt, I think SweetAlert2 would be a better choice.
Don't get me wrong, I like SweetAlert, but the choices for personalization and customization are minimal.

thunder

I quite like this, would be much better.

0E800

Bump. Trying to get this to work. Thought it would be simple enough to just replace all
alert(bla bla bla) with swal(bla bla bla)

When I search for the messages, this is what is calling them:

"core.forum.composer_reply.discard_confirmation":"You have not posted your reply. Do you wish to discard it?",

Not sure how to proceed, any help would be appreciated.

Ralkage

0E800 Are you extending it or are you directly adding this to your install?

Extending it would be the smart choice as any new Flarum updates will likely break your code.

clarkwinkelmann

0E800 I don't understand your issue. Do you get this string as an error ?

From what I understand, https://github.com/flarum/core/blob/master/js/forum/src/components/ComposerBody.js#L83 returns false if everything is okay and a confirmation message if something is not saved

And https://github.com/flarum/core/blob/master/js/forum/src/components/Composer.js#L260 takes care of displaying the popup with the confirmation message received. You only need to change this part.

0E800

Ralkage

I just want to get it to work. Not worried about updating yet.

Kyrne

Is there still demand for this?

Frink

Kyrne it would be sweet!

Ralkage

Frink -Ba Dum Tss!-

Eldenroot

SHC

Has anyone tried it on mobiles with small resolutions?

Frink

SHC It appears to be mobile-friendly, I just tested it