Markdown Editor Ext

luceos

ganuonglachanh I highly recommend not suggesting to use dev-master. Especially because it seems you already tagged some versions (at 0.8 now).

Great job btw ?

ganuonglachanh

luceos

Thank you, can you show me how to get packagist load my latest release, I release 0.9 version but packagist don't update (I already trigger by API in GitHub). That why I use dev-master

luceos

ganuonglachanh there should be a manual update button on packagist to force it to read the latest information. Please note tagging a version from within Github, most likely is not picked up by Github. You'd better use git directly.

ganuonglachanh

luceos

I did tried the manual update button on Packagist but no help. Maybe it takes time.

Thanks for your help!

luceos

ganuonglachanh try tagging the version using git:

git tag 0.9.0
git push --tags

If your packagist service is set up correctly on Github, packagist should pick it up soon. I have experienced the same issues in the past while tagging versions from within the Github interface.

Zeokat

A suggestion after watch the image posted: the text formatting buttons will fit better with a proper left margin. The bold button is too near to the avatar image in my opinion.

ganuonglachanh

Foxxy

This is extension is only help user with the built in markdown, not to create an new Text Editor, so sorry I can't do it right now ?

Zeokat

This will be done soon, thanks for your suggestion!

Foxxy

Awesome! What if you did this, but with medium style controls. Here is an example.

Foxxy

ganuonglachanh That's not what I meant. When you highlight text, you get a contextual menu. Go to the example above and highlight text, you'll see what I mean.

SierraKiloGulf

Underline function actually makes things bold. Aside from that everything appears to be working well. Really love how you styled it compared to the other Markup Editor. Have already uninstalled the other one

ganuonglachanh

SierraKiloGulf

Thanks for your report, since Flarum Markdown does not have syntax for underline, I changed the underline by bbcode

Zeokat

ganuonglachanh

Are you sure that Flarum markdown don't have syntax for underline...

Edit: no, it dont have ? .

KlebersonRomero

Great! Extension tnks for dev.

CodePoet

good!

BoQsc

After installation on the latest Flarum I've got an error "Something went wrong while trying to load the full version of this site." http://i.cubeupload.com/WSFwEu.png

It appears after extension's activation. I wonder how we could trace the problem.

luceos

BoQsc enable debug in your config.php by setting false to true behind debug. And/or check the logs in storage/logs/flarum.log.

ganuonglachanh

BoQsc

It is fine, just clear flarum and web browser cache ?

BoQsc

ganuonglachanh Strange, after few hours - I turned on the server and it works perfectly.

However, I have a suggestion for you: Could you make that in the future: after marking the text, the second press on the same button would remove the markup around?

The reason I'm asking this: http://i.cubeupload.com/8fdWiY.png
It is useless to make double or triple markup on the same text.
(second and more press just keep adding the asterisks - instead make it remove already existing markup)

That would be great!

Witype

there is not chinese translate，but how can I add custom？

ChristianFrankenstein

I added line breaks to correct the code box.

/vendor/ganuonglachanh/flarum-ext-markdown-editor/js/forum/dist/extension.js
Line 337

this.insertAroundCursor('```', '```');

changed to

this.insertAroundCursor('```\n', '\n```');

To align the buttons correctly

.EnhancedTextEditor-toolbar {
    margin-left: -20px;
}