s9e/mediaembed - Embed videos and third-party content

UaMV

JoshyPHP Is this true even if we've not setup custom DNS for the Google Apps domain? Currently the only difference in URL structure for files is the short string a/example.com/ within the URL:

Google Personal Drive: https://drive.google.com/file/d/0B1jm0-bNxljBlazA/view?usp=sharing
Google Apps Drive: https://drive.google.com/a/example.com/file/d/0BwaYOzQlU/view?usp=sharing

Might the regex be modified to catch this match if it exists?

JoshyPHP

UaMV Might the regex be modified to catch this match if it exists?

Yes, sure. If they're on drive.google.com then it's not hard to support those links. I'm going to add support for them in s9e\TextFormatter v0.5.4.

JoshyPHP

jeanim The regexp is missing a delimiter at the end.

JoshyPHP

Try posting a link in a new post. It works for me in isolation, outside of Flarum.

blurkness

@JoshyPHP

I don't know if this is a issue or not, but i can't change the template. Am i doing it wrong?

http://s9etextformatter.readthedocs.io/Plugins/MediaEmbed/Change_template/

<?php
use Flarum\Event\ConfigureFormatter;
use Illuminate\Events\Dispatcher;

return function (Dispatcher $events)
{
	$events->listen(
		ConfigureFormatter::class,
		function (ConfigureFormatter $event)
		{
			$tag = $event->configurator->MediaEmbed->add('youtube');
			$tag->template = '<div class="videowrapper" style="border:1px solid #000;">' . $tag->template . '</div>';
		}
	);
};

I have another "problem" too, just the comments of the reddit threads are working. According to the doc threads should work.

Btw thanks for the extension! Amazing work!

JoshyPHP

blurkness Before I address your questions, why do you want to add your own wrapper on YouTube videos? You can already style them in CSS:

[data-s9e-mediaembed="youtube"] { border: 1px solid #000; }

I don't know why your modification doesn't work but I guess it's possible it is executed before the s9e/mediaembed extension is, which would overwrite it. What you should do is this: look into the event system to make sure yours is executed after the media embed tags are created. And don't use add() to get the tag, use $configurator->tags['youtube'].

About Reddit threads, it depends on the version of the library currently installed. The latest released Flarum is limited to 0.4.11 and Reddit threads were added in a 0.5.x version.

blurkness

JoshyPHP Thanks!

I don't know if this could help you with the mediaembed, but i'm using this CSS to take a embed responsive without limiting the width. Unfortunately doesn't work well with gfycat and webm in general, but with videos is superb. ?

float: none;
clear: both;
width: 100%;
position: relative;
padding-bottom: 56.25%;
padding-top: 25px;
height: 0;

I'll give a try with the suggestions, including trying to change just the CSS.

Thanks again ❗ ?

JoshyPHP

blurkness The markup already uses something similar to scale responsively. The width is limited to 640px by default (or in some cases, 800-900px) because otherwise videos could take the whole screen on a fluid layout and it would be slow and cumbersome.

You can replace that limit with CSS too. You'll need the !important keyword because the limit is hardcoded in the markup.

[data-s9e-mediaembed] { max-width: 100% !important; }

blurkness

JoshyPHP Just the css worked like a charm. Thanks Joshy!

forres

JoshyPHP I just add code in bootstrap.php

function subscribe(Dispatcher $events)
{
	$events->listen(
		ConfigureFormatter::class,
		function (ConfigureFormatter $event)
		{		
			$event->configurator->MediaEmbed->add(
				'tvguide',
					[
						'host'   => 'tvguide.com',
						'scrape' => ['extract' => '#"embed":".*?/embed\\/(?<id>[-\w]+)#'],
						'iframe' => [
							'width'  => 640,
							'height' => 360,
							'src'    => '//www.tvguide.com/videos/embed/{@id}/'
						]
					]
			);
		}
	);
};

but noting happened, where am i wrong

JoshyPHP

forres I don't know. It could be that your server cannot retrieve the page.

Or maybe you need to replace this line:

'scrape' => ['extract' => '#"embed":".*?/embed\\/(?<id>[-\w]+)#'],

With that line:

'scrape' => ['extract' => '#"embed":".*?/embed\\\\?/(?<id>[-\w]+)#'],

forres

JoshyPHP It doesnt work.I even add some other video config links,but no one work.I guess that these code not running, but the default link is ok such as youtube,youku.

rnovino

Is it possible to embed Google Playstore app ? ?

JoshyPHP

rnovino Probably not, I don't see anything resembling that on their site.

Duncan I think it already embeds most of Imgur links.

Duncan

I'd definitely like to see an Imgur direct link (or normal link) turn into the image to save people using markdown to show images on the forum.

Think it's possible?

rnovino

JoshyPHP not sure if it's possible for flarum but we used the playboard widget on our site you will see the install app at the end

Duncan

JoshyPHP Hmm, I did the "direct link" and it didn't embed

It would be http://i.imgur.com/blahblah.jpg

JoshyPHP

Duncan If you want to replace direct links to images (from Imgur or wherever, as long as it ends with .jpg, .png, etc...) install the AutoImage extension:

composer require s9e/flarum-ext-autoimage

Duncan

JoshyPHP You're a beautiful person.

Also just discovered the kickstarter auto-embed, awesome!

hassanalvi20

JoshyPHP I did the "direct link" and it didn't embed
it would be

AllysonSouzaNopSai

A bug, if the text is inside a another bbcode, the video is not loaded.

JoshyPHP

AllysonSouzaNopSai Was that BBCode [code] by any chance?

« Previous Page Next Page »