s9e/mediaembed - Embed videos and third-party content

Franz

Hey @JoshyPHP, is it possible to set a maximum height for things like Gist embeds? Well, I'm sure there is. But is there something already built-in in TextFormatter that we just have to turn on / configure?

VIRUXE

Franz I was thinking about this right now as I am on my mobile viewing the phpbb to flarum importer discussion where I have provided a gist link and it would just be too big to view.

IMO a native option would be best. A forum owner shouldn't be bothered with editing or even knowing css or searching this forum for something this "simple".

JoshyPHP

You can do it in CSS:

[data-s9e-mediaembed="gist"]
{
    max-height: 400px;
}

The latest release hides the scrollbar though. You can scroll big Gists but you won't see a scrollbar. The next release (0.5.0) will re-enable the scrollbar.

Franz

JoshyPHP Cool. I would argue that this should be part of the extension. ?

Toby

Franz I agree, 400-500px would be a good default. I think a setting is overkill – if someone really wants to change it, they can override the CSS themselves ?

JoshyPHP

You mean a default maximum height? Maybe, I guess. Do you have a number in mind?

datitisev

JoshyPHP You should probably make that a setting ?

Franz

400px looks good to me, but when I tried it, it wouldn't let me scroll (Chrome on Ubuntu) - probably due to the scrolling=no attribute. ?

Franz

VIRUXE Haha, yes, that's the one that caused me to ask this, too.

7h3ev1l

Is this in https://packagist.org/ ?

Franz

7h3ev1l Yes, it is.

7h3ev1l

I just installed it but dont want to show video from vbox7.com:
example this

i see there is iframe but nothing come ?

JoshyPHP

That's an issue with mixing HTTP and HTTPS content. I see that VBOX7 currently supports HTTPS so I'll update its URL and it should be fixed in the next release.

arjoni

Is this plugin updated for beta5?

Kulga

arjoni JoshyPHP Seems to work

JoshyPHP

I haven't. Have you tried installing it on beta 5 and does it work?

ameo

hello Joshy

Could you please add support for reverbnation:

https://www.reverbnation.com/meganmccormick/song/19823862-the-real-me

JoshyPHP

ameo I don't know about that one. I'm kind of torn because the site looks good but it's not building momentum and the embed code requires scraping because the artist's ID isn't in the URL, which slightly complicates things. I'll call it a soft no for now but if the site manages to turn it around and gets popular, ping me and I'll reconsider.

Or if you want to implement it yourself in your own extension, I can give you pointers.

meetdilip

@JoshyPHP

Does this plugin render the url to page titles as well ?

JoshyPHP

meetdilip No, it only changes links from a selection of supported sites.

meetdilip

JoshyPHP

Would be nice to have option to convert url into page titles as well. Won't be hard for you. :hoping:

« Previous Page Next Page »