s9e/mediaembed - Embed videos and third-party content

JoshyPHP

You mean a default maximum height? Maybe, I guess. Do you have a number in mind?

datitisev

JoshyPHP You should probably make that a setting ?

Franz

400px looks good to me, but when I tried it, it wouldn't let me scroll (Chrome on Ubuntu) - probably due to the scrolling=no attribute. ?

Toby

Franz I agree, 400-500px would be a good default. I think a setting is overkill – if someone really wants to change it, they can override the CSS themselves ?

VIRUXE

Franz I was thinking about this right now as I am on my mobile viewing the phpbb to flarum importer discussion where I have provided a gist link and it would just be too big to view.

IMO a native option would be best. A forum owner shouldn't be bothered with editing or even knowing css or searching this forum for something this "simple".

Franz

VIRUXE Haha, yes, that's the one that caused me to ask this, too.

7h3ev1l

Is this in https://packagist.org/ ?

Franz

7h3ev1l Yes, it is.

7h3ev1l

I just installed it but dont want to show video from vbox7.com:
example this

i see there is iframe but nothing come ?

JoshyPHP

That's an issue with mixing HTTP and HTTPS content. I see that VBOX7 currently supports HTTPS so I'll update its URL and it should be fixed in the next release.

arjoni

Is this plugin updated for beta5?

Kulga

arjoni JoshyPHP Seems to work

JoshyPHP

I haven't. Have you tried installing it on beta 5 and does it work?

ameo

hello Joshy

Could you please add support for reverbnation:

https://www.reverbnation.com/meganmccormick/song/19823862-the-real-me

JoshyPHP

ameo I don't know about that one. I'm kind of torn because the site looks good but it's not building momentum and the embed code requires scraping because the artist's ID isn't in the URL, which slightly complicates things. I'll call it a soft no for now but if the site manages to turn it around and gets popular, ping me and I'll reconsider.

Or if you want to implement it yourself in your own extension, I can give you pointers.

meetdilip

@JoshyPHP

Does this plugin render the url to page titles as well ?

JoshyPHP

meetdilip No, it only changes links from a selection of supported sites.

meetdilip

JoshyPHP

Would be nice to have option to convert url into page titles as well. Won't be hard for you. :hoping:

JoshyPHP

I wouldn't do it with this plugin. This one is dedicated to embedding content.

I'm not sure about scraping page titles. I've thought about it because it's been requested in the past but it has some security and usability issues I'm not comfortable with. It can take a long time to scrape info from remote pages, it could be used to intentionally exhaust the server's resources by keeping the request open an arbitrarily long time and it could be used as a way to reflect some attacks.

meetdilip

Ok. Thanks for explaining.

« Previous Page Next Page »