Reactions by ReFlar

Kyrne

sheldon looks really good! I actually wish that's how core looked like, so we could have reactions look like that.

sheldon

All done with CSS... (sans the lightning bolt FA icon - but there is a "bolt" in FA4 as it is)

I know some of the CSS needs fixed, the boxes are a bit off, but for the most part, it works. Hopefully I can get some time to clean it up a tad.

Kyrne

sheldon if you get it fixed up, you should post it under themes on this forum, I can't be the only one who thinks it looks good.

JRay

Kyrne I can't be the only one who thinks it looks good

I actually like how links only show on hover. It cuts down on the visual clutter and keeps you focused on the content.

However I think once reactions are added, they should always show. That's the way likes work today.

FebriTriHarmoko

DiegoPino how to fix this ?
i get same issue.
if i try give react and after refresh page.
react emoji / icon not show permanently.
and count react not show too ?

tjrgg

https://cdn.discordapp.com/attachments/294139482427490304/372265403910586368/unknown.png

Anyone else have this problem when trying to enable the extension?

RoUser74828

After edit post, display a broken reaction image.
How can I solve it?

datitisev

RoUser74828 Can you show us a screenshot? I am not able to reproduce this.

RoUser74828

Yes.

Reading: https://i62.servimg.com/u/f62/17/31/96/85/screen15.png
Edit: https://i62.servimg.com/u/f62/17/31/96/85/screen18.png
Save edit: https://i62.servimg.com/u/f62/17/31/96/85/screen16.png
Source after edit: https://i62.servimg.com/u/f62/17/31/96/85/screen17.png

datitisev

RoUser74828 Hm.. weird. I cannot seem to reproduce that error.

RoUser74828

How I can help you to reproduce and solve it?

datitisev

RoUser74828 Browser version, OS, maybe some errors in console, etc...

RoUser74828

Windows 10 x64 last version
No errors in console
Google Chrome 62.0.3202.94

datitisev

RoUser74828 Hm, I tested it yesterday on macOS High Sierra with Google Chrome 63.0.3239.30 (Official Build) beta (64-bit). I tried again today, but for some reason my installation decided to break itself... no clue what's happening.
I'll try and see if I can reproduce it as soon as I can.

RoUser74828

Can I give you TeamViewer or something like to see error?
Or create an account to my website: https://www.unturnedromania.tk/

Ralkage

@RoUser74828 I cannot reproduce this on ReFlar's test forum.

Please try clearing your Flarum cache via php flarum cache:clear in the root of your Flarum install via SSH.

Please also list the results from php flarum info.

There might be a conflicting extension.

Ralkage

Erm, seems as if the conflicting extension is clarkwinkelmann/flarum-ext-emojionearea. You will have to disable one or the other until we can further investigate why this issue is occurring.

@clarkwinkelmann do you know why your emojiarea extension would cause strange behavior such as @RoUser74828 described?

I am able to reproduce his issue as soon as I enabled your emojionearea extension and modify a reaction selection in any thread I've created or replied to.

EDIT: This seems to only occur when both extensions are enabled and the reply modal is in view as so:

ReFlar Reactions Test

clarkwinkelmann

Ralkage I don't have time to investigate right now. So you say my emoji extension breaks reactions when the composer is open ? I'll try to have a look.

The flarum-ext-emojionearea is mainly a big jQuery plugin so this might have some unintentional side effects.

What happens to the broken image ? Does its src change or what ?

RoUser74828

clarkwinkelmann What happens to the broken image ? Does its src change or what ?

Yes

Edit: after disable of clarkwinkelmann/flarum-ext-emojionearea problem is solved.

Ralkage

clarkwinkelmann Yessir, I'll peek at it too.

Basically after the composer is open src="undefined".

Kyrne

jordanjay29 I'll look into this soon.

clarkwinkelmann @Ralkage

I am unsure why this would happen as we don't depend on your extension. I can only guess that the emojione library has something to due with it. (Possibly loading it twice from our extensions?)

« Previous Page Next Page »