Avatar via API

jenolan

I am writing SSO for my site, successfully have login/logout processing but now I am trying to upload the users avatar and it is not working

    $data = [ 'avatar' => '@' . $file . ';filename=' . basename( $file ) ];
    self::sendPostRequest( "/api/users/{$id}/avatar", $data );

As far as I can see it is correct but even with debug enabled not seeing anything logged nor an error response.

Can some one show me where I have gone off the rails.

Thanks
Larry

clarkwinkelmann

Are you sure you're sending that payload with the correct format ? I don't think JSON will work with that endpoint. What is sendPostRequest ?

A quick test on my side shows the avatar is sent as a multipart/form-data request, but I don't recognize your way of sending it ?

jenolan

Hi clarkwinkelmann with help from @luceos this is the current version which still doesn't work

static private function updateAvatar( $id, $file )
{
    $finfo = pathinfo( $file );
    $fext = $finfo['extension'];
    $path = jDI::getInstance()->get( 'Config' )['forum']['url'] . "/api/users/{$id}/avatar";
    $ch = curl_init( $path );
    curl_setopt($ch, CURLOPT_CUSTOMREQUEST, 'POST');
    curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
    curl_setopt($ch, CURLOPT_POSTFIELDS, file_get_contents( $file ) );
    curl_setopt($ch, CURLOPT_HTTPHEADER, [ 'Authorization: Token ' . jDI::getInstance()->get( 'Config' )['forum']['apiKey'] . '; userId=1',
                                                  "Content-Disposition: form-data; name=\"avatar\"; filename=\"{$file}\"",
                                                  "Content-Type: image/{$fext}" ] );
    if( ! $result = curl_exec( $ch ) )
    {
        throw new \Exception( "curl error: " . curl_error( $ch ) );
    }
    curl_close( $ch );
    jDI::getInstance()->get( 'Log' )->debug( "Updated Avatar user({$id}) {$file}" );
}

obviously some of that is from my settings/config

clarkwinkelmann

jenolan no idea what it could be then...

Maybe it would be easier with Guzzle ? http://docs.guzzlephp.org/en/stable/request-options.html#multipart

Scumi

Same issue for me. Tried my own code and two others. If i have a look at dd($ch) right before sending the request, its basically empty apart from the correct api_url.

clarkwinkelmann

Looking back at this, I'm pretty sure the headers aren't correct. For once, Content-Type should contain multipart/form-data, not image/something. But then not sure how curl sends the boundaries of attached files.

Maybe this helps https://stackoverflow.com/questions/34604602/multipart-form-file-upload-post-php-curl ?

If you can use Guzzle, it's all coded for you already, so I strongly suggest using that library if you can.

Scumi

For anyone still interested, avatar upload works like a charm with Guzzle. Unfortunately, the /users/{id}/avatar endpoint does not seem to be available in flagrow/flarum-api-client.

$guzzle_client->request(
    'POST', 
    $this->url . '/api/users/' . $id . '/avatar',
    [
        'multipart' => [
            [
                 'name' => 'avatar',
                 'contents' => fopen('/path/to/file', 'r')
            ]
        ]
    ]
);

wolfman

Don't know if it's new in beta.13 but i had to add a filename to the multipart-array for it to work!

$response = $api->request(
    'POST',
    'users/' . $userId . '/avatar',
    [
        'multipart' => [
            [
                'name' => 'avatar',
                'contents' => fopen('/tmp/avatarmigration', 'r'),
                'filename' => 'avatar-migrated-from-smf.png'
            ]
        ]
    ]
);