[deleted] to confirm. This error occurs when installed and disabled?
luceos Yes, as fof/pretty-mail replaces the Flarum Notificationmailer with its own (./vendor/fof/pretty-mail/src/Overrides/Notification/NotificationMailer.php).
luceos yes, confirmed
composer update fof/pretty-mail
datitisev Awesome! I must take note about this way of extending core classes, can be very handy !
datitisev I discovered some bugs in the latest version. I made a PR with fixes.
iPurpl3x Only works when the class is being resolved through Laravel (__construct and/or made with app()->make()), so it's not a global solution, but yeah 🙂. @luceos suggested it, I also use it in fof/sentry for the user feedback.
iPurpl3x 😠 Thanks 😛
Just updated and encountered this error seen here:
VanillaScent You're not on 0.1.3, you are on 0.1.2 or below (I can see some code that is used in the views I removed). Run composer require fof/pretty-mail to update.
composer require fof/pretty-mail
datitisev I enabled this plugin and I am now seeing the following error: https://sentry.kilgoretech.com/share/issue/7d89bab0304240ed8de900fc2810777e/ when I attempt to update my email address on my account. I'm using Beta 10 and I have the latest version of this extension. Any ideas?
tankerkiller125 VanillaScent iPurpl3x Ok, I apologize. Thanks for the reports, I will try to fix this later today.
Just checked using flarum info, it does say now I am on 0.1.3
Same error as above, using smtp
VanillaScent @datitisev I have the same error. It happens when emails settings are on "stmp". Not when they are on "log".
I get the same error using "mail" driver.
Did you have time to check this issue? Or did I miss a new version?
If you edit the default template, does it also change the First regestration mail?
Thx in advance Likqez
Likqez I think it doesn't because the Flarum\User\AccountActivationMailer didn't get an Override. This can be added as new feature I think.
Likqez iPurpl3x It should, as the extension also replaces the Mail used by Flarum to add the "prettified view " (using default template) for messages that send raw text (see https://github.com/flarum/core/blob/master/src/User/AccountActivationMailer.php#L69 and https://github.com/FriendsOfFlarum/pretty-mail/blob/master/src/Mailer.php#L26)
chrisonline sorry, haven't had the time to yet.
datitisev I fixed the bug, here is my PR