FriendsOfFlarum Pretty Mail

iPurpl3x

datitisev Awesome! I must take note about this way of extending core classes, can be very handy !

datitisev

iPurpl3x Only works when the class is being resolved through Laravel (__construct and/or made with app()->make()), so it's not a global solution, but yeah 🙂. @luceos suggested it, I also use it in fof/sentry for the user feedback.

iPurpl3x 😠 Thanks 😛

iPurpl3x

datitisev I discovered some bugs in the latest version. I made a PR with fixes.

datitisev

0.1.2

Fix some small bugs - thanks @iPurpl3x
- When the first e-mail that is sent after enabling Pretty Mail is an "EmailConfirmation" (when a user changes his email address) then the default template set up in the admin pane would not be used.
- The Notification e-mails would not replace the right file contents if a custom template was set up in the admin pane (the file path was wrong).
Minor english locale improvements - thanks @rob006

Updating

composer update fof/pretty-mail

datitisev

0.1.3

Completely rewrite some stuffs
Fix issue with migration not migrating from ReFlar (??) and instead checking for non-existent fof keys
Compile views directly from template strings rather than writing to files
Probably fixed some other issues

Updating

composer update fof/pretty-mail

VanillaScent

Just updated and encountered this error seen here:
i.imgur.com/IJGFS0P.png

datitisev

VanillaScent You're not on 0.1.3, you are on 0.1.2 or below (I can see some code that is used in the views I removed). Run composer require fof/pretty-mail to update.

tankerkiller125

datitisev I enabled this plugin and I am now seeing the following error: https://sentry.kilgoretech.com/share/issue/7d89bab0304240ed8de900fc2810777e/ when I attempt to update my email address on my account. I'm using Beta 10 and I have the latest version of this extension. Any ideas?

datitisev

tankerkiller125 VanillaScent iPurpl3x Ok, I apologize. Thanks for the reports, I will try to fix this later today.

VanillaScent

Just checked using flarum info, it does say now I am on 0.1.3
Same error as above, using smtp
new error:

iPurpl3x

VanillaScent @datitisev I have the same error. It happens when emails settings are on "stmp". Not when they are on "log".

chrisonline

datitisev
I get the same error using "mail" driver.
Did you have time to check this issue? Or did I miss a new version?

Likqez

If you edit the default template, does it also change the First regestration mail?
Thx in advance Likqez

iPurpl3x

Likqez I think it doesn't because the Flarum\User\AccountActivationMailer didn't get an Override. This can be added as new feature I think.

datitisev

Likqez iPurpl3x It should, as the extension also replaces the Mail used by Flarum to add the "prettified view " (using default template) for messages that send raw text (see https://github.com/flarum/core/blob/master/src/User/AccountActivationMailer.php#L69 and https://github.com/FriendsOfFlarum/pretty-mail/blob/master/src/Mailer.php#L26)

datitisev

chrisonline sorry, haven't had the time to yet.

iPurpl3x

datitisev I fixed the bug, here is my PR

datitisev

iPurpl3x Thanks 🙂

0.1.4

Hopefully fix from & forum title errors

Updating

composer update fof/pretty-mail

chrisonline

It works now. Thanks for the fix.

[deleted]

@datitisev
Thanks for this wonderful Flarum extension!
I was able to almost completely localize this extension, but cannot find where to edit Email subject, i.e., email about "(username) replied to your post in (discussion title)". Once again, this is email subject line.

datitisev

[deleted] One can edit that by using fof/linguist 🙂.

« Previous Page Next Page »