datitisev luceos Yes, as fof/pretty-mail replaces the Flarum Notificationmailer with its own (./vendor/fof/pretty-mail/src/Overrides/Notification/NotificationMailer.php).
datitisev 0.1.1 Do not replace Flarum files - rather, replace the classes they implement Fixes issues when the extension is installed but disabled Update email confirmation code for beta 8+, wasn't (or shouldn't have been) working Updating composer update fof/pretty-mail
iPurpl3x datitisev Awesome! I must take note about this way of extending core classes, can be very handy !
datitisev iPurpl3x Only works when the class is being resolved through Laravel (__construct and/or made with app()->make()), so it's not a global solution, but yeah 🙂. @luceos suggested it, I also use it in fof/sentry for the user feedback. iPurpl3x 😠Thanks 😛
datitisev 0.1.2 Fix some small bugs - thanks @iPurpl3x When the first e-mail that is sent after enabling Pretty Mail is an "EmailConfirmation" (when a user changes his email address) then the default template set up in the admin pane would not be used. The Notification e-mails would not replace the right file contents if a custom template was set up in the admin pane (the file path was wrong). Minor english locale improvements - thanks @rob006 Updating composer update fof/pretty-mail
datitisev 0.1.3 Completely rewrite some stuffs Fix issue with migration not migrating from ReFlar (??) and instead checking for non-existent fof keys Compile views directly from template strings rather than writing to files Probably fixed some other issues Updating composer update fof/pretty-mail
datitisev VanillaScent You're not on 0.1.3, you are on 0.1.2 or below (I can see some code that is used in the views I removed). Run composer require fof/pretty-mail to update.
tankerkiller125 datitisev I enabled this plugin and I am now seeing the following error: https://sentry.kilgoretech.com/share/issue/7d89bab0304240ed8de900fc2810777e/ when I attempt to update my email address on my account. I'm using Beta 10 and I have the latest version of this extension. Any ideas?
datitisev tankerkiller125 VanillaScent iPurpl3x Ok, I apologize. Thanks for the reports, I will try to fix this later today.
VanillaScent Just checked using flarum info, it does say now I am on 0.1.3 Same error as above, using smtp new error:
iPurpl3x VanillaScent @datitisev I have the same error. It happens when emails settings are on "stmp". Not when they are on "log".
chrisonline datitisev I get the same error using "mail" driver. Did you have time to check this issue? Or did I miss a new version?
Likqez If you edit the default template, does it also change the First regestration mail? Thx in advance Likqez
iPurpl3x Likqez I think it doesn't because the Flarum\User\AccountActivationMailer didn't get an Override. This can be added as new feature I think.
datitisev Likqez iPurpl3x It should, as the extension also replaces the Mail used by Flarum to add the "prettified view " (using default template) for messages that send raw text (see https://github.com/flarum/core/blob/master/src/User/AccountActivationMailer.php#L69 and https://github.com/FriendsOfFlarum/pretty-mail/blob/master/src/Mailer.php#L26)
datitisev iPurpl3x Thanks 🙂 0.1.4 Hopefully fix from & forum title errors Updating composer update fof/pretty-mail
