FoF Terms, ask your users to accept TOS and Privacy Policy

SMalt · Apr 23, 2020

I think the question fits in here (privacy/gdpr).
Is the only place where flarum stored the user-ip is in database posts -> ip_address?

DevanNarayanan · Apr 23, 2020

clarkwinkelmann So please provide any sources or link or steps to integrate composer in the code? I had tried with visual studio code to install composer , but failed. Is there any other way to integrate composer in this flarum code.

clarkwinkelmann · Apr 23, 2020

DevanNarayanan the installation instructions can be found in the first post of this discussion as well as in the README file. If I understand correctly it seems you have issues with Flarum and Composer, and not specific to this extension ? Could you open a new support discussion explaining how you installed Flarum and what happens when you try installing extensions with composer ?

SMalt I suggest you open a new discussion about this. This extension does not store any user IP.

IanM · May 5, 2020

0.4.2

Support Flarum beta.13

Requires minimum flarum/core beta.12

Updating

composer require fof/terms
php flarum cache:clear

DursunCan · May 14, 2020

[2020-05-14 06:53:33] production.ERROR: TypeError: Argument 3 passed to FoF\Terms\Repositories\PolicyRepository::__construct() must implement interface Illuminate\Contracts\Cache\Repository, instance of Illuminate\Cache\RedisStore given in /var/www/sourceturk/forum/vendor/fof/terms/src/Repositories/PolicyRepository.php:24
Stack trace:
#0 [internal function]: FoF\Terms\Repositories\PolicyRepository->__construct()
#1 /var/www/sourceturk/forum/vendor/illuminate/container/Container.php(812): ReflectionClass->newInstanceArgs()
#2 /var/www/sourceturk/forum/vendor/illuminate/container/Container.php(658): Illuminate\Container\Container->build()
#3 /var/www/sourceturk/forum/vendor/illuminate/container/Container.php(609): Illuminate\Container\Container->resolve()
#4 /var/www/sourceturk/forum/vendor/flarum/core/src/Foundation/Application.php(521): Illuminate\Container\Container->make()
#5 /var/www/sourceturk/forum/vendor/flarum/core/src/helpers.php(26): Flarum\Foundation\Application->make()
#6 /var/www/sourceturk/forum/vendor/fof/terms/src/Extenders/ForumPoliciesRelationship.php(30): app()
#7 /var/www/sourceturk/forum/vendor/illuminate/events/Dispatcher.php(360): FoF\Terms\Extenders\ForumPoliciesRelationship->loadRelationship()
#8 /var/www/sourceturk/forum/vendor/illuminate/events/Dispatcher.php(209): Illuminate\Events\Dispatcher->Illuminate\Events\{closure}()
#9 /var/www/sourceturk/forum/vendor/flarum/core/src/Api/Controller/AbstractSerializeController.php(99): Illuminate\Events\Dispatcher->dispatch()
#10 /var/www/sourceturk/forum/vendor/flarum/core/src/Api/Client.php(72): Flarum\Api\Controller\AbstractSerializeController->handle()
#11 /var/www/sourceturk/forum/vendor/flarum/core/src/Frontend/Frontend.php(72): Flarum\Api\Client->send()
#12 /var/www/sourceturk/forum/vendor/flarum/core/src/Frontend/Frontend.php(51): Flarum\Frontend\Frontend->getForumDocument()
#13 /var/www/sourceturk/forum/vendor/flarum/core/src/Frontend/Controller.php(32): Flarum\Frontend\Frontend->document()
#14 /var/www/sourceturk/forum/vendor/flarum/core/src/Http/RouteHandlerFactory.php(38): Flarum\Frontend\Controller->handle()
#15 /var/www/sourceturk/forum/vendor/flarum/core/src/Http/Middleware/DispatchRoute.php(65): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}()
#16 /var/www/sourceturk/forum/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\DispatchRoute->process()
#17 /var/www/sourceturk/forum/vendor/flarum/core/src/Admin/Middleware/RequireAdministrateAbility.php(26): Laminas\Stratigility\Next->handle()
#18 /var/www/sourceturk/forum/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Admin\Middleware\RequireAdministrateAbility->process()
#19 /var/www/sourceturk/forum/vendor/flarum/core/src/Http/Middleware/SetLocale.php(50): Laminas\Stratigility\Next->handle()
#20 /var/www/sourceturk/forum/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\SetLocale->process()
#21 /var/www/sourceturk/forum/vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php(37): Laminas\Stratigility\Next->handle()
#22 /var/www/sourceturk/forum/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\CheckCsrfToken->process()
#23 /var/www/sourceturk/forum/vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php(32): Laminas\Stratigility\Next->handle()
#24 /var/www/sourceturk/forum/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\AuthenticateWithSession->process()
#25 /var/www/sourceturk/forum/vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php(51): Laminas\Stratigility\Next->handle()
#26 /var/www/sourceturk/forum/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\RememberFromCookie->process()
#27 /var/www/sourceturk/forum/vendor/flarum/core/src/Http/Middleware/StartSession.php(61): Laminas\Stratigility\Next->handle()
#28 /var/www/sourceturk/forum/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\StartSession->process()
#29 /var/www/sourceturk/forum/vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php(28): Laminas\Stratigility\Next->handle()
#30 /var/www/sourceturk/forum/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\ParseJsonBody->process()
#31 /var/www/sourceturk/forum/vendor/flarum/core/src/Http/Middleware/HandleErrors.php(57): Laminas\Stratigility\Next->handle()
#32 /var/www/sourceturk/forum/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\HandleErrors->process()
#33 /var/www/sourceturk/forum/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(84): Laminas\Stratigility\Next->handle()
#34 /var/www/sourceturk/forum/vendor/middlewares/request-handler/src/RequestHandler.php(84): Laminas\Stratigility\MiddlewarePipe->process()
#35 /var/www/sourceturk/forum/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\RequestHandler->process()
#36 /var/www/sourceturk/forum/vendor/middlewares/base-path-router/src/BasePathRouter.php(97): Laminas\Stratigility\Next->handle()
#37 /var/www/sourceturk/forum/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\BasePathRouter->process()
#38 /var/www/sourceturk/forum/vendor/laminas/laminas-stratigility/src/Middleware/OriginalMessages.php(42): Laminas\Stratigility\Next->handle()
#39 /var/www/sourceturk/forum/vendor/laminas/laminas-stratigility/src/Next.php(61): Laminas\Stratigility\Middleware\OriginalMessages->process()
#40 /var/www/sourceturk/forum/vendor/middlewares/base-path/src/BasePath.php(53): Laminas\Stratigility\Next->handle()
#41 /var/www/sourceturk/forum/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\BasePath->process()
#42 /var/www/sourceturk/forum/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(84): Laminas\Stratigility\Next->handle()
#43 /var/www/sourceturk/forum/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(73): Laminas\Stratigility\MiddlewarePipe->process()
#44 /var/www/sourceturk/forum/vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(96): Laminas\Stratigility\MiddlewarePipe->handle()
#45 /var/www/sourceturk/forum/vendor/flarum/core/src/Http/Server.php(42): Laminas\HttpHandlerRunner\RequestHandlerRunner->run()
#46 /var/www/sourceturk/forum/public/index.php(22): Flarum\Http\Server->listen()
#47 {main}

this error might be related to the redis/recache ext

clarkwinkelmann · May 14, 2020

DursunCan could you open a GitHub issue and attach your php flarum info ? It will be easier to troubleshoot over there.

I can't see why it returns the Store when asking for the Repository, possibly there's a missing binding in https://github.com/Bokt/flarum-redis

Gatsu · May 15, 2020

Hi, I installed it but now I want to delete a policy create by me, I click on delete but it still here.
I tried to remove fof/terms with SSH and re-install it, but all old data are present, why?
beta13

clarkwinkelmann · May 15, 2020

Gatsu do you see any error in Flarum log file or in the browser javascript console when deleting the policy ? Is it still present after a refresh with F5 ?

To delete the extension data, you must disable the extension, then select "Uninstall" in the dropdown of the extension in Flarum admin panel. Then you can either re-enable it if you want to start fresh, or remove it with Composer to remove it definitely. The "Uninstall" button deletes the extension data.

Gatsu · May 15, 2020

clarkwinkelmann When I delete, it says that the resource does not exist but if I update with F5 it is always present.
Yes, I tried directly to remove the extension via SSH but then after I reinstall it I have all the data equally.

Do I have to try with Unistall from the panel?

clarkwinkelmann · May 15, 2020

Gatsu clicking "Uninstall" in the admin panel is the only way to delete the extension data, if that's what you want to do. It will remove the tables from the database, effectively deleting all of the data created by the extension, including terms accept dates for all users.

I have just tested the extension again on beta 13 but don't see any issue. Maybe there's some kind of extension conflict on your forum.

Can you share a screenshot of the full error message you get ? Does it appear in a red modal inside Flarum?

Gatsu · May 15, 2020

clarkwinkelmann Thank you very much, I solved with Unistall.

Mark73 · Jul 15, 2020

Not sure what I'm doing wrong. I'm testing this extension locally and I could apparently sign up without having to accept the terms, I still have to accept them if they are updated though. My permissions are set to only allow admins to bypass accepting the terms and I'm not using any of the incompatible extensions mentioned above...

clarkwinkelmann · Jul 15, 2020

Mark73 did you specifiy an update date or did you leave it empty? Does it show to the user that new terms are available without forcing them to accept them or does it not show any terms available at all.

Do the terms appear on the register form or not?

Mark73 · Jul 15, 2020

clarkwinkelmann did you specifiy an update date or did you leave it empty?

Whether I specify an update date or not, the user can still sign up without accepting the terms.

clarkwinkelmann Do the terms appear on the register form or not?

Yes, they do appear, but you don't have to accept them to complete the sign up process.

clarkwinkelmann Does it show to the user that new terms are available without forcing them to accept them or does it not show any terms available at all.

This is what happens:

1- A user tries to sign up, and the terms appear but he doesn't need to accept them.
2- The user can interact freely after signing up.
3- If I update the terms, he would then have to accept the updated terms before he can interact again.

So basically the user is skipping the terms when signing up. He has to accept once updated.

clarkwinkelmann · Jul 15, 2020

Mark73 can you share your php flarum info so we can see which other extensions are active?

Mark73 · Jul 15, 2020

clarkwinkelmann

huuduy216 · Jul 29, 2020

I just notice and issue, if the user sign up and does not click the "I accept..." checkbox. A message will be displayed and the sign up button stuck spinning forever. User can not click the check box as well. They have to close the sign up modal and reopen it.

Anyone experimenting the same problem?

clarkwinkelmann · Jul 29, 2020

huuduy216 what message is shown? The expected "you need to accept the terms" message? Do you have debug mode enabled?

huuduy216 · Jul 29, 2020

clarkwinkelmann yes it's the "you need to accept" message (which is correct). I tried with both debug mode on and off, the button still stuck loading and the checkbox can not be click at that point

bryantmilan · Aug 14, 2020

How to set up new users must accept terms on registration? Currenly, they can register without accepting terms.

Also, how is this below with one checkbox possible now?

matteocontrini Would it be possible to have an option for showing a single checkbox for all the policies, when signing up? The text would be something like "I accept Terms of Service and Privacy Policy" (policies titles concatenated).