Configure SMTP UI

flevorium

Thank you so much for this, this is amazing. I'm stupid with phpmyadmin and my host was running some ancient version so I couldn't get it working myself.

Averell

@BinhQuang , you have forgotten to change (or allow changing) mail_driver to smtp (the default value is : mail).
And for this reason your extension does not work on a new installation, the user has still to edit manually this field in the database ?

Could you add this, please ?

Averell

Well... No answer after 12 days, so I did the job :
https://github.com/Averell7/vingle-configure-smtp
BUT :
It is unfinished because :
1. The default value shown is "null", and it should be "smtp"
2. You can enter anything in the field and this is DANGEROUS. If you enter an invalid value, the forum will not load (blank page). It should be a drop down box with two possible values : mail or smtp.

Can anyone finish the job, or give me the indications to finish it. Thanks.

Changed files are :
extensions\vingle-configure-smtp\js\admin\dist\extension.js
extensions\vingle-configure-smtp\js\admin\src\components\ConfigureSMTPSettingModal.js

santiagobiali

AverellI finished what you asked. Already sent a pull request in github but ultil it's accepted you can see it here

Averell

Thanks a lot @santiagobiali , I wouldn't have been able to do it. It works fine.

santiagobiali

@BinhQuang you haven't answered my PR, it's been 3 days.

BinhQuang

santiagobiali
sorry, I do not have time to visit github or flarum 😉

Averell

BinhQuang I updated to beta-5, and so uninstalled and reinstalled your smtp extension. I am surprised to see that the situation is unchanged, about the PR asked by santiagobiali : There is still no option to choose smtp or mail. This means the modification is still in the dev version, and not yet in the distributed version. Please, don't forget to update this. Thanks.

jordanjay29

invisible_helmet Please make a new topic for this discussion, it does not belong in this extension thread.

BinhQuang

Averell
I have clicked button update on the page https://packagist.org/packages/vingle/flarum-configure-smtp

santiagobiali

Averell I've just updated my branch to match flarum-0.1.0-beta.5 and created a PR to BinhQuang

Averell

I cannot really help.
I just tried to install in a brand new installation of Flarum and composer says :
Using version ^0.1.0@beta for vingle/flarum-configure-smtp

And the version is the old one.

I uninstalled and reinstalled from dev-master and then I get my first version, with the Mail Driver field, but not the dropdown list that @santiagobiali added. And in this situation the extension is dangerous : if you put an unsupported value, flarum no longer starts.

Perhaps something to adapt to version beta-5.
@santiagobiali can you help, please ?

santiagobiali

Averell can you help, please ?

Sure, later tonight i will take a look at it.

Averell

I downloaded your branch, two files are different :
ConfigureSMTPSettingModal.js
extension.js

I copied these files in the flarum installation, and now I get your version OK.

BinhQuang

santiagobiali
Averell

https://packagist.org/packages/vingle/flarum-configure-smtp#0.2.0

BinhQuang

santiagobiali
I merged

santiagobiali

BinhQuang Don't forget to tag a release ?

Averell

I installed, everything OK, thanks. Version 0.2.0.

Averell

Toby BinhQuang Nice work! This is in fact something that we plan to have in core – feel free to integrate it and send

I have made a quick test (first time I am doing something like that). 80% of the time was installing bower and gulp on Windows and understand how to compile js.
After that, the first test was fairly simple. I have placed the command in Appearance page, because there is no page which makes sense, and presently in this page I have the SMTP configure command. Works fine.

I don't think I have the skills to make the full job, but perhaps you can finish my work as before , @santiagobiali ?
If you think it's worth a try, I can share what I have done. Tell me the best way for you.

The main question is design : No existing page is good for Smtp. I think an Advanced page should be added. And inside it, keep the popup or make the fields directly available ? I would suggest the first option, to keep place for other items.

I have tried to add a page, but it is not working presently.

datitisev

Averell I think an Advanced page should be adde

I think the Flarum team IS going to add an Advanced page in the future.

« Previous Page Next Page »