FriendsOfFlarum Formatting

Victor12

This is awesome! Thank you!

MikeJones

What happens to all the pictures/videos if the extension is turned off?

Toby

MikeJones They will go back to being plain ol' URLs 🙂

datitisev

0.1.1

Fixed flarum/core version requirement

Updating

composer require fof/formatting ^0.1.1

Kyrne

datitisev updated to allow installing on beta 8.1

010101

Does anyone have a problem with mp4 video URLs converting to nothing but blank space? Or is that just me? Maybe I have an extension conflict or a little troll living in my server.

datitisev

010101 This extension only enables TextFormatter plugins. What plugins do you have enabled? I can't remember what extension I tested, but the video I tested did work just fine. Are there any errors in the JS console?

rattler72

010101 So I am also having the same issue and can see that the mp4 url is being rendered as an img tag. This appears to render (be forgiving) ok on Safari but not Chrome. Any other people with this issue??

010101

datitisev Could be a iOS Google Chrome issue. I had trouble getting a .mov video to play on another site just now. YouTube videos embed just fine. I’m going to blame the browser for now and move on.

neogeo

Hello! I'm wondering which is the difference between s9-MediaEmebd and this extension? or is the same?

datitisev

neogeo The mediaembed extension enables the MediaEmbed plugin in TextFormatter. This extension let's you enable MediaEmbed and more plugins that exist in TextFormatter, such as Autoimage and Autovideo.

The functionality is the same, but here you can enable more than just one plugin per extension, and let's you enable some more plugins as well.

neogeo

Please, could you include these?

https://instaud.io for audio
https://sendvid.com for video

datitisev

neogeo The extension currently uses the default settings for the TextFormatter plugins, of which MediaEmbed is one of. You can look at https://s9etextformatter.readthedocs.io/Plugins/MediaEmbed/Sites/ for the list of default supported sites.

I'm not sure if I want to (or will) add configuration options to this extension, as they'd be specific to each plugin.

tankerkiller125

Truly awesome and works flawlessly.

jordanjay29

datitisev Just FYI about this suggestion to JoshyPHP. You may want to make a decision on adding configuration options or not, and put that in the OP.

clarkwinkelmann

momothy I don't see that name on the list of supported sites:

datitisev The extension currently uses the default settings for the TextFormatter plugins, of which MediaEmbed is one of. You can look at https://s9etextformatter.readthedocs.io/Plugins/MediaEmbed/Sites/ for the list of default supported sites.

datitisev

jordanjay29 I feel like I'm being dumb, but your message is not registering in ma brain 🤦‍♂️. Could you clarify, please? 😂

jordanjay29

datitisev There's a lot of user requests for specific sites in that thread. If JoshyPHP marks his mediaembed extension abandoned in favor of yours, those requests are likely to come here (see the example above).

If you're not going to support them, it'd be best to decide now before you have a flood of them. 😉

datitisev

jordanjay29 Ah, I see. The issue is that I haven't decided what to do yet. I wanted to keep this extension simple, but if I start adding configuration options, then I can also add other plugins that require configuration.

luceos

datitisev on one hand I think keeping it simple is best in terms of our goals for FoF, however I also believe that playing the quality proxy with the textformatter library will pay off in the long run, what do you think?

neogeo

For YouTube embed videos extension:

I think would be cool and more clean if you can remove the related videos with the ?rel=0 or &rel=0 parameter.

datitisev

neogeo That would require, as mentioned earlier, configuration options. The embed templates are all provided by the TextFormatter MediaEmbed plugin by default, with no configuration required.
As mentioned in https://discuss.flarum.org/d/18535-add-mannualy-website-for-s9e-mediaembed/4, you would probably want to change the template yourself following the instructions at https://s9etextformatter.readthedocs.io/Plugins/MediaEmbed/Change_template/ to change the YouTube template.

If I add the possibility to configure MediaEmbed extensively, then I'd probably have to add it for the rest of the plugins. I think the best way to configure the plugins for now is just to use the Flarum root extend.php feature that was introduced in beta 8.

neogeo

you would probably want to change the template yourself following the instructions at https://s9etextformatter.readthedocs.io/Plugins/MediaEmbed/Change_template/ to change the YouTube template.

datitisev Thanks for reply. Do you know which/where is this file/path to modify it? I can't found it...