FriendsOfFlarum Formatting

datitisev

neogeo The mediaembed extension enables the MediaEmbed plugin in TextFormatter. This extension let's you enable MediaEmbed and more plugins that exist in TextFormatter, such as Autoimage and Autovideo.

The functionality is the same, but here you can enable more than just one plugin per extension, and let's you enable some more plugins as well.

010101

datitisev Could be a iOS Google Chrome issue. I had trouble getting a .mov video to play on another site just now. YouTube videos embed just fine. I’m going to blame the browser for now and move on.

neogeo

Please, could you include these?

https://instaud.io for audio
https://sendvid.com for video

datitisev

neogeo The extension currently uses the default settings for the TextFormatter plugins, of which MediaEmbed is one of. You can look at https://s9etextformatter.readthedocs.io/Plugins/MediaEmbed/Sites/ for the list of default supported sites.

I'm not sure if I want to (or will) add configuration options to this extension, as they'd be specific to each plugin.

tankerkiller125

Truly awesome and works flawlessly.

jordanjay29

datitisev Just FYI about this suggestion to JoshyPHP. You may want to make a decision on adding configuration options or not, and put that in the OP.

clarkwinkelmann

momothy I don't see that name on the list of supported sites:

datitisev The extension currently uses the default settings for the TextFormatter plugins, of which MediaEmbed is one of. You can look at https://s9etextformatter.readthedocs.io/Plugins/MediaEmbed/Sites/ for the list of default supported sites.

datitisev

jordanjay29 I feel like I'm being dumb, but your message is not registering in ma brain 🤦‍♂️. Could you clarify, please? 😂

jordanjay29

datitisev There's a lot of user requests for specific sites in that thread. If JoshyPHP marks his mediaembed extension abandoned in favor of yours, those requests are likely to come here (see the example above).

If you're not going to support them, it'd be best to decide now before you have a flood of them. 😉

datitisev

jordanjay29 Ah, I see. The issue is that I haven't decided what to do yet. I wanted to keep this extension simple, but if I start adding configuration options, then I can also add other plugins that require configuration.

luceos

datitisev on one hand I think keeping it simple is best in terms of our goals for FoF, however I also believe that playing the quality proxy with the textformatter library will pay off in the long run, what do you think?

neogeo

For YouTube embed videos extension:

I think would be cool and more clean if you can remove the related videos with the ?rel=0 or &rel=0 parameter.

datitisev

neogeo That would require, as mentioned earlier, configuration options. The embed templates are all provided by the TextFormatter MediaEmbed plugin by default, with no configuration required.
As mentioned in https://discuss.flarum.org/d/18535-add-mannualy-website-for-s9e-mediaembed/4, you would probably want to change the template yourself following the instructions at https://s9etextformatter.readthedocs.io/Plugins/MediaEmbed/Change_template/ to change the YouTube template.

If I add the possibility to configure MediaEmbed extensively, then I'd probably have to add it for the rest of the plugins. I think the best way to configure the plugins for now is just to use the Flarum root extend.php feature that was introduced in beta 8.

neogeo

you would probably want to change the template yourself following the instructions at https://s9etextformatter.readthedocs.io/Plugins/MediaEmbed/Change_template/ to change the YouTube template.

datitisev Thanks for reply. Do you know which/where is this file/path to modify it? I can't found it...

datitisev

neogeo In beta 8, a feature was added that lets you have an extend.php file on the Flarum root folder, similar to extensions. This extend.php file always loads, and unlike an extension, doesn't have to be enabled. It works the same as an extension's extend.php.

You may have to create the file if you didn't create it when migrating from beta 7 to beta 8.

neogeo

datitisev for me is difficult use the extend.php file for that (I'm not programmer)

I just prefer add the ?rel=0 parameter after the youtube url video. So I imagine there is a template created for that inside the extension... but I can't find the exact file to modify on .../vendor/s9e/text-formatter/src

datitisev

neogeo You should not be editing vendor files... and besides, you'd have to edit (i think) src/Bundles/MediaPack/Renderer.php which just opening would probably crash your editor... see what i mean at https://github.com/s9e/TextFormatter/blob/master/src/Bundles/MediaPack/Renderer.php 😖

tankerkiller125

datitisev Holy crap, that code could use some major re-working. I work for a software engineering company and I've seen some pretty poorly designed code in the company but that right there is way worse.

neogeo

datitisev tankerkiller125 I would like a simple and flexible Youtube/Vimeo embed extension 😅 with the option of activate or not some of these paramenters:
https://developers.google.com/youtube/player_parameters?hl=es-419#Parameters

luceos

neogeo my comment was intended for tankerkiller125 👌

rob006

tankerkiller125 I work for a software engineering company

Then you should see that this file is obviously generated 😃

luceos

Developers each have different goals. Some try to achieve readable and beautiful code, others want code to be performant. The s9e lib is created with performance in mind and does so well.

neogeo

luceos I understand but I continue thinking that adding ?rel=0parameter will not affect the performance at all, and will make our flarums-video-embeds more clean.

« Previous Page Next Page »