FriendsOfFlarum Formatting

Arnold

troymccann you can post those links in [code] blocks for example 👌

troymccann

Arnold I've worked that out (I use URL tags) but not everyone has - it's not great UX. I feel like it would be handy to leave the hyperlink in there, rather than remove it and only have the embedded element.

010101

I have a very strange issue. I see above that people have had similar issues with certain links not embedding. I have a feeling there will be no solution. But, thought I’d ask... anyone have issues embedding SoundCloud? YouTube, Twitter, and other URLs embed at my forum, but SoundCloud will not (it used to). But, SoundCloud links convert here at discuss. So, it’s my forum. No errors.

I don’t see how it could be an extension conflict because embedding works with other URLs. It’s only SoundCloud... 😥

Edit: Oh. Rich text editor conflict. Still. Strange that only SoundCloud is affected. I’ll post this over in the rich text thread.

clarkwinkelmann

010101 even though you have the last version of fof/formatting, you could have an older version of s9e/text-formatter. Since the list of embeds is in TextFormatter, this means the exact list could differ.

TextFormatter is a third-party library and doesn't follow Flarum release cycle, so it might add or modify embeds at any time.

You can check what version of TextFormatter you have with composer show s9e/text-formatter.

You could update TextFormatter with composer update s9e/text-formatter

All that being said, I don't know if the Soundcloud embed was modified in TextFormatter recently. You'd need to check their release notes or git history.

Arnold

After updating to beta 16 I have a strange bug which is similar to 010101 had with Soundcloud,

But this time it's about images. When I insert image link in composer I see preview of the image, but when I insert another one, I don't see a preview until I add/remove new line before or after the image link. And what's more it's happening only on mobile version. I have a few users reported about it, they use different OS and different browsers, so it seems to be a bug in Formatter.

Maybe someone had a similar problem and/or have some thoughts about it? I don't use rich text extension, btw.

010101

clarkwinkelmann Thanks. I’ve realized it’s the rich text extension. With the default editor SoundCloud embeds work just fine. There must be something the rich text editor does as it is posting maybe that strips or adds code making the embed not work? I don’t know.

kimsible

Hi,

Support of Mastodon (https://joinmastodon.org) and PeerTube (https://joinpeertube.org) could be very great.
Both are a network of instances using Activity Pub.

Since the domain name is obviously not centralized like YouTube and Twitter, the instance domain list to auto-embed could be add the back office extension options?

askvortsov

troymccann IIRC, all this extension does is enable plugins from the upstream textformatter library. I agree with you that leaving the link might be useful, that could be a good feature suggestion in that library.

010101

Arnold I still have that problem every now and then. Now I'm not really sure what causes it. 🙁

Arnold

010101 I think it may be the same issue. Formatter does not recognize the link and doesn't embed it until a user adds or removes a line break before the link (in mobile version).

I have not yet figured out if there is any specific sequence of actions to replicate the issue, but it would be great if the maintainers of the extension could help us and test the insertion of images on a mobile device. I'm 99% sure they will see the same bug there.

010101

Arnold Now that you mention this, I do experience this with other embeds. You mention "before" but sometimes if I don't add a line break after a URL it won't embed. In other words, if the URL is the last thing in the post.

Arnold

010101 you are right 👍️ I have tested it more and yes, if the url is the last thing in the post you need to add a line break after it in order the extension to embed it.

Arnold

@FriendsOfFlarum after @010101 and I tested the extension on two different Flarum installations with a different sets of other extensions it's safe to say that this bug is hiding somewhere in the Formatting extension, and it appeared in the last version of the extension, because I did not notice anything like that until update to b16.

So it would be great if you could look into this, since such extension behavior spoils the user experience on mobile noticeably.

askvortsov

Arnold The formatting extension is just a wrapper around plugins from the s9e/textformatter library. You should report this issue there.

Arnold

askvortsov I will, but honestly I very much doubt that the matter is in the s9e/textformatter library. Because the issue happens only in mobile mode, like it was with post stream earlier, for example. If it was a bug in the library, then the embedding would not work on any device, I think.

I'm not sure what's causing this, maybe it's not formatting extension per se, but something in composer when the Flarum in the mobile mode, because the embedding doesn't work exactly until a new line starts after the link 🤔

IanM

1.0.0

Flarum 1.0 ready

composer require fof/formatting
php flarum cache:clear

Hari

IanM thanks

Arnold

There is a bug recently fixed in s9e/TextFormatter which may be connected (but I'm not sure) to the issue we have discussed: s9e/TextFormatter5df3c57

Is there a possibility to update fof/formatting for b16 and include the recent s9e/TextFormatter fix?

IanM

Arnold No need.. So long as s9e/textformatter has published a new release, you can update the dependancy used by fof/formatting using this:

composer update -W

but be careful there, it might be better to use

composer update flarum/core -W

rob006

IanM It should be rather:

composer update s9e/text-formatter -W

IanM

rob006 or that, yes 😉

« Previous Page Next Page »