FriendsOfFlarum Webhooks

ctml

Thanks, I will wait for the next beta and update to test the extension again!

It can be done so that you write code

I am not sure if the FoF PrettyMail code could be leveraged, for the email templates there is some blueprint feature that handles the replacement of the variables holding the data. I don't know if that actually comes from the extension, or really that part is just part of the core email notifications they are making use of. Anyways, I understand some of this stuff probably requires a lot of work which extension developers don't have time for. I hope someday to learn about flarums extension api and trying to build some of my own and submit PR's for others 🙂

datitisev

ctml The thing is the PrettyMail code is Blade. It can still have PHP, so if you have a rogue admin it could be unsafe as they can run any PHP when that executes. The same would apply here, but it'd just be plain PHP. I could probably make some system so that you can access all the variables similarly 🤷 or maybe blade would somehow work too, I don't know. I haven't thought too much about it.

Apologies if nothing above made sense 😆

ctml

datitisev

Yeah fair enough, that makes sense! Thanks again!

ctml

A general http post webhook with all relevant data posted in json would be a good feature as well, then the user can handle the event/data however they'd like.

datitisev

ctml That's currently available in the pro version (reflar/webhooks-pro) on Extiverse. I don't think I ever made a discussion for it here. The problem with that is that it's not the same as an API response, so it has weird logic and sometimes doesn't work completely depending on the event and the payload.

ajhalili2006

I got an important message from Discord (you know it, I'm using their APIs) about the API domain migration last July 18. On November 7, they'll be dropping support for the discordapp.com in favor of discord.com and if the plugin still asks for the discordapp.com domain and attempt to send requests beyond that date, errors will fire up in the console.

Related Issue: ReFlar/webhooks21

EvilExecutor

Hey! When I enable the extension the discussions/post won't get posted at once. It asks for a reload. Once the reload is done the discussions/post gets posted and the message is sent to discord. But when I disable the extension everything works fine... Have I done something wrong?

datitisev

EvilExecutor There should be an error in the Flarum log file at storage/logs/flarum-<date>.log

EvilExecutor

Nope there isn't 🙁

clarkwinkelmann

You can also enable debug in config.php and try again to have the error displayed on screen.

If it's not logged, it's either a javascript error instead of backend error. Or it's a backend error and the log folder isn't writable.

EvilExecutor

clarkwinkelmann
Sounds like Greek to me 😅

datitisev

EvilExecutor That's... interesting... and doesn't really show where the error comes from. At a glance it doesn't seem like its' an issue with webhooks but a dependency of it. 🤔

clarkwinkelmann

EvilExecutor seems like this is the same issue googleapis/google-api-php-client1392, https://stackoverflow.com/q/50898330

You could try running composer update guzzlehttp/guzzle --with-dependencies to update Guzzle to the latest possible version for your setup and see whether the issue goes away.

From those linked threads, it seems updating to Guzzle 6.3 or higher is necessary to fix the issue. You can use composer show guzzlehttp/guzzle --tree to check which version of Guzzle and its dependencies are installed.

EvilExecutor

composer require guzzlehttp/guzzle:^6.3 made it work as charm (was a blind shot for me) 🙂 Thanks @clarkwinkelmann

clarkwinkelmann

EvilExecutor Good news! However I wouldn't recommend using require, because now it's hard-coded in your composer.json and could prevent an update later on when all extensions move to Guzzle version 7.

You can simply remove the line about guzzle in your composer.json to fix this problem.

ItsMrReals

Is there any support for by tag?

Like so it only sends the webhook if it had a tag.

datitisev

ItsMrReals Not at the moment. That will probably be added in the future.

EvilExecutor

Any plans to update this extension?

datitisev

EvilExecutor Yes. I can't provide a timeframe for it, however. Sorry 😕

EvilExecutor

datitisev no problem take your time!

Amarok

datitisev EvilExecutor Yes. I can't provide a timeframe for it, however. Sorry 😕

ctml 😉 maybe, but not in priority

« Previous Page Next Page »