FriendsOfFlarum Webhooks

RikuS3n

Sorry for asking, but seems webhooks doesn't send a request to discord. Is there any special thing to do?
I put Webhooks URL of Discord channel to webhooks settings.

datitisev

RikuS3n Make sure you enable the events that you want the extension to send to Discord.

RikuS3n

datitisev Yes, I enabled it. And creating/deleting post didn't work.

datitisev

RikuS3n Try changing the "Members" dropdown to guest or admin - that was left there when I attempted (and failed) user group permission checks without an actual user. It may be breaking the extension.

RikuS3n

datitisev Oh that works. I appreciate it。

ctml

I'm hitting this error on a discussion post with slack webhook setup. I noticed in the DB and UI it shows an error code HTTP 200, which is a success code. Not sure what that may indicate, only thing I could think of may be certificate error on the endpoint, but I don't see any indication of that error anywhere.. perhaps it is just not captured.

<br />
<b>Notice</b>:  Trying to get property 'message' of non-object in <b>/flarum/vendor/reflar/webhooks/src/Adapters/Slack/SlackException.php</b> on line <b>45</b><br />
<br />
<b>Notice</b>:  Trying to get property 'code' of non-object in <b>/flarum/vendor/reflar/webhooks/src/Adapters/Slack/SlackException.php</b> on line <b>45</b><br />
<br />
<b>Fatal error</b>:  Uncaught Laminas\HttpHandlerRunner\Exception\EmitterException: Output has been emitted previously; cannot emit response in /flarum/vendor/laminas/laminas-httphandlerrunner/src/Exception/EmitterException.php:24
Stack trace:
#0 /flarum/vendor/laminas/laminas-httphandlerrunner/src/Emitter/SapiEmitterTrait.php(40): Laminas\HttpHandlerRunner\Exception\EmitterException::forOutputSent()
#1 /flarum/vendor/laminas/laminas-httphandlerrunner/src/Emitter/SapiEmitter.php(27): Laminas\HttpHandlerRunner\Emitter\SapiEmitter-&gt;assertNoPreviousOutput()
#2 /flarum/vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(98): Laminas\HttpHandlerRunner\Emitter\SapiEmitter-&gt;emit(Object(Flarum\Api\JsonApiResponse))
#3 /flarum/vendor/flarum/core/src/Http/Server.php(42): Laminas\HttpHandlerRunner\RequestHandlerRunner-&gt;run()
#4 /flarum/public/index.php(26): Flarum\Http\Server-&gt;listen()
#5 {main}
  thrown in <b>/flarum/vendor/laminas/laminas-httphandlerrunner/src/Exception/EmitterException.php</b> on line <b>24</b><br />

Enhancement Ideas/Requests:

It would be great to be able to setup the webhooks with a tag filter, use webhook for only [tag1, tag2, tagN]. Since I haven't got it working I don't know the exact behaviour, but I have some private areas for admins, and public for all users. I'd like to fire webhooks for actions happening in the public area, whether they be by an admin or user, but not fire webhooks for admin actions in the private admin area as these webhooks go to public spaces.
Another enhancement could be templates for these hooks, similar to the pretty mail templates, you can use the relevant event data and build your own template, so you can customize the data/layout being sent to the already supported webhook destinations.

Thanks for this much needed plugin!

datitisev

ctml haven't got it working I don't know the exact behaviour, but I have some private areas for admins, and public for all users. I'd like to fire webhooks for actions happening in the public area, whether they be by an admin or user, but not fire webhooks for admin actions in the private admin area as these webhooks go to public spaces.

This is kind of implemented, but much less customizable. You can choose between stuff guests can access & stuff admins can access (which includes what guests can access).

I do want to add the option to filter hooks by tag.

ctml Another enhancement could be templates for these hooks, similar to the pretty mail templates, you can use the relevant event data and build your own template, so you can customize the data/layout being sent to the already supported webhook destinations.

This is harder to do because it'd require making the text you input be replaced with some code. It can be done so that you write code, but that's unsafe and you could easily break things. I've thought about it, but I'm not planning on adding this anytime soon.

I'll look into the issue you're having. It'll probably be fixed when I update this extension for beta 14 (after it comes out).

ctml

datitisev

Thanks, I will wait for the next beta and update to test the extension again!

It can be done so that you write code

I am not sure if the FoF PrettyMail code could be leveraged, for the email templates there is some blueprint feature that handles the replacement of the variables holding the data. I don't know if that actually comes from the extension, or really that part is just part of the core email notifications they are making use of. Anyways, I understand some of this stuff probably requires a lot of work which extension developers don't have time for. I hope someday to learn about flarums extension api and trying to build some of my own and submit PR's for others 🙂

datitisev

ctml The thing is the PrettyMail code is Blade. It can still have PHP, so if you have a rogue admin it could be unsafe as they can run any PHP when that executes. The same would apply here, but it'd just be plain PHP. I could probably make some system so that you can access all the variables similarly 🤷 or maybe blade would somehow work too, I don't know. I haven't thought too much about it.

Apologies if nothing above made sense 😆

ctml

datitisev

Yeah fair enough, that makes sense! Thanks again!

ctml

A general http post webhook with all relevant data posted in json would be a good feature as well, then the user can handle the event/data however they'd like.

datitisev

ctml That's currently available in the pro version (reflar/webhooks-pro) on Extiverse. I don't think I ever made a discussion for it here. The problem with that is that it's not the same as an API response, so it has weird logic and sometimes doesn't work completely depending on the event and the payload.

ajhalili2006

I got an important message from Discord (you know it, I'm using their APIs) about the API domain migration last July 18. On November 7, they'll be dropping support for the discordapp.com in favor of discord.com and if the plugin still asks for the discordapp.com domain and attempt to send requests beyond that date, errors will fire up in the console.

Related Issue: ReFlar/webhooks21

EvilExecutor

Hey! When I enable the extension the discussions/post won't get posted at once. It asks for a reload. Once the reload is done the discussions/post gets posted and the message is sent to discord. But when I disable the extension everything works fine... Have I done something wrong?

datitisev

EvilExecutor There should be an error in the Flarum log file at storage/logs/flarum-<date>.log

EvilExecutor

Nope there isn't 🙁

clarkwinkelmann

You can also enable debug in config.php and try again to have the error displayed on screen.

If it's not logged, it's either a javascript error instead of backend error. Or it's a backend error and the log folder isn't writable.

EvilExecutor

clarkwinkelmann
Sounds like Greek to me 😅

datitisev

EvilExecutor That's... interesting... and doesn't really show where the error comes from. At a glance it doesn't seem like its' an issue with webhooks but a dependency of it. 🤔

clarkwinkelmann

EvilExecutor seems like this is the same issue googleapis/google-api-php-client1392, https://stackoverflow.com/q/50898330

You could try running composer update guzzlehttp/guzzle --with-dependencies to update Guzzle to the latest possible version for your setup and see whether the issue goes away.

From those linked threads, it seems updating to Guzzle 6.3 or higher is necessary to fix the issue. You can use composer show guzzlehttp/guzzle --tree to check which version of Guzzle and its dependencies are installed.

« Previous Page Next Page »