Quote-reply issue here on Discuss

clarkwinkelmann

Hello everybody,

I just noticed today I can't use the reply feature here on Discuss. In the preview the @ doesn't get highlighted and when posting there's a 500 error.

If I remove the mention from the text I can post.

EDIT: I also just noticed that existing mentions are shown as plain text as well.

I suppose there's a faulty update of the dev-master version of the mentions extension ?

I tried in private browsing and have the same issue so I don't think it's caching-related on my side.

Somebody might want to take a look at it.

Ralkage

clarkwinkelmann testing, 1,2,3.

clarkwinkelmann

Ralkage ahah looks fixed now.

I've seen somebody say they couldn't use mentions in another thread just before so surely I wasn't the only one affected.

EDIT: replying to Ralkage this was on Firefox (possibly not most recent) on Ubuntu. On the same browser it's now working.

Franz

Hi folks, this was a regression from another hotfix from my side. I debugged and fixed this after your reports were forwarded to me.

clarkwinkelmann Ralkage because this works again 😉

clarkwinkelmann

Franz thanks for the quick fix. I was just about to report I had found the culprit by looking at the git history 😛

So does it mean the code is auto-deployed to Discuss ? Pretty risky to hot fix stuff in these conditions without local testing 😬

luceos

clarkwinkelmann nope it's not auto deployed as far as I know.

Franz

clarkwinkelmann No, it's an automatic process, but it has to be triggered manually, which I did after every commit. 😉

After the initial hotfix for 404 URLs (which triggered the mentions issue), I did not properly re-test the hotfix locally, which would have prevented this mess. It had to do with missing knowledge about the inner workings of TextFormatter, plus stupid copy-paste mistakes. 😕

OrdinaryJellyfish

I seem to be experiencing this issue, even though I believe flarum/mentions is on the latest commit for me:

php flarum info returns this:

Flarum core 0.1.0-beta.8.1
PHP version: 7.3.0-1+ubuntu18.04.1+deb.sury.org+1
Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, pcntl, Reflection, SPL, sodium, session, standard, mysqlnd, PDO, xml, calendar, ctype, curl, dom, mbstring, fileinfo, ftp, gd, gettext, iconv, json, exif, mysqli, pdo_mysql, Phar, posix, readline, shmop, SimpleXML, sockets, sysvmsg, sysvsem, sysvshm, tokenizer, wddx, xmlreader, xmlwriter, xsl, zip, Zend OPcache
+---------------------+-------------+------------------------------------------+
| Flarum Extensions   |             |                                          |
+---------------------+-------------+------------------------------------------+
| ID                  | Version     | Commit                                   |
+---------------------+-------------+------------------------------------------+
| flarum-lang-english | dev-master  |                                          |
| flarum-mentions     | dev-master  | 743f3f19ea2d4999bfaea4e38476d8ed3df0094e |
+---------------------+-------------+------------------------------------------+
Base URL: http://flarum.localhost
Installation path: /home/ordinaryjellyfish/Documents/flarum
Debug mode: ON
Don't forget to turn off debug mode! It should never be turned on in a production system.

Toby

OrdinaryJellyfish Try php flarum cache:clear

OrdinaryJellyfish

Toby That seems to have fixed it. Thanks!

Ralkage

Franz we live and we learn, even as developers, no? 😉

I had a ton of missing knowledge myself pre-A+ certification and now I know things I’ve never known before about Windows, Networking, and hardware 😃