FriendsOfFlarum Links

MikeJones

karaok Is this update for beta 14?

[deleted]

MikeJones beta 14 was provided in version 4.0 👍 see further up.

karaok

MikeJones yes, beta 14 compatability was introduced from 0.4.0

MathieuM

Hello,
It seems like drag and drop from the extension admin page doesn't work ❓️

karaok

0.4.2

Replace deprecated code with new equivalents (Watching you, beta 15 👀 )

Updating

composer require fof/links

IanM

0.5.0

Flarum beta 15 support

Trombert

Hi, I have two suggestions that I think can be simple to implement and quite useful.

1º Saving empty links is allowed. If the link field is empty and sublinks are added, the main link acts in the same way as the small "Dropdown-toggle" button, so if you click the "empty" link the same thing happens and the dropdown menu appears (aria-expanded="true")

2º Hoverable dropdowns. There is not much to explain about this I think it would be interesting to have the option of having the dropdowns displayed when the mouse passes over them.

In my opinion the first suggestion is quite necessary since you are currently forced to redirect to some place and this doesn't make much sense, this came up because I thought of putting a link with the title "More" and a great list of different links to the web, the point is that "More" doesn't make sense that it goes anywhere, it simply incites you to click on it to see other links.

Thank you very much for your time and this fantastic extension!

clarkwinkelmann

Trombert (2) could be achieved with CSS, and would actually have the benefit of achieving (1) without any additional change.

(1) could indeed be implemented in the extension. We would need to switch the split dropdown component with the simple dropdown component based on a condition.

Pollux

Trombert clarkwinkelmann

(1) can be achieved by pure CSS as well.

Let's assume we have two "parent links" that we want to behave like the small carets do. Let's further assume these two links have the classes .item-link1 and .item-link2 (use your browser's Inspect Element command to find out the exact classes). What we want to do now is to hide these link labels (and thus the whole link) and replace the carets with our own text (e.g. Q & A, Legal Stuff). As the carets are FontAwesome elements, we need to change their font to the standard font.

.item-link1 a, .item-link2 a {
    display: none;
}

.item-link1 .fa-caret-down::before {
    content: "Q & A";
}

.item-link2 .fa-caret-down::before {
    content: "Legal Stuff";
}

#header-primary .fa-caret-down {
    font-family: inherit;
    font-size: 100%;
}

That's all.

Trombert

clarkwinkelmann I hadn't thought it could be done (2) with CSS, now that you said it I'm trying to find a way to do it... the attribute should be a display:block?

clarkwinkelmann

Trombert I have not tested by I think it can be done by observing .ButtonGroup:hover and setting display:block on .Dropdown-menu.

Trombert

Pollux
What a simple and interesting solution, no doubt, what I was doing was much more complicated, I always forget the possibilities of ::before. Thank you very much!

With the (2) it is possible to add a "delay" when an element is no longer hovering?, the links are not 100% height and when you go to the dropdown menu and reach the small gap between the link and the dropdown menu disappears as is obvious

I have achieved some solutions but I end up deforming the header-secondary or the header-primary with different heights...

IanM

0.5.1

Fix minor admin page layout issue
Add option to specify links that are only visible to registered members FriendsOfFlarum/links23
Add js exports for extensibility

Updating

composer require fof/links:"*"
php flarum migrate
php flarum cache:clear

Pollux

One more thing: Would it be possible to have links visible only to guests?

This way you could provide two versions for the same topic, e.g. an overview for guests and a more detailed version for registered members.

IanM

0.5.2

Allow links to have one of three visibility states: everyone, members, guests. Defaults to everyone (Pollux )

Updating

composer require fof/links:"*"
php flarum migrate
php flarum cache:clear

Pollux

IanM Unbelievably awesome... 👍️

IanM

IanM php flarum migrate

peopleinside

Arnold

ctml

Feature Suggestion: support for adding additional links (with icon) in the account dropdown

olepmac

Hello

I tried adding fof/links to my forum but it pops up an error on the web UI. The browser's devtools indicates error 500 and the logs (storage/logs/flarum...) are as follows:

[2021-01-20 12:12:08] flarum.ERROR: ParseError: syntax error, unexpected ')' in /var/www/flarum/vendor/fof/links/src/Command/CreateLinkHandler.php:52
Stack trace:
#0 /var/www/flarum/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile('/var/www/flarum...')
#1 [internal function]: Composer\Autoload\ClassLoader->loadClass('FoF\\Links\\Comma...')
#2 [internal function]: spl_autoload_call('FoF\\Links\\Comma...')
#3 /var/www/flarum/vendor/flarum/core/src/Bus/Dispatcher.php(20): class_exists('FoF\\Links\\Comma...')
#4 /var/www/flarum/vendor/illuminate/bus/Dispatcher.php(88): Flarum\Bus\Dispatcher->getCommandHandler(Object(FoF\Links\Command\CreateLink))
#5 /var/www/flarum/vendor/illuminate/bus/Dispatcher.php(76): Illuminate\Bus\Dispatcher->dispatchNow(Object(FoF\Links\Command\CreateLink))
#6 /var/www/flarum/vendor/fof/links/src/Api/Controller/CreateLinkController.php(48): Illuminate\Bus\Dispatcher->dispatch(Object(FoF\Links\Command\CreateLink))
#7 /var/www/flarum/vendor/flarum/core/src/Api/Controller/AbstractSerializeController.php(115): FoF\Links\Api\Controller\CreateLinkController->data(Object(Laminas\Diactoros\ServerRequest), Object(Tobscure\JsonApi\Document))
#8 /var/www/flarum/vendor/flarum/core/src/Api/Controller/AbstractCreateController.php(22): Flarum\Api\Controller\AbstractSerializeController->handle(Object(Laminas\Diactoros\ServerRequest))
#9 /var/www/flarum/vendor/flarum/core/src/Http/RouteHandlerFactory.php(38): Flarum\Api\Controller\AbstractCreateController->handle(Object(Laminas\Diactoros\ServerRequest))
#10 /var/www/flarum/vendor/flarum/core/src/Http/Middleware/ExecuteRoute.php(27): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}(Object(Laminas\Diactoros\ServerRequest), Array)
#11 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\ExecuteRoute->process(Object(Laminas\Diactoros\ServerRequest), Object(Closure))
#12 /var/www/flarum/vendor/flarum/core/src/Api/Middleware/ThrottleApi.php(33): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#13 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Api\Middleware\ThrottleApi->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#14 /var/www/flarum/vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php(48): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#15 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\CheckCsrfToken->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#16 /var/www/flarum/vendor/flarum/core/src/Http/Middleware/ResolveRoute.php(67): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#17 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\ResolveRoute->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#18 /var/www/flarum/vendor/flarum/core/src/Http/Middleware/SetLocale.php(50): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#19 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\SetLocale->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#20 /var/www/flarum/vendor/flarum/core/src/Http/Middleware/AuthenticateWithHeader.php(55): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#21 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\AuthenticateWithHeader->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#22 /var/www/flarum/vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php(32): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#23 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\AuthenticateWithSession->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#24 /var/www/flarum/vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php(51): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#25 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\RememberFromCookie->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#26 /var/www/flarum/vendor/flarum/core/src/Http/Middleware/StartSession.php(61): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#27 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\StartSession->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#28 /var/www/flarum/vendor/flarum/core/src/Api/Middleware/FakeHttpMethods.php(29): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#29 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Api\Middleware\FakeHttpMethods->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#30 /var/www/flarum/vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php(28): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#31 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\ParseJsonBody->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#32 /var/www/flarum/vendor/flarum/core/src/Http/Middleware/HandleErrors.php(57): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#33 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\HandleErrors->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#34 /var/www/flarum/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(84): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#35 /var/www/flarum/vendor/middlewares/request-handler/src/RequestHandler.php(84): Laminas\Stratigility\MiddlewarePipe->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#36 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\RequestHandler->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#37 /var/www/flarum/vendor/middlewares/base-path-router/src/BasePathRouter.php(97): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#38 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\BasePathRouter->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#39 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Middleware/OriginalMessages.php(42): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#40 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(61): Laminas\Stratigility\Middleware\OriginalMessages->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#41 /var/www/flarum/vendor/middlewares/base-path/src/BasePath.php(53): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#42 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\BasePath->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#43 /var/www/flarum/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(84): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#44 /var/www/flarum/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(73): Laminas\Stratigility\MiddlewarePipe->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\EmptyPipelineHandler))
#45 /var/www/flarum/vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(96): Laminas\Stratigility\MiddlewarePipe->handle(Object(Laminas\Diactoros\ServerRequest))
#46 /var/www/flarum/vendor/flarum/core/src/Http/Server.php(42): Laminas\HttpHandlerRunner\RequestHandlerRunner->run()
#47 /var/www/flarum/public/index.php(26): Flarum\Http\Server->listen()
#48 {main}

Any ideas?

Thank you!

olepmac

olepmac Update on this issue

Solved. Weirdly enough, it installed with this syntax error on line 52:

(/var/www/flarum/vendor/fof/links/src/Command/CreateLinkHandler.php)

        $link = Link::build(
            Arr::get($data, 'attributes.title'),
            Arr::get($data, 'attributes.icon'),
            Arr::get($data, 'attributes.url'),
            Arr::get($data, 'attributes.isInternal'),
            Arr::get($data, 'attributes.isNewtab'),
            Arr::get($data, 'attributes.visibility'), // out of place comma
        );

Just removing the comma after the last item in the array took care of it.

Has anyone encountered the same issue?

IanM

Considering PHP 7.2 is now EOL, and 7.3 is now in security support only, I'd suggest that PHP 7.4 is used wherever possible.

PHP supported versions

0.5.3

Fix trailing comma / PHP 7.2 incompatibility (olepmac 010101 )

datitisev

olepmac This might have been because of your PHP version, not sure. I have had issues with trailing commas in the past that didn't error locally but did on other systems... we should probably remove it from the ext tho.

« Previous Page Next Page »