FriendsOfFlarum Merge Discussions

tankerkiller125

IanM Our button is a brilliant orange actually 😉

Sheylam96

In beta .15 there is this error in the console. Notifications stop working and do not allow browsing the forum

mount-redraw.js:15 Error: [e] The "children" attribute of attrs should never be used. Either pass children in as the vnode children or rename the attribute
    at e.setAttrs (Component.ts:111)
    at e.oninit (Component.ts:54)
    at Function.a (render.js:30)
    at M (render.js:917)
    at render.js:153
    at render.js:160
    at l (render.js:66)
    at u (render.js:50)
    at render.js:134
    at l (render.js:63)
a @ mount-redraw.js:15
(anonymous) @ mount-redraw.js:25
requestAnimationFrame (async)
c @ mount-redraw.js:23
e.parseResults @ DiscussionListState.js:143
(anonymous) @ DiscussionListState.js:97
Promise.then (async)
e.refresh @ DiscussionListState.js:91
e.refreshParams @ DiscussionListState.js:75
n.oninit @ IndexPage.js:40
a @ render.js:30
M @ render.js:917
(anonymous) @ render.js:153
(anonymous) @ render.js:160
l @ render.js:66
u @ render.js:50
h @ render.js:374
(anonymous) @ render.js:444
f @ render.js:415
(anonymous) @ render.js:488
f @ render.js:419
h @ render.js:302
(anonymous) @ render.js:964
a @ mount-redraw.js:14
(anonymous) @ mount-redraw.js:25
requestAnimationFrame (async)
c @ mount-redraw.js:23
v @ router.js:111
Promise.then (async)
t @ router.js:126
S @ router.js:95
(anonymous) @ setImmediate.js:40
f @ setImmediate.js:69
a @ setImmediate.js:109
postMessage (async)
i @ setImmediate.js:120
p.setImmediate @ setImmediate.js:27
d @ router.js:143
p @ router.js:20
y.set @ router.js:182
s.attrs.onclick @ router.js:250
_.handleEvent @ render.js:888
mount-redraw.js:15 TypeError: Cannot read property 'onremove' of undefined
    at T (render.js:712)
    at T (render.js:721)
    at T (render.js:721)
    at T (render.js:715)
    at T (render.js:721)
    at T (render.js:715)
    at N (render.js:655)
    at x (render.js:629)
    at h (render.js:373)
    at render.js:444
a @ mount-redraw.js:15
(anonymous) @ mount-redraw.js:25
requestAnimationFrame (async)
c @ mount-redraw.js:23
v @ router.js:111
Promise.then (async)
t @ router.js:126
S @ router.js:95
(anonymous) @ setImmediate.js:40
f @ setImmediate.js:69
a @ setImmediate.js:109
postMessage (async)
i @ setImmediate.js:120
p.setImmediate @ setImmediate.js:27
d @ router.js:143
p @ router.js:20
y.set @ router.js:182
s.attrs.onclick @ router.js:250
_.handleEvent @ render.js:888
mount-redraw.js:15 TypeError: Cannot read property 'onbeforeupdate' of undefined
    at render.js:929
    at f (render.js:407)
    at h (render.js:302)
    at render.js:477
    at f (render.js:416)
    at render.js:488
    at f (render.js:419)
    at render.js:488
    at f (render.js:419)
    at h (render.js:302)

IanM

Sheylam96 What exact action are you performing when this is triggered?

Sheylam96

IanM On the main page by clicking on a Tag or on the notifications icon

IanM

Sheylam96 interesting, thanks, I’ll look into it

IanM

Sheylam96 can you please share the output from php flarum info

Sheylam96

IanM

Sheylam96 Ok, so some of your FoF extensions need updating for beta 15 support, that's likely why you are seeing the error you describe.

For example, fof/merge-discussions is at 0.3.3 on your installation, whereas 0.5.1 is required for beta 15.

Run composer outdated and take note of the extensions that require an update. Ignore anything that is not an extension you have installed from that output, however

Sheylam96

IanM https://prnt.sc/w8g2bo

IanM

Sheylam96 Yep, so you need to update a bunch of extensions.

askvortsov/flarum-categories
flarum/akismet
fof/formatting
fof/forum-statistics-widget
fof/merge-discussions
fof/oauth

danielunited

I get Failed to load resource: the server responded with a status of 422 () error when trying to merge one my discussions into another one. What could cause it?

datitisev

danielunited Look at the response of the request. That's supposed to show the error as a validation error, but I guess that's old code and maybe doesn't work since a newer version or never worked.

phloo

As reported here, one merged discussion has the problem that it is always marked as read even though it has new replies.

Is this a known bug?

datitisev

phloo I think it is a known bug, yes. It'll be fixed eventually, I can't give a timeframe.

phloo

bump

clarkwinkelmann

If someone can open an issue at https://github.com/FriendsOfFlarum/merge-discussions/issues with the steps to reproduce that would be great. Does it happen all the time, or only with discussion with a given number of posts? Does it happen only when merging 1 into 2 or 2 into 1? etc.

phloo

Opened an issue. Hope this will get fixed.

Thanks Clark.

Hari

clarkwinkelmann technically is it possible to implement move single comment to another discussion feature?

in a way by modifying Merge or Split extensions?

FriendsOfFlarum/merge-discussions22

FriendsOfFlarum/split36

Hari

someone please reply

askvortsov

Hari It's definitely possible, but someone would need to implement it. For now, you can always split out individual comments and merge those new discussions into existing discussions.

Hari

askvortsov i have tried this splitting and to merge with old discussions it doesn't work. maybe its due to the missing discussion numbering.

Can you add this feature or make new extension? (Move single comment to another discussion) please feel free to quote 🙏 (i do understand it costs efforts)

Hari

askvortsov could you share your email id or twitter DM or its okay to message you here. is there any way to hire you for this?

« Previous Page Next Page »