FriendsOfFlarum Merge Discussions

matteocontrini

datitisev I needed this extension urgently just some hours ago, so I installed it but I had exactly that issue. Thanks for the fix @rob006

datitisev

0.3.3

Fix bug caused by 0.3.2 when refreshing discussion details (author, comments number...)
Fix issue with modal infinitely loading when an error occurred
Added better error handling
- DB changes will be rolled back if an error occurs during the merge
- Response will now return a validation error with an error message, instead of the generic 500 error

Updating

composer update fof/merge-discussions

[deleted]

Two updates in ten days. Thanks for the effort. Nice job!

matteocontrini

I'm having an issue with this extension, I'm unable to merge two discussions. Running 0.3.3.

(album)

Exception:

[2019-10-08 14:55:53] production.ERROR: PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '2480-111' for key 'posts_discussion_id_number_unique' in /usr/local/openresty/nginx/www/fibraclick-forum/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:117
Stack trace:
#0 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php(117): PDOStatement->execute(NULL)
#1 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/illuminate/database/Connection.php(483): Doctrine\DBAL\Driver\PDOStatement->execute()
#2 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/illuminate/database/Connection.php(657): Illuminate\Database\Connection->Illuminate\Database\{closure}('update `posts` ...', Array)
#3 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/illuminate/database/Connection.php(624): Illuminate\Database\Connection->runQueryCallback('update `posts` ...', Array, Object(Closure))
#4 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/illuminate/database/Connection.php(490): Illuminate\Database\Connection->run('update `posts` ...', Array, Object(Closure))
#5 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/illuminate/database/Connection.php(423): Illuminate\Database\Connection->affectingStatement('update `posts` ...', Array)
#6 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/illuminate/database/Query/Builder.php(2659): Illuminate\Database\Connection->update('update `posts` ...', Array)
#7 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/illuminate/database/Eloquent/Builder.php(818): Illuminate\Database\Query\Builder->update(Array)
#8 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/illuminate/database/Eloquent/Model.php(729): Illuminate\Database\Eloquent\Builder->update(Array)
#9 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/illuminate/database/Eloquent/Model.php(644): Illuminate\Database\Eloquent\Model->performUpdate(Object(Illuminate\Database\Eloquent\Builder))
#10 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/illuminate/database/Eloquent/Model.php(601): Illuminate\Database\Eloquent\Model->save()
#11 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/illuminate/database/Eloquent/Model.php(613): Illuminate\Database\Eloquent\Model->push()
#12 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/fof/merge-discussions/src/Api/Commands/MergeDiscussionHandler.php(101): Illuminate\Database\Eloquent\Model->push()
#13 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/illuminate/database/Concerns/ManagesTransactions.php(29): FoF\MergeDiscussions\Api\Commands\MergeDiscussionHandler->FoF\MergeDiscussions\Api\Commands\{closure}(Object(Illuminate\Database\MySqlConnection))
#14 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/fof/merge-discussions/src/Api/Commands/MergeDiscussionHandler.php(125): Illuminate\Database\Connection->transaction(Object(Closure))
[...]

robinodds

matteocontrini Same here.

Bel forum Matteo 👏

datitisev

matteocontrini Dang, looks like it ain't fixed. Do you know what exactly causes the error / certain steps needed to reproduce (like post counts, post dates, numbers, etc...)?

matteocontrini

datitisev I don't know...

These are the 2 discussions if you want to scroll them:

https://forum.fibra.click/d/2480-mappa-nodi-openfiber-rete-pubblica

https://forum.fibra.click/d/3829-accedere-a-mappa-nodi-openfiber

The second one is very basic, just some posts from today. When I tried to merge it with the first one there were just 2 posts.

The other one is older. As you can see there are about 100 posts. Some of them are deleted (soft deleted). The discussion has also been splitted twice (at least?), meaning that some posts were taken out of that discussion.

Nothing else I can think of. I've taken a look at the code that merges the discussions and I don't really understand it, so I don't know what I should check in the database exactly.

datitisev

matteocontrini I've taken a look at the code that merges the discussions and I don't really understand it,

That's me after trying to hard to make the damn thing work 😂

Might have to do with split, not sure. These issues are always hard to debug.

robinodds

matteocontrini Hai provato anche l'inverso? Ovvero unire la più datata nella discussione più recente? Di solito così funziona, devi solo poi rinominarla.

You could try to merge the old discussion into the new one. It worked for me when I tried. You only have to rename the discussion in order to have the same title as before.

@datitisev i got the same error without split ext

Prosperous

robinodds I know you are speaking to someone that speaks the same language as you however all discussions, unless those related to translations, are to be posted in English.

Thanks for your understanding. 🙂

matteocontrini

robinodds I haven't tried. I'm not going to do that in production though, I don't really trust this extension

datitisev

matteocontrini The output of the extension should be previewable through the "Preview" button. If an SQL query fails, it will roll back the changes made, so that shouldn't be an issue.

Ralkage

Hey @matteocontrini, we’ll look into your issue as soon as we’re able to and get back to you with any possible fixes or updates when we figure out what’s actually causing this.

Thank you for your patience so far 🙂

robinodds

I tried to merge discussions many times, almost always failing in doing it.
But I noticed that the error appears when I try to merge a recent discussion into an older one. Vice versa it usually works (older merged into a recent one).

IanM

We're also seeing this issue on the giffgaff community, since the 0.3.0 update.

I'll take a closer look at it and see if anything stands out 🙂

IanM

I’ve had some success with this issue today. Not entirely happy with the solution, but it appears to work for us on the giffgaff commmunity

I’ve opened a PR here

datlechin

Can't fine posts to merge

Littlegolden

datlechin This option "Merge with me" means you choose other discussions merge into this discussion. Your current discussion in the screenshoot is the only one that contains the "pixel" keyword, you cannot search for other "pixel" discussions that do not exist.

And actually.... the current discussion's keyword is not "pixel", it's "pixelphoto".... due to you put this two words together...

datlechin

Littlegolden thanks

and my site can't use markdown for images, Can you help me fix this problem?

therealsujitk

datlechin Please open a new discussion for this.

« Previous Page Next Page »