Catch The Fish

clarkwinkelmann

jaypatelani you can change the translations using the Linguist extension

Everything should be translatable.

jaypatelani

Is there a way for admin to check where current fishes are ? Also does round end date effect frequency of fish appearances on forum?

clarkwinkelmann

jaypatelani no I don't think there's any way to know where the fish are from the UI. You could look in the database and check the discussion_id, post_id and user_id on the fish table if you really need to find out. If I ever do an update I might try to add a link to where the fish is from the admin fish list.

There's no frequency. All the fish that were created are always on the forum, the number is constant. Only while some fish are in a user's basket they will be unavailable until placed or until the placement delay expires.

Lukeman

I really love this extension, thanks Clark for all your time and effort. I am going to use this on our forum which is dedicated to a game we're playing once a year.

One small remark though, I noticed the fishes are also placed in discussions which are only accessible for our moderators and not by our contestants. It would be great if it was possible to restrict the placement of the fishes to certain tags only.

clarkwinkelmann

Lukeman yeah it's a downside I have noticed.

I think the easiest solution for me to implement will be some sort of tag restriction.

I could also offer a group selection but unfortunately the way the Flarum permission system is designed doesn't allow querying for discussions a given group can see, we always need to provide a user. So another option would be to select one user and whatever that user can see is used as the value.

Not sure when I'll do that. Maybe during one of my future livestreams.

Lukeman

clarkwinkelmann A tag restriction would do the job for me and I'll be more than happy to sponsor this addition. Our game starts in march 2022 so no hurry 😉.

Edit: I noticed that on the rankings page somewhere along the way "place" has been renamed to "name". In my opinion "place" fits better,

Blind

clarkwinkelmann

I gave the registered user the right to fish anywhere in the permissions, but the test still only has management and can release fish anywhere, is this the case, or am I doing something wrong?

clarkwinkelmann

Blind I'm not sure I understand what you're describing. Can you maybe post a screenshot of the extension settings and permissions page?

Blind

clarkwinkelmann

No, I found that Chrome or Edge can't drag the fish in the fish basket, let the fish out; Firefox can work normally.

The login account I used for testing is on Edge, and the administrator is Firefox...

clarkwinkelmann

Blind can you try to connect each account in the opposite browser to confirm if it's a permission issue or a browser issue?

If the user doesn't have the permission to choose fish placement, the fish shouldn't end up in the basket. But if it's already in the basket and can't be moved out, it might just be a browser issue. If it was a permission issue, the fish could be dragged and dropped, and an error would appear.

Blind

clarkwinkelmann

I think it's Edge's problem, Microsoft Edge 93.0.961.44

Blind

Google Chrome 93.0.4577.63 is also this problem.
Firefox 92 Also use the account, but there is no problem.

clarkwinkelmann

Version 1.1.0

Added discussion tag whitelist setting
Added probability setting for each type of placement as well as individual discussion tags
Added current location of fish on moderation page
Fixed moderation page showing wrong last placement author

Update sponsored by @Lukeman

Lukeman

clarkwinkelmann Hi Clark, I noticed on extiverse that Catch the Fish isn't compatibel with Flarum 1.2.0. Any change this will change somewhere in the near future?

clarkwinkelmann

Lukeman do you receive any error message? Or is something not showing up?

I was not anticipating anything to break with 1.2, but I'll take a look if I have some hint of what might be wrong.

EDIT: I missed the word "Extiverse" in your sentence 🤦‍♂️ Well it does show compatible when I check right now so not sure what was up.

Lukeman

clarkwinkelmann I have not updated Flarum yet because I wanted to be sure Catch the Fish would still be working, Yesterday it showed not-compatible on Extiverse but now it shows compatible. Thanks for your answer, will update this weekend.

Lukeman

clarkwinkelmann Upgraded Flarum yesterday and all the fishes are happy 😆

Lukeman

@clarkwinkelmann although not gamebreaking but it looks like a little bug crept into "Catch the Fish":

When the alert with the round name is removed from the homepage through the settings, the rankingspage states that there is no active round. The fishes are shown though and can still be caught.

Would you be so kind to have a look at this?

clarkwinkelmann

Lukeman reading through the source code, maybe the catchthefish.visible permission is not being applied to fishes on the forum? From the code it looks like:

Rankings show all active rounds, but only if actor has catchthefish.visible permission
Fishes are shown on the forum if their round is active, ignoring catchthefish.visible permission

So maybe it's due to this?

The homepage alert logic doesn't seem to be connected to the rankings page.

Lukeman

clarkwinkelmann

clarkwinkelmann maybe the catchthefish.visible permission is not being applied to fishes on the forum

Hm, I'm not sure if I follow you correctly. How do I apply the catchthefish.visible permission to the fishes?

As an admin I have all six permission levels for Catch the Fish and I am the only one allowed to see the rankings page. The moment you switch on the alert the rankings page becomes available again and the other way around.

« Previous Page Next Page »