FancyBox extension beta

squeevee

MikeJones A testament to how out-of-the-loop I have been, I completely missed the beta 9 release. I'm looking into it, but this will almost surely have to go into 0.3-beta

squeevee

MikeJones see again Github.
If possible, I'd like to use that thread to diagnose this problem, rather than this one which is about the extension in general and its beta

MikeJones

squeevee sounds good will check it out later after work. Thanks for the support!

squeevee

iosmall I know it has been a while, my apologies. Please see my most recent reply to your issue on GitHub

cmcjacob

You may want to adjust your composer.json a bit. You are using the autoload feature incorrectly:

"psr-4": {
            "Squeevee\\FancyBox\\": "src/"
        }

The directory doesn't exist, and if you're only using that namespace in a single file (extend.php) it's not really required.

squeevee

cmcjacob good catch.

squeevee

If anyone is still having the following issues:

scrubber, reply composer, sticky or other discussion features do not work on some discussions
auto-images (via fof/formatting or similar) are displayed too small

Please make sure that you have version 0.2-beta installed by running

composer show squeevee/flarum-ext-fancybox

If you find you have 0.1-beta installed, I think

composer require squeevee/flarum-ext-fancybox:@beta

should do the trick.

mekici

squeevee Fancybox: I have installed the 0.2-beta version. However, the images added with the fof formatter look small and when clicked it opens on the new page

Liu

Installed 0.2-beta through Bazaar: no lightbox 🙁

Liu

mekici That's the issue we're having.

squeevee

mekici
Liu

This extension sizes images based on how they're arranged in the post's markup. When an image is inline with other text, then it is small on purpose. The fact that the lightbox isn't working is a known issue I'll have patched in 0.3-beta

You could work around it currently by making sure images are separated from text by at least two returns. (One return isn't considered a paragraph break.) For example:

Or you could use BBCode or Markdown with your images. This bug is more particular to fof/formatter.

I anticipate having 0.3-beta with a patch for this in the next couple of weeks.

Liu

squeevee Much appreciated, mate. Thanks!

MikeJones

On mobile, when you click an image it's not obvious how to get back to the text.

ozkan34

squeevee

does not work for beta 11.Does a new update come

MikeJones

ozkan34 does not work for beta 11.Does a new update come

Bummer, I love this extension

Kylo

ozkan34

MikeJones

I'm not sure what was not working for you but the extension is compatible and working well with beta 13.

Littlegolden

What I've seen from the source code, the extension currently looks for all images in posts which don't have any class names. Perhaps we can check their sizes before applying fancybox on them? What would you suggest?

I'm interested in developing this extension. Let me know if you've any issues, suggestions etc.

ozkan34

MikeJones

you can use the link below for now.

https://discuss.flarum.org/d/5146-modal-image-popup-on-click-only-for-advaced-webmasters

Littlegolden

It will affect the display of the shield.io icon. Do you have a solution?
Demo：https://discuss.flarum.org.cn/d/1209

Littlegolden

Kylo Most of these small images are badges generated by websites like shield.io / buy me a coffee. Perhaps we can add an option for this extension to allow users to add a whitelist of the source domain name of the picture, fancybox will not add effects to the pictures from the whitelisted domain.

MikeJones

Kylo it's been working again for me, not sure what the issue was

Kylo

Littlegolden badges are not the only case here:

« Previous Page Next Page »