Color Circles for Groups

clarkwinkelmann

Gatsu I'm not seeing any obvious problem by reading the code. I'll try to to a test when I have some time.

Did you try clearing the cache after enabling both extensions?

Gatsu

matteocontrini

clarkwinkelmann since what the other extension does is changing the text color with literally three lines of code, wouldn't it be easier to just incorporate the feature in this extension? 🙂

clarkwinkelmann

matteocontrini but then it would require settings to control which features are enabled. It's easier to have two extensions and enabling/disabling each feature by enabling/disabling the extension.

matteocontrini

clarkwinkelmann but then it would require settings to control which features are enabled

Probably

clarkwinkelmann It's easier to have two extensions and enabling/disabling each feature by enabling/disabling the extension.

Mmm not sure how that would be easier? Having two extensions for such small features seems an overkill to me. Both need to be kept updated by the maintainer, and they are a pretty useless duplication of code, aren't they? The other extension is a copy-paste of this one with just a few lines changed :/

clarkwinkelmann

matteocontrini I can't say I'm not bothered by the code duplication, but it would require more code to make those two features into toggleable features of a same extension than having two separate code bases.

And the re-used code is so simple and so short I don't think it's even worth the effort to change how it was done.

Also, I'm only maintaining one, and I don't think this extension needs to contain any more code or features 😇

Mark73

Gatsu Yup, I tried to enable both extensions at the same time, one works and the other doesn't!

Mark73

If one user is assigned to several groups, how does the extension decide which color will be given to him?

matteocontrini

Mark73 it takes the first group with a color, if present

https://github.com/clarkwinkelmann/flarum-ext-circle-groups/blob/eb6e37cc3496712578baefc529f42091ffbf1440/js/src/forum/index.js#L16

And with "first" I mean considering the default Flarum sorting, which is probably based on the order of creation of the groups.

AADev

Gatsu your extension becomes incompatible if colored username is present

@clarkwinkelmann I am also having this problem 🙂
The extension that will be enabled later will have effect and the other will lose effect

Also, is there any extension for highlighting staff members post and changing color borders to staff group color?

clarkwinkelmann

I have confirmed the incompatibility lies in the other extension which has re-used my initializer name MickMelon/flarum-ext-coloured-usernames4 I won't be attempting to fix it on my side.

AADev

clarkwinkelmann Thanks, I fixed it with your reference to the error 🙂

clarkwinkelmann

Version 0.2.2 has been released with beta 14 support.

clarkwinkelmann

Release 0.2.3

Previous versions are already compatible with Flarum beta 15, this update just adds the category and links for the new Flarum admin panel.

Razorlk

thanks.

clarkwinkelmann

Release 0.2.4

Added color to user profile avatar #9

All recent versions of the extension were and still are compatible with Flarum beta 16 already.

Gatsu

clarkwinkelmann Hi.
In extiverse is marked as incompatible with beta 16.

clarkwinkelmann

Gatsu that's because Exiverse assumes an extension will break between beta 15 and 16, but a very small number of them do not, including this one.

I will not be tagging additional versions to work around that, particularly on a low support extension.

clarkwinkelmann

Released version 1.0.0 with Flarum 1.0 compatibility.

huuduy216

@"clarkwinkelmann is it me or it's a little off center?

clarkwinkelmann

huuduy216 what is off center?

It's using CSS to add a border to the avatar. The radius is already defined by Flarum. I'm not sure how the circle could be misaligned with the avatar since the border and avatars are the same HTML node.

« Previous Page Next Page »