Thank you very much.

I've already tested it 😃 And it's a great job, it seems to work well !

7 days later

datitisev

Is there any backend permission necessary to make multi select work?
Only admin can vote for more than one option.

Also: if I create a new poll and check "Allow people to vote for multiple options" after creating the poll, the check remains unchecked and set back to disallow. I can change it with edit as admin which shows "Poll allows voting for 4 options." but it is still not working for other than admin users.

Flarum 1.8.1
PHP 8.2.7
MySQL 10.3.39-MariaDB

I did migrate after updating and clear cache.

    @datitisev

    I tested it with my members using several polls.

    For me, everything works fine.

    However, I have a small issue with the display on phones.
    The polls are displayed a bit randomly.... Wouldn't it be easier to display one answer per line ? 🙂

    Photo :

      Update : I fixed my issue with small modification in CSS :

      .PollOption {
        width: 100% !important;
        float: right !important;
      }
      
      .PollBar {
      margin-left : 30px !important;
      }

        Wlork Thanks, I will implement this as well. At first I thought of limiting it with a mobile media query, but it looks good on Desktop.

        Wlork Looks like it wasn't just phones - long poll answers would break basically all devices.

        I have a PR that I'll probably merge later today or tomorrow that resolves these issues and a few others - FriendsOfFlarum/polls71.

          datitisev Great !

          Your fix will also work for images ? I also noticed that if we put images of different sizes, options weren't aligned either 🙂

            Wlork Yes, they look fine. In addition, to improve the grid, options with images will be shown before options without, that way non-image options aren't sprinkled in and making the poll use up more space.

            screenshot

            Honestly, not too sure about grouping the image options (either before or after non-image) as it does not follow the order visible in the poll settings... but otherwise there's a lot of empty space. It might make more sense to put image options at the end instead of at the beginning, though 🤔 Or perhaps to not reorder them at all.

              datitisev Great ! 🙂

              Regarding the order of answers, I give my personal opinion:

              I wouldn't reorder them at all (or at best, put an option in Admin to allow automatic reorder, if possible).

              I think that the member who will make a poll, will classify the answers naturally 🙂

              1.4.2

              Various UI & UX improvements in FriendsOfFlarum/polls71.
              These changes may affect any theme or custom LESS targeting FoF Polls!

              • Improve layouts of poll's options list and content of options themselves
              • Fix duplicate timing message when the poll timer has ended
              • Load votes for votes modal after opening, instead of before
              • Improve layout margin & image positioning
              • Use grid for voters list in modal

              screenshot

                datitisev

                It works great :

                Thanks for this improvement.

                I'm glad this extension is evolving. We use it often, and their reviews are very positive because the polls integrate very well and are minimalist (there's just what's needed).

                We hope soon to be able to put a poll in any post (as you know, I've already made a proposal).

                In the meantime, congratulations and thanks again for the improvements 🙂

                8 days later

                datitisev

                m4v3rick

                Updated to 1.4.2 still doesn't work. The user trying is supermod and can even change the poll but can't vote for more than one option. Admin is able to select more than 1.
                Tried it with Max votes per user=0 and Max votes per user=4 - still only 1 vote possible if not admin.

                Flarum info:
                +------------------------------------+---------+--------+
                | flarum-flags | v1.8.0 | |
                | flarum-suspend | v1.8.0 | |
                | flarum-approval | v1.8.0 | |
                | flarum-tags | v1.8.0 | |
                | flarum-markdown | v1.8.0 | |
                | afrux-forum-widgets-core | v0.1.7 | |
                | fof-spamblock | 1.1.0 | |
                | fof-pages | 1.0.5 | |
                | flarum-subscriptions | v1.8.0 | |
                | fof-byobu | 1.3.1 | |
                | v17development-seo | v1.8.0 | |
                | therealsujitk-gifs | v4.1.1 | |
                | sycho-move-posts | v0.1.7 | |
                | rob006-last-post-avatar | 1.2.4 | |
                | luceos-dofollow | v1.0 | |
                | justoverclock-welcomebox | 2.0.2 | |
                | justoverclock-staff-members-widget | 0.1.3 | |
                | justoverclock-popular-tags | 0.1.3 | |
                | justoverclock-guestengagement | 1.0.3 | |
                | justoverclock-country-flags | 0.2.1 | |
                | justoverclock-contactme | 0.2.3 | |
                | fof-username-request | 1.1.2 | |
                | fof-user-directory | 1.2.3 | |
                | fof-upload | 1.2.3 | |
                | fof-terms | 1.2.1 | |
                | fof-stopforumspam | 1.2.3 | |
                | fof-split | 1.1.0 | |
                | fof-sitemap | 2.2.0 | |
                | fof-share-social | 1.1.2 | |
                | fof-recaptcha | 1.2.0 | |
                | fof-pretty-mail | 1.1.1 | |
                | fof-polls | 1.4.2 | |
                | fof-nightmode | 1.5.2 | |
                | fof-merge-discussions | 1.4.0 | |
                | fof-links | 1.1.4 | |
                | fof-linguist | 1.1.1 | |
                | fof-ignore-users | 1.2.0 | |
                | fof-html-errors | 1.1.1 | |
                | fof-forum-statistics-widget | 1.1.0 | |
                | fof-formatting | 1.0.3 | |
                | fof-follow-tags | 1.1.7 | |
                | fof-drafts | 1.2.2 | |
                | fof-disposable-emails | 1.0.0 | |
                | fof-default-user-preferences | 1.2.0 | |
                | fof-cookie-consent | 1.1.1 | |
                | fof-bbcode-details | 1.1.1 | |
                | fof-ban-ips | 1.0.3 | |
                | fof-analytics | 1.1.0 | |
                | flarum-sticky | v1.8.0 | |
                | flarum-statistics | v1.8.0 | |
                | flarum-mentions | v1.8.0 | |
                | flarum-lock | v1.8.0 | |
                | flarum-likes | v1.8.0 | |
                | flarum-lang-german | 1.6.0 | |
                | flarum-lang-french | v4.12.1 | |
                | flarum-lang-english | v1.8.0 | |
                | flarum-emoji | v1.8.0 | |
                | flarum-bbcode | v1.8.0 | |
                | extiverse-mercury | 0.2.0 | |
                | datitisev-maintenance | 1.1.0 | |
                | darkle-fancybox | 1.1.2 | |
                | clarkwinkelmann-emojionearea | 1.0.0 | |
                | clarkwinkelmann-circle-groups | 1.0.1 | |
                | blomstra-usercard-stats | 0.1.2 | |
                | askvortsov-moderator-warnings | v0.6.1 | |
                | afrux-top-posters-widget | v0.1.4 | |
                | afrux-online-users-widget | v0.1.6 | |
                | acpl-mobile-tab | 1.1.1 | |
                +------------------------------------+---------+--------+
                Base URL:
                Installation path:
                Queue driver: sync
                Session driver: file
                Scheduler status: Aktiv
                Mail driver: smtp
                Debug mode: off

                One more info - just checked a few settings:

                It won't work with:
                Participate
                Vote on polls - all members
                Change vote - admin

                Works with:
                Participate
                Vote on polls - all members
                Change vote - all members

                So basically users can vote and change their votes which shouldn't be working because sometimes they shouldn't be allowed to change their votes.

                But in order to work for multiple options it might be the problem if the possibility of changing a vote is restricted. Maybe this could be handled differently?

                  m4v3rick Hm, that is indeed a problem. I don't know what the best way of handling "changing vote" would be... Perhaps just not letting users 'unvote' options but still voting for more? Because options are voted for individually, so I don't know how else this would be done without changing that whole system for, I think, worse UX 🤔

                    datitisev I'm not sure I understood his request ?

                    But why not add an option to allow or not a change vote. And if you click on OK, a button appears "Click to change your vote(s)" ? 🙂

                      Wlork What I believe they said is that if a user doesn't have "change vote" permission, they can't currently vote for more than 1 option. How the extension currently works is that you vote for one option, then either vote for more (if you can) or unvote from that one and vote for another. Thus, a user without "change vote" permission can only vote for that first option in polls that allow multiple votes.

                      Adding a button to confirm votes would fix this, but that seems like worse UI to me. Where'd you put that button? At the bottom of a long list of poll options that people on mobile phones might miss? UX wise, I believe the current implementation is best, but that does cause issues with changing votes.

                      I think the "change vote" permission could be refactored into not allowing vote changes after some time, similar to editing tags. That would probably make it work without degrading the user's experience 🤔

                        datitisev You're right !

                        Polls are easy to use thanks to the light interface and I think it's important not to break this.

                        Change or not our votes for a limited time.... Yes, your idea seems better to me 🙂

                        Wlork I'm not sure I understood his request ?

                        Sry, it was late and I was tired. Guess that's why it sounded really awkward. 🙁

                        Wlork OK, a button

                        datitisev Adding a button

                        Yep, I thought the same, but I can totally understand your ( @datitisev ) concerns.

                        datitisev I think the "change vote" permission could be refactored into not allowing vote changes after some time, similar to editing tags. That would probably make it work without degrading the user's experience 🤔

                        It would be the same as "Allow post editing" (Indefinitely, 10min, until next reply) but maybe with a custom time interval. This solutions sounds great actually.