FriendsOfFlarum Polls

datitisev

Wlork Those conditions are mainly to get the best data. Data that has been through a lot of other extension use for a long period of time, as it'd lead to more unpredictable scenarios. You can test it if you want; any amount of testing is helpful.

Wlork You mean it will be possible to create several polls in any post ?

Indeed! See FriendsOfFlarum/polls74.

Wlork

datitisev

I'd like to test, but I don't have much data (I have only two polls that are actually used) and as I'm not 100% familiar with Flarum yet, I don't want to take any risks on my forum which is active 🙁

The best I can do is create a test forum, create 10 or 20 polls with v1 and then test v2. But I don't know if that would be as effective?

datitisev Indeed! See FriendsOfFlarum/polls#74.

I like the changes you've made to the buttons 🙂

Oshvam

Hi @datitisev would it be possible to show the number of votes in a poll? Right now you can only see the activity of a poll by entering the voters, it's not a problem when there are few votes, but if a poll has a lot of activity (100 votes, for example) you wouldn't be able to see that data.

I was wondering if it would be possible to add a line of text below the poll "Total votes: 100".

datitisev

Oshvam It's definitely possible. I don't love the idea of just adding this info underneath with more lines of text, but also can't really think of a simple way to show it. Either way, I won't include it in my initial bulk of changes coming, as that's convoluted enough.

Eldenroot

Oshvam definitely needed!!!

Wlork

@datitisev

I create 20 polls in my forum test in v1.

What next ?

I type these commands :

composer require fof/polls:dev-ds/move-polls-to-posts
php flarum migrate

I test v2 and tell you if the v1 polls have been deleted or not. Is this correct? 🙂

datitisev

Wlork Indeed. If you just created normal discussions with polls without doing much else, there's less of a chance that any of the polls will be deleted. The deletion comes into place when the first post associated with a discussion can't be found -- which means v1 polls would not be showing that poll anyways, leading to the deletion to not destroy any visible data.

If any polls have been deleted, you can go ahead and restore from a DB backup and see if their discussions showed that poll in v1. If not, then there's no issue.

To go back from v2 to v1, you'll need to disable polls & click the "Purge" button to delete all the fof/polls data from the DB. Then you can use composer to go back to a stable version.

Wlork

datitisev

So.... 🙂

I created 10 polls with v1
I left the extension enabled. No purge
I typed the command :

composer require fof/polls:dev-ds/move-polls-to-posts

And :

php flarum migrate

Many errors :

In Connection.php line 712:

SQLSTATE[42S22]: Column not found: 1054 Unknown column 'discussions.first_post_id' in 'field list' (SQL: update NameDBpolls inner join
NameDBdiscussions on NameDBpolls.discussion_id = NameDBdiscussions.id and NameDBdiscussions.first_post_id is not null
set NameDBpolls.discussion_id = discussions.first_post_id)

In Exception.php line 18:

SQLSTATE[42S22]: Column not found: 1054 Unknown column 'discussions.first_post_id' in 'field list'

In PDOStatement.php line 117:

SQLSTATE[42S22]: Column not found: 1054 Unknown column 'discussions.first_post_id' in 'field list'

My forum (test) has turned empty. There's only the navigation bar.

I had to deactivate the extension to see my forum again. And it's impossible to reactivate FoF Polls without purging. The v1 polls have disappeared. I was able to test the v2 polls and at first sight they work fine.

datitisev

Wlork Well, that was helpful testing! My code didn't work with Flarum setups that utilized SQL table prefixes. That should be resolved with my last changes. Before trying them out, either have a v1 setup or purge the extension (I split a migration file into two, so that'd run again and cause issues). I do remember composer sometimes being finicky with updating dev branches that are required, so I don't know if running that command again will update successfully or not.

Wlork

datitisev

Glad I could help you !

I created polls in v1
FoF Polls v1 enabled. No Purge.
I typed these two commands in order.

No problem with SQL !

However, the v1 polls have disappeared. BUT ! By deactivating FoF Polls (no purge) and reactivating it, the polls reappeared in v2 🙂 !

I've noticed a small issue with v2 polls. When I edit a poll, I have to refresh the page to see modifications.

I don't know if this is a bug or if it's intentional ? If it's intentional, then everything's fine.

Tomorrow I'll do some more test. It's getting late here 😛

datitisev

Wlork This is my fault for bundling those changes with that PR, I thought I had separated them into the other one to be honest. But that's good, because those are not breaking issues and just simple regressions. Thank you, though.

Wlork BUT ! By deactivating FoF Polls (no purge) and reactivating it, the polls reappeared in v2 🙂 !

You probably needed a cache clear. You were using the old code which had polls associated with discussions, of which it found none once the move to post association was made.

EDIT: I've fixed the issue with the vote count remaining. The issue regarding changes to the poll is fixed in the 2nd PR, which if you want to test, you can do with composer require fof/polls:dev-ds/more-breaking-v2-changes (contains v2 DB breaking changes from ds/move-polls-posts)

Wlork

@datitisev

I tried again and no problem with SQL 🙂
However, you need to remember to deactivate (no purge !) and reactivate extension FoF Polls to "transform" v1 polls into v2

And I was able to test more v2 polls.

Bugs :

Affected : everyone

If we make any changes (title, answers, images, options, end date, etc.) to our survey, we have to refresh the page manually to see the changes.

You've made changes to the way you edit a poll (and I like it). I think this bug comes from this modification, because v1 doesn't have this problem.

Affected : those who don't have "View results without voting" permission.

If we cancel our vote (our last choice, in the case of multiple answers), the count (%) remains. You'll have to refresh the page manually to reset it to zero.

I haven't noticed any other issues 🙂

If you want me to test v2 polls in its entirety, I'll do it 🙂

Wlork

datitisev You probably needed a cache clear. You were using the old code which had polls associated with discussions, of which it found none once the move to post association was made.

That's right, just clear the cache 🙂

Wlork Affected : everyone
If we make any changes (title, answers, images, options, end date, etc.) to our survey, we have to refresh the page manually to see the changes.

You've made changes to the way you edit a poll (and I like it). I think this bug comes from this modification, because v1 doesn't have this problem.

Fixed ! 🙂

Other issue :

However, when you add a poll to an existing post, you have to manually refresh the page to see it appear....

datitisev I've fixed the issue with the vote count remaining.

Fixed 🙂

Others issues :

When you delete a post, the poll(s) are not hidden.
member can create a poll in discussion or on one of its existing posts but don't have the permission to create a poll in a post.

Due to the permission issue, I wasn't able to test further. Let me know when you update the test extension 🙂

datitisev

Wlork I fixed those issues, except maybe the last? I thought I remembered reproducing that permission issue, but I no longer can (even when I revert my changes). I also did a lot of other permissions / visibility scoping changes, so who knows.

If you find anything else, could you start a review comment on the PR itself? I'd rather move the conversation there so we're not spamming this discussion even more with a one-on-one conversation 😅.

Thank you for all this testing though 🙏 really appreciated.

Wlork

datitisev I fixed those issues, except maybe the last? I thought I remembered reproducing that permission issue, but I no longer can (even when I revert my changes). I also did a lot of other permissions / visibility scoping changes, so who knows.

I confirme, everything has been fixed 🙂 except :

member can create a poll in discussion or on one of its existing posts but don't have the permission to create a poll in a post.

This is the only problem I can see 🙁

As admin, I don't have an issue. I can create a poll in a discussion, in a post or in an existing post.

As a member, I can create a poll in a discussion or in an existing post. But I can't create a poll in a post.... I have to write something first, validate my answer and then "Add poll" (like an existing discussion).

datitisev If you find anything else, could you start a review comment on the PR itself? I'd rather move the conversation there so we're not spamming this discussion even more with a one-on-one conversation 😅.

😅 I don't use Githud much, but I'll think about it next time.

datitisev Thank you for all this testing though 🙏 really appreciated.

It's normal to help you, you're already doing an amazing work 🙂 !

datitisev

Wlork I was able to reproduce with the post edit perm set to until next reply. I modified the permission check to only check for editing perms if the post exists (i.e. not when posting one). Should be working now.

Wlork

datitisev I posted on GitHud : FriendsOfFlarum/polls74

😉

datitisev

2.0.0

🛑 BACKUP BEFORE UPGRADING TO THIS VERSION 🛑
This version contains database refactors that make the data incompatible with 1.x if you try to downgrade.
If you encounter errors, you WILL need to have a backup of all the polls tables available to go back to 1.4.2. Permission names have also changed, so a backup of group_permissions would also be helpful.

Massive thanks to @Wlork for their help testing all these changes!

Upgrading

Save a backup of your database -- mostly the polls, poll_votes, poll_options, and group_permissions tables -- before continuing. If you don't have any polls in your forum and haven't configured polls permissions, you can skip this step.

The migration process will delete polls in discussions that don't have associated first posts (discussion's first_post_id = null and no post exists with number = 1). These polls would not have been visible in v1, and so removing them should (theoretically) not cause any visible data loss - check the Flarum log after migrating to see if any polls were deleted.

composer remove reflar/polls # only if you have it installed - otherwise it won't upgrade to v2
composer require fof/polls
php flarum migrate
php flarum cache:clear

Changelog

Drop flatpickr (FriendsOfFlarum/polls72)
Create posts with polls (FriendsOfFlarum/polls73)
Move voters button next to heading
Add polls to existing posts
Separate edit permission into own created polls & polls in own posts
- To be able to edit a poll, one of the following conditions must be true:
  - User has poll moderating permission (edit & remove polls)
  - User can edit post, created poll, poll hasn't ended, and user has edit own polls permission
  - User can edit post, created post, poll hasn't ended, and user has edit polls in own posts permission
- If post editing permission is set to reply, and user cannot edit their post (because a reply was posted) and doesn't have the poll moderate permission, they won't be able to edit the polls in said post

Full Changelog: FriendsOfFlarum/polls1.4.2 → 2.0.0

Wlork

datitisev Massive thanks to @Wlork for their help testing all these changes!

🤝

Thanks to you for making these changes, it's a big update ! 😃

Oshvam

datitisev When I run

composer require fof/polls
php flarum migrate
php flarum cache:clear

It does not update. I still see the previous version of fof/polls. Is there a step I missed?

Steve33

datitisev whitemode does not look good.

Wlork

@datitisev

We've detected a bug.

When we create a poll in a non existing discussion or post, when we want to modify the poll before you send the message, the end date is automatically set. Impossible to delete. If we delete it, it comes back with 01/01/1970.....

You have to cancel everything and restart the creation of discussion or post without modifying the poll in order to pass.

I could be wrong, but that would explain the weird bug I had during the test.

datitisev

2.0.1

Add setting to change max options allowed in polls
Fix poll end date set to 0 (start of Unix time is 1970) when editing a poll before posting (Wlork)
Add 'hide votes' option until poll has ended
- Nobody can see vote count or voters if the poll has not ended (this includes admin & owner for now)
Fix poll end date being able to be set past 2038 -- SQL column currently maxes out at 2038/01/18
Convert poll options into single settings column
- Since we don't query DB using these options, they can just be a JSON field to decrease the amt of columns
- The old columns will remain until it's clear that the migration works well and that they can be removed w/o issue

« Previous Page Next Page »